From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82171346FA6 for ; Wed, 4 Feb 2026 17:01:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770224475; cv=none; b=YdDsJ/CpzzhS2tT2MepIkXTwS7Xh0pgFccw6Ma6nFKCFFUjccunlmbUOog9kSI1ke+5uI2NQBTxsGjp/yD5NrWzAT3u3kpXwpCxr1EvdPgVm/zklnu110z2k4QGbqe0kxGwgougO6K5wNhrofO+V9SFunHMB7J3PEwAaL9DrFFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770224475; c=relaxed/simple; bh=axyqzuh+nfuIgh+LK6EsDdGL27Q8CwXPsTaEaTeezNc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BPZJHYX+Q4MHRJHFkrZBmsybGl78gOBTNWr+b2kntkUv/Q+3zXD6G1mLww4UA5eNFr2dCUBVnBoQv4f7ayD5tjeLQK8O50Uv+NSS/h78nk3YMjg1pqUcrbHQg9+7ojh9FnigCvZkahL0cFSGfE6JN8gTDmZ65UCDHRqlMXWcdX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oye9RtcC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Fs8WjUQB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oye9RtcC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Fs8WjUQB" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 614CITrC111325 for ; Wed, 4 Feb 2026 17:01:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cIOuyFPYn9l0C0uR0YsRIcPMqORnM7AnLgYzjEjzmRY=; b=oye9RtcCXrhouRZC AFT1PqkBj3wjjVih85jBl+u7g2yIXHTMapm1TJ+M8fhpvVtV7VRT6ZDgLbCbhlE0 Ofjc8SUEO97qL9I6IdR57gmB2fzq6KtpMKhL/nDW7l4GziNuItqfyYeGS2bq3gQ8 t04CEBzwYFfsKC5GRfjV94jSKLJmBrvrfmEdQTj/lTpECo+v4na5TU0Dw8Q2woZb 66uKKOKryPVZ9T7JsijyL9CcPHOM432M0WSLYZrqBFGgkHfRy4HT7vcOFnXiqe6g lvs7Sb5Z8Q5r2R0tLVxmHLqB35q0IwKxC0Ua/MGb61zQ6Qfy9qqSiBc9azN6Hhku y5pUhA== Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c44xjh377-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Feb 2026 17:01:14 +0000 (GMT) Received: by mail-ot1-f70.google.com with SMTP id 46e09a7af769-7d18998e3b6so15684a34.0 for ; Wed, 04 Feb 2026 09:01:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770224474; x=1770829274; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cIOuyFPYn9l0C0uR0YsRIcPMqORnM7AnLgYzjEjzmRY=; b=Fs8WjUQB3qGSc1P9lRlqdU3RtmcSa/KxfZoHtmqxRYMApt9XLMq6UeSO26lZEpYw2g hgTYiZZk+jdG4AKazG3ovOpRRKs+DyRvps/4F6fbmPVy/6A58H/sAaowVxt/Pio/rL/B tJPJo0QJLZKii0LZsAWrfrFgi7rRCHxlO4hxTtICxiEiKVpPYs6/PUE/n3aICs4fEmVM kq0XwDtlK6pEA7DJju4PgNy0n9uhlphkVTefN43OrPdz+AHZmX8Ii3WrtE4Wyr2+aKg4 b7C85SLxe+V6Nd77ztrSNt8UJKewCNRiiQhadSZNUf44TGJ93KV6OU8BQK5T6GTsTJRx Pzfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770224474; x=1770829274; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cIOuyFPYn9l0C0uR0YsRIcPMqORnM7AnLgYzjEjzmRY=; b=I+qx2JmZ0eS9UjpazWX/MDpvuJqbAZofhTrUZuyG7FdBx500R2rCTfVMrXIFNnEiXp hawNl9AXRimFP7qRz2u1klneFoxo4jqxfKkMK4doPtaxf7ReE9umtSI8nbTy8C7BCKcJ B5SJu7K1DAEw4aGS864du9ivc2RWcWdV+9zWpmsrvezK3KQ9WdGuV9JpIGUEQgfWdVdP md9aaC5jRqPz9F6cc5L4XJ+oWaAOYlZTskOSsgMb0wvyzGm0VTAvfj0SxWFGTZiJ/Xuj K8kWZ5rRPNF73cVSX17q1tH7IMFGyH3oSo259ynOghl01kdNi2R1qNX4yLdje5JVILLh g2vg== X-Forwarded-Encrypted: i=1; AJvYcCV9u9s8ISAtDm3tbpjkVeODAb9G/hgewyIGuOSy+eQt7k4mvCFrEjaE5qwLbtnJWM02MC4VS2ReJbdCZeg=@vger.kernel.org X-Gm-Message-State: AOJu0YxVMfNO80Z764USywajHbFNi82giJHI/2hFwEtHzimFgBhiTsNL XSC6/xl8DXo8YgqaBOI/JjRFYxMJu0DTzPLeGuLiA7IEte/D9RUq/fyuOig9V96JWoPqP4ldx5I 65BCKqpkQgBqd3fnP3mN6UA/a2ieMozQDaVpWMpMvRUYH1g7ZBD3iFsrfoqSXUz+2NL8= X-Gm-Gg: AZuq6aLmncbMaYrkhavPMbIXbVzkMmHlGx1mCYliIzK8xzvgcr3bYrwLzL1CpTBv9rf FBH87Xf551gUcjDJxjjrYWvzsbmEO78kN/kLPXoGkaxyxjANdAEW2B0rG1flx23q2SJehlxR8R4 1b+PSEbhB2dKmeVb6Wb6wApSow3f5yXWrqPU+RMLBqAiY74stn/p2X/ThOPKw5VdZbrPR9xF3Pd FCjpd6jHN1z2mtpdSGngN4o3H5uonEF+0E3GBHBfuhTCTD0nxc3kxyvsw+8G05dFCccKeubgeqk Xu/M07UP+rOCEu4PseiX7iUzIVYF3XAMlVHIrOBNlaA19Z0D1Vj7OIAerD5g5OYpWGmr2QBvTm7 AlDflQOeV1gUL8vp57ec8XeB+pHfs6Cc2oilh7ndP+I3QaxNKaoBI3GI+wTWlDonJG3Y= X-Received: by 2002:a05:6830:92a:b0:7cf:d117:88c4 with SMTP id 46e09a7af769-7d448c2348emr1443876a34.6.1770224470441; Wed, 04 Feb 2026 09:01:10 -0800 (PST) X-Received: by 2002:a05:6830:92a:b0:7cf:d117:88c4 with SMTP id 46e09a7af769-7d448c2348emr1443847a34.6.1770224469981; Wed, 04 Feb 2026 09:01:09 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8e9fcd8f7csm138531066b.14.2026.02.04.09.01.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Feb 2026 09:01:09 -0800 (PST) Message-ID: <9917eca6-1543-44f0-b0c3-388a85b80e93@oss.qualcomm.com> Date: Wed, 4 Feb 2026 18:01:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] spi: geni-qcom: Add target abort support To: Mark Brown Cc: Praveen Talari , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, prasad.sodagudi@oss.qualcomm.com, mukesh.savaliya@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com References: <20260204162854.1206323-1-praveen.talari@oss.qualcomm.com> <20260204162854.1206323-5-praveen.talari@oss.qualcomm.com> <68908c06-390e-4717-bab2-708de7f5cec4@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=DtpbOW/+ c=1 sm=1 tr=0 ts=69837b5a cx=c_pps a=7uPEO8VhqeOX8vTJ3z8K6Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=E70cyP_rRQkSMiAniigA:9 a=QEXdDO2ut3YA:10 a=EXS-LbY8YePsIyqnH6vw:22 X-Proofpoint-GUID: kIgDaHxkpGrJjmhyz2oT0XjbWghJqb4D X-Proofpoint-ORIG-GUID: kIgDaHxkpGrJjmhyz2oT0XjbWghJqb4D X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA0MDEyOSBTYWx0ZWRfX5ms4kyk7WG9A BLPGeL3EhF1EDlpNPUVGpJ7mIW924n2ajI/WEn09+rHjlDCi7ZlbY0gXURc97e57nRds/PIei69 Fl9AMUfLa35WH+d5v6USITAq4m8D2+mwV5c2ZewaojQJdaB2NXAHGyznxd+sovxlf+tWE2d+1V6 wxS9yzOhmabeQlRQqmWJVUHszlJrAHzyGDj0GEyFrjoGxhMndpCxlsUk2d95gz8tkzEliI2NH69 bqZLBGvhqqoEmnK4KAe9gmyTScYvZaHPNx8ixAUEr27vVS5iCgydsLEnUMAZTjFthURgkiaA9HJ gmDSkLJ+LRAL0gK9Egu4+x+oVUvBWRdXiuZnsSoJlZiJhjiEO3+dfiiNqYLwYqM6AXC0SSOty3N TIhOal6zq+dy8JUVtiemRxleuJD5db0YSpD+zR4WoIZTcgMdxoVXcT3Ni3eVUlyQ3rrP2yKLWfw rEIemFIp/S8/opsTCiA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-04_06,2026-02-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 bulkscore=0 phishscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602040129 On 2/4/26 5:57 PM, Mark Brown wrote: > On Wed, Feb 04, 2026 at 05:41:46PM +0100, Konrad Dybcio wrote: >> On 2/4/26 5:28 PM, Praveen Talari wrote: > >>> + if (spi->target) >>> + spi->target_abort = spi_geni_target_abort; > >> The same check is made in core: > >> spi_target_abort() >> -> spi_controller_is_target() > >> So I'm assuming the intention was to allow assigning the func pointer >> indiscriminately. Other drivers seem to do it both ways. > >> Mark, any specific preference? > > Not really TBH, it's redundant in the driver but if the people working > on the driver find having the check there saves them having to check > that the core does the right thing that's fine. It's not like this is a > fast path. Thanks Reviewed-by: Konrad Dybcio Konrad