Re: [PATCH V2 1/4] dt-bindings: clock: Add crypto clock and reset definitions

[Anusha Canchi <quic_anusha@quicinc.com>]

On 5/16/2023 1:15 PM, Bhupesh Sharma wrote:
>
> On 5/15/23 8:37 PM, Anusha Rao wrote:
>> Add crypto clock and reset ID definitions for ipq9574.
>>
>> Signed-off-by: Anusha Rao <quic_anusha@quicinc.com>
>> ---
>>   Changes in V2:
>>     - Separated out the clock/reset binding changes to a new patch.
>>
>>   include/dt-bindings/clock/qcom,ipq9574-gcc.h | 4 ++++
>>   include/dt-bindings/reset/qcom,ipq9574-gcc.h | 1 +
>>   2 files changed, 5 insertions(+)
>>
>> diff --git a/include/dt-bindings/clock/qcom,ipq9574-gcc.h 
>> b/include/dt-bindings/clock/qcom,ipq9574-gcc.h
>> index 5a2961bfe893..86790efa10f0 100644
>> --- a/include/dt-bindings/clock/qcom,ipq9574-gcc.h
>> +++ b/include/dt-bindings/clock/qcom,ipq9574-gcc.h
>> @@ -210,4 +210,8 @@
>>   #define GCC_SNOC_PCIE1_1LANE_S_CLK            201
>>   #define GCC_SNOC_PCIE2_2LANE_S_CLK            202
>>   #define GCC_SNOC_PCIE3_2LANE_S_CLK            203
>> +#define CRYPTO_CLK_SRC                    204
>
> For uniformity, please use GCC_ prefix int the above define as well.
> Also make the similar changes at the places where this CLOCK_SRC macro 
> is used.
Sure, will update in the next spin.

Thanks,
Anusha
>
> Thanks,
> Bhupesh
>
>> +#define GCC_CRYPTO_CLK 205
>> +#define GCC_CRYPTO_AXI_CLK                206
>> +#define GCC_CRYPTO_AHB_CLK                207
>>   #endif
>> diff --git a/include/dt-bindings/reset/qcom,ipq9574-gcc.h 
>> b/include/dt-bindings/reset/qcom,ipq9574-gcc.h
>> index d01dc6a24cf1..c709d103673d 100644
>> --- a/include/dt-bindings/reset/qcom,ipq9574-gcc.h
>> +++ b/include/dt-bindings/reset/qcom,ipq9574-gcc.h
>> @@ -160,5 +160,6 @@
>>   #define GCC_WCSS_Q6_BCR                        151
>>   #define GCC_WCSS_Q6_TBU_BCR                    152
>>   #define GCC_TCSR_BCR                        153
>> +#define GCC_CRYPTO_BCR                        154
>>     #endif