From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EDDCC433E1 for ; Tue, 26 May 2020 15:45:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D326206D5 for ; Tue, 26 May 2020 15:45:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WFxRU/dX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730125AbgEZPp0 (ORCPT ); Tue, 26 May 2020 11:45:26 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:49277 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729309AbgEZPpZ (ORCPT ); Tue, 26 May 2020 11:45:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590507923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Dt6LQHnd8XQKjoczzuKu5+J73yx/PTFTJmXrE029Qj0=; b=WFxRU/dXAN6kUGMa//XzU+8ee6lVIeUskhLksL+KpND2p2CGLRykLwk230HKo64n7ZFXyS Y3/KQAyVrgiyz7tRQmfkCA0oX8RohUGOiJQsHSYMMPM2HX4c7AtLxakfMFe+LZSEKTT84r xvyU2JnZ43b36N+ruXdRaCITOeXoP7M= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-25-xhhkL8r_PWqfEgnnDd8dmA-1; Tue, 26 May 2020 11:45:20 -0400 X-MC-Unique: xhhkL8r_PWqfEgnnDd8dmA-1 Received: by mail-wr1-f70.google.com with SMTP id z5so9926605wrt.17 for ; Tue, 26 May 2020 08:45:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Dt6LQHnd8XQKjoczzuKu5+J73yx/PTFTJmXrE029Qj0=; b=nRAIHQqe4MOem8mWzZ7d+7J/U/nrQxNmPFx7Z8Mp4PBx5A8qcQNNs+GpusJFTsABUc wAgs9/9xF4gMTj/QoROp7YNykWgUddudqaiXC6O0efIGF/Z8QjeHPp7Od6I7NbKLaDfL gWhoJT35faADUEI0B11jcC0EmcP6Ji8TqClPJ/uWYty+y2NhDroGnCHmLCinPi61+upB zdzvYSovdjdhaGj0ELpNZ2HiJObMutuD8WKHLwS2U9KCKwIy9+m3I4pNdEl5K+/KTU4Y /ZVoKyyDIdyEiC8qW/IAO0fi7PhIU80eg1FObNLHVNlWsn+SX3/UkQjIW9ZKTnw1EBZz sWhw== X-Gm-Message-State: AOAM532eHsUPleXfYZLQONon+9L29SxRoKWsUElOFqwsOnwSrb59K0Cn AiOkvMLs43pKQraq6gTc8SP0Ibft9qFR4dSeW/OXZEynLNHhNpvnjsQ/c/kXZLeQrHyzMtI4qg4 WsmuP7lGxNd6Adva6ORSLrMD1 X-Received: by 2002:a05:6000:1202:: with SMTP id e2mr2590865wrx.231.1590507919725; Tue, 26 May 2020 08:45:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5If1uNgTKWEisUAJowYTPwcuzMOOow4nahat1ESbDjPkHGjhZwTTbQrIPi02UQ5LtAAq4hw== X-Received: by 2002:a05:6000:1202:: with SMTP id e2mr2590848wrx.231.1590507919516; Tue, 26 May 2020 08:45:19 -0700 (PDT) Received: from localhost.localdomain ([194.230.155.118]) by smtp.gmail.com with ESMTPSA id u10sm32544wmc.31.2020.05.26.08.45.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2020 08:45:18 -0700 (PDT) Subject: Re: [PATCH v3 7/7] [not for merge] netstats: example use of stats_fs API To: Andrew Lunn Cc: kvm@vger.kernel.org, Christian Borntraeger , Paolo Bonzini , Jim Mattson , Alexander Viro , Emanuele Giuseppe Esposito , David Rientjes , Jonathan Adams , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org References: <20200526110318.69006-1-eesposit@redhat.com> <20200526110318.69006-8-eesposit@redhat.com> <20200526141605.GJ768009@lunn.ch> From: Emanuele Giuseppe Esposito Message-ID: <99217496-929f-ed3b-8e9e-bbd26d06e234@redhat.com> Date: Tue, 26 May 2020 17:45:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200526141605.GJ768009@lunn.ch> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew > How do you atomically get and display a group of statistics? > > If you look at how the netlink socket works, you will see code like: > > do { > start = u64_stats_fetch_begin_irq(&cpu_stats->syncp); > rx_packets = cpu_stats->rx_packets; > rx_bytes = cpu_stats->rx_bytes; > .... > } while (u64_stats_fetch_retry_irq(&cpu_stats->syncp, start)); > > It will ensure that rx_packets and rx_bytes are consistent with each > other. If the value of the sequence counter changes while inside the > loop, the loop so repeated until it does not change. > > In general, hardware counters in NICs are the same. You tell it to > take a snapshot of the statistics counters, and then read them all > back, to give a consistent view across all the statistics. > > I've not looked at this new code in detail, but it looks like you have > one file per statistic, and assume each statistic is independent of > every other statistic. This independence can limit how you use the > values, particularly when debugging. The netlink interface we use does > not have this limitation. You're right, statistics are treated independently so what you describe is currently not supported. In KVM the utilization is more qualitative, so there isn't such problem. But as long as the interface is based on file access, the possibility of snapshotting might not be useful; however, it could still be considered to be added later together with the binary access. Jonathan, how is your metricfs handling this case? Thank you, Emanuele