mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Bruce Allan <bruce.w.allan@intel.com>,
	PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com>,
	John Ronciak <john.ronciak@intel.com>,
	e1000-devel@lists.sourceforge.net,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] e1000: Fix tests of unsigned in e1000_tx_map()
Date: Tue, 22 Dec 2009 15:50:49 -0800	[thread overview]
Message-ID: <9929d2390912221550w1a75c948nf83cbeb490dd11fb@mail.gmail.com> (raw)
In-Reply-To: <4B27DD2E.1020409@gmail.com>

On Tue, Dec 15, 2009 at 11:02, Roel Kluin <roel.kluin@gmail.com> wrote:
> The variables count and i are unsigned so the (<|>=) 0 tests do not work.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Found using coccinelle: http://coccinelle.lip6.fr/
>
> This should be all with this pattern.
> As before I wasn't able to test this patch, so please review.
>
>  drivers/net/e1000/e1000_main.c |   10 +++++-----
>  drivers/net/e1000e/netdev.c    |   10 +++++-----
>  drivers/net/igb/igb_main.c     |   10 +++++-----
>  drivers/net/igbvf/netdev.c     |   10 +++++-----
>  drivers/net/ixgb/ixgb_main.c   |   10 +++++-----
>  drivers/net/ixgbe/ixgbe_main.c |   10 +++++-----
>  6 files changed, 30 insertions(+), 30 deletions(-)
>

Thanks Roel, I will add this patch to my queue.  Sorry for the delayed
response, for some odd reason your email got filtered.

-- 
Cheers,
Jeff

      reply	other threads:[~2009-12-22 23:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-15 18:18 Roel Kluin
2009-12-15 18:47 ` roel kluin
2009-12-15 19:02   ` Roel Kluin
2009-12-22 23:50     ` Jeff Kirsher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9929d2390912221550w1a75c948nf83cbeb490dd11fb@mail.gmail.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=bruce.w.allan@intel.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=jesse.brandeburg@intel.com \
    --cc=john.ronciak@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    --cc=roel.kluin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®