From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755600AbdEHR3g (ORCPT ); Mon, 8 May 2017 13:29:36 -0400 Received: from mout.web.de ([212.227.17.12]:60901 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754844AbdEHR3e (ORCPT ); Mon, 8 May 2017 13:29:34 -0400 To: netdev@vger.kernel.org, "David S. Miller" , Philippe Reynes , Stefan Wahren Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] qca_debug: Reduce function calls for sequence output in qcaspi_info_show() Message-ID: <9932ee63-f766-49ce-d760-9a0bd06f0657@users.sourceforge.net> Date: Mon, 8 May 2017 19:29:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:gxuYGXzDMRzzlow7jHmzFXRZO9hd3urUbBZL2f/I7Nvlvr7bYpy +FA1PManumtbsQp1bsBVI7a2KIVG9JA5ld4IhfJTrGwBcT6qxLykS5xnwYpQb4X92xOtUe0 YtlRe1Waxd1B5/eXwuLVIshE9Ho5YNyo8jJq8zB3bkLRZ6AwciGHnBtUXcZxE6zReGl2BEh wOYnmryCmai+ElOSrCtbg== X-UI-Out-Filterresults: notjunk:1;V01:K0:8SLSJltgQLo=:YITgRreH62DWWF0fQjmGof cHDEKVhHmqEh8dPWsV6mpMReyNdwQsdWgsh5M9XmAsuSMQOr8Xge3x4Qwb6+9weBo4xt9KjRe bwP8yGvwO3o3lCKMSGiFDD4a51TmiM1NR/lji5jlnHWqMwxgXsw82/tku1QJQV++SxMkClac7 L3AKxgre5DUMSK8LdMs64NRKQSoRvu5zoTFLgcUY1QpWYodf1aJsp/czQ1vd/R+V1unK0Wf7q HS9QsJVyTpdJ8t0HzdYugSGai9uHkqOvJExFrZ2oxzIzFbhyOtInGWS8wKqeV6uopPdEo0YDb pC1/W3k59MoROdQ0kuhUosdkzVcSuQIIYqH0hJjI/huuZSYq3pUmc2LqVQY37K9Czqw7qRuM6 P8kUIY8/neDa4CSmnIKlykEdPXX02OFYfwVgh8zt5979B0h/b164KgFZOwEwKaJA/Vj8d4Xa9 1AIQKHZ/0xcaUD5vdUAsEbV6u+DutUoBuy/0a4BcsPNPkKBKd1OQ2iBHEKa2UbOt8UGhdvBbN h6RRiuhmiqgmwAv1LtOypSehUmM35/VjNeRBFdM4TYQ8BDdEZZrIs+9XXwLgej1UokZ71P5Yh XUMsB4M55lm6lGKPM67sAj73S3J4JbSjlIwQmw//hkygmiCOF5JVz33vinjlS9y/o2zxclErN V1+RI0VHJG6fxbNzFpt+ah4Q/KZg1ft9s35TZQekghnTwMLHx9H1cTjkV23gzK7Jyaoh2H92e 890HFdzHwNcgDvbcwh7+rp/+3omBGQJvByYWGEc0ZM1TiDsfjwFNhoc9fvk3afF82ySH22L1L 1/lZfXC Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 8 May 2017 19:21:27 +0200 A bit of data was put into a sequence by separate function calls. Print the same data together with adjusted seq_printf() calls instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/qualcomm/qca_debug.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_debug.c b/drivers/net/ethernet/qualcomm/qca_debug.c index d145df98feff..27b5c1dd27d0 100644 --- a/drivers/net/ethernet/qualcomm/qca_debug.c +++ b/drivers/net/ethernet/qualcomm/qca_debug.c @@ -81,11 +81,7 @@ qcaspi_info_show(struct seq_file *s, void *what) else seq_puts(s, "in use"); - seq_puts(s, "\n"); - - seq_printf(s, "TX ring size : %u\n", - qca->txr.size); - + seq_printf(s, "\nTX ring size : %u\n", qca->txr.size); seq_printf(s, "Sync state : %u (", (unsigned int)qca->sync); switch (qca->sync) { @@ -102,10 +98,8 @@ qcaspi_info_show(struct seq_file *s, void *what) seq_puts(s, "INVALID"); break; } - seq_puts(s, ")\n"); - seq_printf(s, "IRQ : %d\n", - qca->spi_dev->irq); + seq_printf(s, ")\nIRQ : %d\n", qca->spi_dev->irq); seq_printf(s, "INTR REQ : %u\n", qca->intr_req); seq_printf(s, "INTR SVC : %u\n", -- 2.12.2