From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 864C723BF9F for ; Tue, 17 Feb 2026 10:15:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771323331; cv=none; b=QJanJM7ABvjSOiootq+pVAyRo9/PxfPRCv3/HILLy0JbCXE6dEx99kS0Dny5Q8XiveTmBO7pSSUOJqqqN3WapYYkkCNK4TGDzIZv5JpHdAJ01fuMcCftXktb/hXCJXUmlzs7jiXW0IEHxqCspE4Av7ph/7JIDN5jMymZzP4Z4Ww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771323331; c=relaxed/simple; bh=u3TkWkPH6LWvLanuhDAXSqqIBVBVtYI33nSwq/2/5kE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OyoHj1wdgHzuZJLZxWI7eD4l7e7deb5Tkp1Pp+lQcGv2gfvHu4WrGFkL/7DTvyi26Bu4z1Ab938KL3pRFgNrgIO4tArz9yXsMCd0NANMZxw4foTI3dDgBPkgULtk89Ww6SFz2ge4RdFYZm1QquQ0JG4PMepNrImS73T+Q3O2DHQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hnl/YYMG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BmzPSONd; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hnl/YYMG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BmzPSONd" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61H54egw2111894 for ; Tue, 17 Feb 2026 10:15:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 35pdAs0GELaEmLYh71wOirxIOtz+aG7dtGNqdZFfqPU=; b=hnl/YYMGkiFn6J1a EYZ0H1sGJzSmh4QUVQp3QiXc2muztkQPL4sf+KpxPZz/Ris0rcl0+oVD8nLP1Kg+ hD5GTm0jlvFw/6vf53V559Xv56U7KNhVctW3bh7z/JbR0ilN/FEok2xafA1ZROZq wI0xlFa7SbRURTAh6tXkc7FEJFhkM4uz1BxDn/0IGgYbwBxfs5TMbrGVV6mpSZM5 6NrDouJ8kzHwvhzL5ffAFKpVpBeKGvgqfCfGCWGQtNSokSnGS6HMnTkgOWrvIICK 8Kw4otNVKsziifreMglJ16PZ6bYnLW3Hy46Qm23bZcITiPuMEYgZ5F1FFI4I05IK tWjYxw== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cchv4gnd7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Feb 2026 10:15:29 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-89547ddf32bso30614616d6.2 for ; Tue, 17 Feb 2026 02:15:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771323329; x=1771928129; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=35pdAs0GELaEmLYh71wOirxIOtz+aG7dtGNqdZFfqPU=; b=BmzPSONdlKC0ZWYaE6AboA44A0g0w9x1eUQ6nZenNoDy8nsNvWpXUTtrBgfquvKM4E YRZHCfvL88bBQvSJbkTn8+RajNGlw6pIBDVJf+NlqKYTfhjvnuWBnkNQhwtssqZlmkY2 wHQyjp5nwSf97Xza+HDjZ6Xr5K8g19ET8sYsuhCicJhtvmuEMiIln+VXSJfRLLkwdmwr 4U44ulmdHYIpSbCV3uHVkaFXET8p97fK3WQ+KoLjh30jPmOJlL2W/O0hC2Fbd2DpASgr /DywfnMAm9xvE/mr6KA7c39g3boGYXutxNKZi+mOteBjLovYnVu77XM+xB4m3kqp2BaL aZzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771323329; x=1771928129; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=35pdAs0GELaEmLYh71wOirxIOtz+aG7dtGNqdZFfqPU=; b=mfyJc/xEHcKi7c7B3rMe9nSROQeCEcqZxvzEEQmpLzWxTkaFbpc5CB0sT8w2Ednifn UFdHTY1PLUXUMsIhfq5Yij48SX32G8ASdT7smr77FD1OfFnx62CWVZFGoRdsCyjMCsIQ FdBaBMNywMnqnb5P0SzBlKpTv/+7295uNDm1ay3JTGeXpkYavjIlCvwO+ZrBJlavorRH 0IL4FVXKt3yVPjy3OQw255xxUofnjZPhnFxqWRgt5xnadVRM50gEmKxg3zQfa35phqz8 BVMGT56dfrrpDQ/HmTmUyulxNZOBffjAkkDK4Ak22vQ9z1ZzL42Ybf9GpWuKCB1kiLso Mg3w== X-Forwarded-Encrypted: i=1; AJvYcCXfXohCDCqdPb0lXK9+Q/bio0VrPW/b3j1Pz7r2t0t4f6HKT5ESZP6F87duIEaoExVGpfX7UI61HZIdssE=@vger.kernel.org X-Gm-Message-State: AOJu0YyJ+GOeAqFGgr4A17Vtnnv8Wzm1xC4xRieZUpsq+FKoPxLf/GIl Fz4ugKN9F2rpRpjOBQSBhqeZBSjG5khmn5N6Vd8XFdr09mJkkPAys9gW3F+/13+90y9QmjdgPMP S+/moVa1C37E335/Vis9t9UCnuxTc0y/8s5ahn8/sRxGe73JX0dLhjLG/MAbT1xzUzxo= X-Gm-Gg: AZuq6aIZjJMCaIBQmWuxk4NpP9MeyG890k5B6SAOYm77pw8xzG08bNX5UKm4mFNiIXu BNIoRUDh9wk+CO62nomkwTHFJDVk6Xpi2aqK226sYat7ifoMPkdfXQBbTHIJhXTmZfv1uDlVvKi AQx+xETm0qi3ZG/hahTE0W1F2Q88v46GlybGVPIwaule2DoS73CNQ2ywWOnDlWHz+B7i5OWrKby 08j8vYfF2pmeHtHoIfGScrHQi1bj5yVGM+Yk3BPw96TEroHRZCcSY1JAohos7X6Bu8JK/yZAgLW OzHMD5MBkGVBREvP+0uuBWNa+nUQHzFvjdY2OKl7wh606MgaV2gEaY/Y1ZBmCbpSLQ4HunQaPu/ 0jWpUXFZIuVwzigpA+WaVxpWhL1WeQc/3gSsAjfQ67lHOEuzK70ck0hCjlbMce9axiG18QRuKft fKWJ0= X-Received: by 2002:a05:6214:8095:b0:896:f9ed:bea1 with SMTP id 6a1803df08f44-8994ac78794mr12228646d6.7.1771323328777; Tue, 17 Feb 2026 02:15:28 -0800 (PST) X-Received: by 2002:a05:6214:8095:b0:896:f9ed:bea1 with SMTP id 6a1803df08f44-8994ac78794mr12228466d6.7.1771323328379; Tue, 17 Feb 2026 02:15:28 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8fc7665563sm337195666b.47.2026.02.17.02.15.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Feb 2026 02:15:27 -0800 (PST) Message-ID: <9933eb31-b77a-4ae8-b52f-c30999e99232@oss.qualcomm.com> Date: Tue, 17 Feb 2026 11:15:25 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/6] clk: qcom: Add support for Global clock controller on Eliza To: Abel Vesa Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Luca Weiss , Taniya Das , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov References: <20260216-eliza-clocks-v3-0-8afc5a7e3a98@oss.qualcomm.com> <20260216-eliza-clocks-v3-5-8afc5a7e3a98@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=eYAwvrEH c=1 sm=1 tr=0 ts=69943fc1 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=kkBeuq3EVEdDXXmyUhYA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE3MDA4NCBTYWx0ZWRfX6gHrKOmwCgOP HPfcxjHT7vH+0LPFtk8wwWsAHMX5Zvnl306Hq0u7AoRh+uT+G/kXBeMfdm+PufNytaBnE/mD1wG 3RGBaZOmMh5tmhJGVPXMVGzMawZ6Tr9sbaeh8z7sUaoyGezqjn2J4WlBfnjdaItlxwrqFWkIl9p iHQioThbLjWSuaIVbvOdTJX4xtK2fxu3vzbUSJQo8ng1Gb6Km/ZxH6flxTBtT+N2EHQtzIds+Fs Nxn0XB72kwTwXYu+UZD3JOaOxxjQVEPinSrF0Cvhdx9uPeaEntxal6QxrNzpWO5TEwDymjcMGf9 r90R3vrond6YY5TpX79go6+/EFmhtXuNpGN6Zaj05iJk+OfL1HKJQPdFQ+LfCGl8RKoWs33WaJC s3MRIkPqppMWceD9W0iaGtlYbywqwNVkR2n4DpbSWAcuNtVGIyXeF79O2R9kPxAbAETwR3HNM86 KPSGOULLrhNQJCUEduw== X-Proofpoint-GUID: 3VBt1beGv-PpLvG5KWEtDHLLf4CwUspB X-Proofpoint-ORIG-GUID: 3VBt1beGv-PpLvG5KWEtDHLLf4CwUspB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-17_01,2026-02-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602170084 On 2/17/26 8:58 AM, Abel Vesa wrote: > On 26-02-16 16:38:15, Konrad Dybcio wrote: >> On 2/16/26 2:43 PM, Abel Vesa wrote: >>> From: Taniya Das >>> >>> Add support for Global clock controller for Eliza Qualcomm SoC. >>> >>> Signed-off-by: Taniya Das >>> Reviewed-by: Dmitry Baryshkov >>> Signed-off-by: Abel Vesa >>> --- >> >> [...] >> >> >>> +static struct clk_regmap_mux gcc_pcie_0_pipe_clk_src = { >> >> This and a number of others should be struct clk_regmap_phy_mux instead, >> cross-check with kaanapali and remember to drop the then-unused parentmaps > > Oups, missed this in v4. Will fix in v5. > >> >> [...] >> >>> + [GCC_CAMERA_HF_CLK_EN_SLP_STG] = { 0x26018, 1 }, >>> + [GCC_CAMERA_SF_CLK_EN_SLP_STG] = { 0x26028, 1 }, >>> + [GCC_CAMERA_HF_CLK_EN_SEL_SLP_STG] = { 0x26018, 2 }, >>> + [GCC_CAMERA_SF_CLK_EN_SEL_SLP_STG] = { 0x26028, 2 }, >> >> So SEL_SLP_STG=0x1 allows setting SLP_STG to =0x1 to assert the ARES, >> otherwise if SEL_SLP_STG=0x0, it's controlled by the HW state machine >> >> I don't think modelling the prior one as a reset is valid, but I don't >> know what considerations we need to take wrt dis/allowing hw control >> here and what the consumer expectations are. >> >> Taniya, would you know? I see you've already sent a v5, but I'd like to see the above resolved.. Adding more context, bits 1 and 2 control the gating of the SLP_STG *clock*, whereas bits 4 and 5 control the reset.. I think if we don't have an immediate need for these, we may temporarily drop them as we try and figure out a way forward to avoid adding fake ABI Konrad