From: David Hildenbrand <david@redhat.com>
To: Paul Mackerras <paulus@ozlabs.org>, Nixiaoming <nixiaoming@huawei.com>
Cc: "agraf@suse.com" <agraf@suse.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce
Date: Wed, 23 Aug 2017 11:16:24 +0200 [thread overview]
Message-ID: <99351d36-2fc6-d5b5-1ce2-bdd9bcbd68f4@redhat.com> (raw)
In-Reply-To: <aa600c47-d6d5-161d-419d-51ac30d67ee4@redhat.com>
>>> + mutex_unlock(&kvm->lock);
>>> + kvm_put_kvm(kvm);
>>> + goto fail;
>>> + }
>>> + return ret;
>
> of simply
>
> if (!ret)
if (ret >= 0)
return ret;
is of course what I meant :)
> return 0;
>
> mutex_lock(&kvm->lock);
> list_del_rcu(&stt->list);
> mutex_unlock(&kvm->lock);
> kvm_put_kvm(kvm);
--
Thanks,
David
next prev parent reply other threads:[~2017-08-23 9:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 14:28 nixiaoming
2017-08-22 15:15 ` David Hildenbrand
2017-08-22 15:23 ` David Hildenbrand
2017-08-23 1:43 ` Nixiaoming
2017-08-23 6:06 ` Paul Mackerras
2017-08-23 8:25 ` David Hildenbrand
2017-08-23 9:16 ` David Hildenbrand [this message]
2017-08-23 10:17 ` 答复: " Nixiaoming
2017-08-24 1:06 ` Nixiaoming
2017-08-27 21:02 ` Al Viro
2017-08-28 4:38 ` Paul Mackerras
2017-08-28 5:28 ` Al Viro
2017-08-28 6:06 ` Paul Mackerras
2017-08-28 11:31 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99351d36-2fc6-d5b5-1ce2-bdd9bcbd68f4@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.com \
--cc=benh@kernel.crashing.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nixiaoming@huawei.com \
--cc=paulus@ozlabs.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®