From: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
To: Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Tejun Heo <tj@kernel.org>
Subject: [PATCH v2 3/8] power: pm2301_charger: Remove deprecated create_singlethread_workqueue
Date: Tue, 16 Aug 2016 10:52:41 +0530 [thread overview]
Message-ID: <9939d53fbaf385bd603f48bbbdd2bb3c02ca2c87.1471324750.git.bhaktipriya96@gmail.com> (raw)
In-Reply-To: <cover.1471324749.git.bhaktipriya96@gmail.com>
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.
The workqueue "charger_wq" is used for running all the charger related
tasks. This involves charger detection, checking for HW failure and HW
status. This workqueue has been identity converted.
It queues multiple workitems viz &pm2->check_main_thermal_prot_work,
&pm2->check_hw_failure_work, &pm2->ac_work. Hence, the deprecated
create_singlethread_workqueue() instance has been replaced with a
dedicated ordered workqueue.
The WQ_MEM_RECLAIM flag has been set to ensure forward progress under
memory pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/power/pm2301_charger.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/power/pm2301_charger.c b/drivers/power/pm2301_charger.c
index fb62ed3..78561b6 100644
--- a/drivers/power/pm2301_charger.c
+++ b/drivers/power/pm2301_charger.c
@@ -1054,7 +1054,8 @@ static int pm2xxx_wall_charger_probe(struct i2c_client *i2c_client,
pm2->ac_chg.external = true;
/* Create a work queue for the charger */
- pm2->charger_wq = create_singlethread_workqueue("pm2xxx_charger_wq");
+ pm2->charger_wq = alloc_ordered_workqueue("pm2xxx_charger_wq",
+ WQ_MEM_RECLAIM);
if (pm2->charger_wq == NULL) {
ret = -ENOMEM;
dev_err(pm2->dev, "failed to create work queue\n");
--
2.1.4
next prev parent reply other threads:[~2016-08-16 5:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 5:21 [PATCH v2 0/8] power: " Bhaktipriya Shridhar
2016-08-16 5:22 ` [PATCH v2 1/8] power: abx500_chargalg: " Bhaktipriya Shridhar
2016-08-16 5:22 ` [PATCH v2 2/8] power: ab8500_btemp: " Bhaktipriya Shridhar
2016-08-16 5:22 ` Bhaktipriya Shridhar [this message]
2016-08-16 5:22 ` [PATCH v2 4/8] power: intel_mid_battery: " Bhaktipriya Shridhar
2016-08-16 5:23 ` [PATCH v2 5/8] power: ab8500_charger: " Bhaktipriya Shridhar
2016-08-16 5:23 ` [PATCH v2 6/8] power: ipaq_micro_battery: " Bhaktipriya Shridhar
2016-08-16 5:23 ` [PATCH v2 7/8] power: ab8500_fg: " Bhaktipriya Shridhar
2016-08-16 5:24 ` [PATCH v2 8/8] power: ds2760_battery: " Bhaktipriya Shridhar
2016-08-16 10:30 ` [PATCH v2 0/8] power: " Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9939d53fbaf385bd603f48bbbdd2bb3c02ca2c87.1471324750.git.bhaktipriya96@gmail.com \
--to=bhaktipriya96@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®