From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4593F189902 for ; Tue, 18 Mar 2025 14:33:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742308412; cv=none; b=CZno22nEhA0MatTbYWWG/HkgUJhMOh74Gsb2k2inibVlFQyHjbTgtpBTCS1Ag/1cSCtl+vpnWvo6Dm15NGo/ZDiR3J0pBGthCkU6m9c3+pknw3XqDrtAGbL9jxgeSNtmcVm1wSJjZ5290ZCaID8F6EmF82In1MjQc3B70pdyDTU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742308412; c=relaxed/simple; bh=eas+vQ1ReggmI3VLIUXfF3opvpqo6XgOUi6ufjd5atQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oSq5D2xNd7sJGWqLneyhWnBR6+6RO9Gis9nO3QgHq6nNtUf+gjognywLpT5HAol+ZpDdXa4DgnQLlH1ntk1zfHFJ6eWg2COvV97ssG1hb/BcFLVZj//YdR8vorFGE8wBgHYiupRMYhehpVPcf8JWWzJpaToSkOwYGEXCFOl51sw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Wv0v35Ub; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Wv0v35Ub" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52IBjp9L002749 for ; Tue, 18 Mar 2025 14:33:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1gSHyxlizzu6L+Z9HZ3/usswbAq6JRVp+YGuaZi/mPc=; b=Wv0v35UbW/m6fi/1 pyNrOYQ3+YBprgYemg0KkFBPGYCo0+N+uwrypKcQO3S4F2Y5Ef+xvwx6eBxrSPnj kcb55JOjnff6xIwQdXMWiyCj8HPY3THX62nhKbJ8YbJIOOrrIjEJgU4uyGhpmznj cBnPE2aqaD+zehBaFEXbBv3sBKsqdM/fgZT0TarPXhtGVOO2XIB96bzU1ePpNWtU ogWfLqa1muOcAAGbu16j7i2XX/51iz8XagTpGG3vvdSY9CwEAiuNwfJXljovzMuz t59qW+e7W1OGA9jVukhX76SmNtLneZdBk7i1eDeGh+W0e6ay+02Xj4YJ5/v+ge9T gukyog== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45f010j0uu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 18 Mar 2025 14:33:26 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4766ce9a08cso12280601cf.0 for ; Tue, 18 Mar 2025 07:33:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742308405; x=1742913205; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1gSHyxlizzu6L+Z9HZ3/usswbAq6JRVp+YGuaZi/mPc=; b=df5/L/Jd/3/MekPmeYcW6Goui/6fMkQqaQs8602Yh26A1EaeS11TLDs2S5ef7KAQlt moBNxOh94Pzpmj9s2UsaDKU6ENNszcvG0mQ3wXsMbBwkfSoL6Lfefn0581LPETPazP1s EPsliCMIvt8uuLZI7FFg42NdEWtBdzaPnXPxUTxMLqnLOyDClbpkhTqrFsNKi3VTLyn5 I2jEwxiSq9RRIkIUoj34R2IvdQ4AdEcaO3JQbG4IyWuBmREPjQUB+UwxQ3DIXQ06a/o7 0Cwgw5oscgvljIUZ6ZAI+CajZ2BkBguZC93cgJLofdvCZeKclAyznVk3Xkjg89+mFwhF ugpg== X-Forwarded-Encrypted: i=1; AJvYcCWJRqPHNVTs5D0yQy0JzLOvVZ3J4hZo8xRnGhEsdAuBS+LHZ9Hdos9XkwXqNMQslJH+N/GfKYMBnKTB9H4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/zNS3yI11/zSuLCzyVWan5rznB12nD0TbP2+WIS/00DahAKCm gmbovrRL4uLNkHmw2lWIuQLq9j0Nmeqw5THUzn2niZ/xHdZUAlGEsPZUEfJCI+vDr2hd7nn0K2I 6O9BQstWp8p0ViS6Z/EGUQD6+vHq7tiWK6Smlk9tZP0kV+w7/kVpjAhohIW2M60Y= X-Gm-Gg: ASbGncscxFWgtByshMH3qcgRXg9Ogj38XlXcUMTNGAvBfBxipHYi+0ROAF7lV7uUoJI kTkanIZ2V13allkN5atXORl0ElbAVNtjGyiStjl0XG+PLA+Wh9nX1cTae+xHQq2A9ya7HOevMVV PVn2sgq+6b9MR/EmVAMN6VfFFdqfZdmUK0rh5g7VH7S9hfepEIJSW99pBNAzqyrFUsO+QWGzZ9w SQA7fNIUJpIDiCHt1/WN+Q3qYKtXbCm5aqsOpIvw3+l5D3RWO9XfE0HEDm3w0wrkcV6b2QwDb+w EGVePG/3X68kHw7FkbAqUmIaUI3vFn9+GefQCxPXVrqZ4iOhJDNNXr325qReZaMhnFBUWg== X-Received: by 2002:a05:622a:180e:b0:472:2122:5a37 with SMTP id d75a77b69052e-476c81410fcmr97651611cf.4.1742308404961; Tue, 18 Mar 2025 07:33:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGijmIEbCtzUiyK4kMVgUNiQ4VrmlRjM2YTS3V022dmP4rU4NWQYFESVJkXCh24tWs7ZzGqWQ== X-Received: by 2002:a05:622a:180e:b0:472:2122:5a37 with SMTP id d75a77b69052e-476c81410fcmr97651381cf.4.1742308404588; Tue, 18 Mar 2025 07:33:24 -0700 (PDT) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac314a40f61sm853965466b.134.2025.03.18.07.33.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Mar 2025 07:33:24 -0700 (PDT) Message-ID: <9940290b-6b97-4339-848d-ea95a365f74c@oss.qualcomm.com> Date: Tue, 18 Mar 2025 15:33:21 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] arm64: dts: qcom: sa8775p: add support for video node To: Vikash Garodia , Konrad Dybcio , Dikshita Agarwal , Abhinav Kumar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250311-dtbinding-v1-0-5c807d33f7ae@quicinc.com> <20250311-dtbinding-v1-3-5c807d33f7ae@quicinc.com> <3ec71075-b1ef-4366-b595-80fe41cd1e13@oss.qualcomm.com> <8f7c1c08-6776-968c-530e-b640ded940b3@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <8f7c1c08-6776-968c-530e-b640ded940b3@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: RgFB42K669tQ-vX5cnG-DguvadHKQciz X-Proofpoint-GUID: RgFB42K669tQ-vX5cnG-DguvadHKQciz X-Authority-Analysis: v=2.4 cv=G50cE8k5 c=1 sm=1 tr=0 ts=67d98436 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=COk6AnOGAAAA:8 a=TSMI0u4FDo7tO7E2M5oA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-18_07,2025-03-17_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 lowpriorityscore=0 mlxlogscore=999 phishscore=0 adultscore=0 impostorscore=0 spamscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503180107 On 3/18/25 3:24 PM, Vikash Garodia wrote: > > On 3/15/2025 7:13 PM, Konrad Dybcio wrote: >> On 3/11/25 1:03 PM, Vikash Garodia wrote: >>> Video node enables video on Qualcomm SA8775P platform. >>> >>> Signed-off-by: Vikash Garodia >>> --- >>> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 67 +++++++++++++++++++++++++++++++++++ >>> 1 file changed, 67 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >>> index 3394ae2d13003417a15e64c9e47833725ec779e6..09db8e2eb578f1cada0f4a15e3f844dc097bd46d 100644 >>> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >>> @@ -10,6 +10,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include >>> #include >>> #include >>> @@ -3783,6 +3784,72 @@ llcc: system-cache-controller@9200000 { >>> interrupts = ; >>> }; >>> >>> + iris: video-codec@aa00000 { >>> + compatible = "qcom,sa8775p-iris"; >>> + >>> + reg = <0 0x0aa00000 0 0xf0000>; >>> + interrupts = ; >>> + >>> + power-domains = <&videocc VIDEO_CC_MVS0C_GDSC>, >>> + <&videocc VIDEO_CC_MVS0_GDSC>, >>> + <&rpmhpd SA8775P_MXC>, >>> + <&rpmhpd SA8775P_MMCX>; >>> + power-domain-names = "venus", >>> + "vcodec0", >>> + "mx", >>> + "mmcx"; >>> + operating-points-v2 = <&iris_opp_table>; >>> + >>> + clocks = <&gcc GCC_VIDEO_AXI0_CLK>, >>> + <&videocc VIDEO_CC_MVS0C_CLK>, >>> + <&videocc VIDEO_CC_MVS0_CLK>; >>> + clock-names = "iface", >>> + "core", >>> + "vcodec0_core"; >>> + >>> + interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS >>> + &config_noc SLAVE_VENUS_CFG QCOM_ICC_TAG_ALWAYS>, >> >> This path should use QCOM_ICC_TAG_ACTIVE_ONLY on both endpoints > What is the advantage of "ALWAYS" vs "ACTIVE_ONLY". Thinking of a possibility of > APSS power collapsed, while video hardware is processing a frame ? That's totally okay, I'm requesting ACTIVE_ONLY just on the cpu-cfg path, which must not be used if APSS if offline anyway Konrad