mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Finn Thain <fthain@linux-m68k.org>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Lance Yang <lance.yang@linux.dev>,
	akpm@linux-foundation.org,  amaindex@outlook.com,
	anna.schumaker@oracle.com, boqun.feng@gmail.com,
	 geert@linux-m68k.org, ioworker0@gmail.com,
	joel.granados@kernel.org,  jstultz@google.com,
	leonylgao@tencent.com, linux-kernel@vger.kernel.org,
	 linux-m68k@lists.linux-m68k.org, longman@redhat.com,
	mhiramat@kernel.org,  mingo@redhat.com, mingzhe.yang@ly.com,
	oak@helsinkinet.fi,  peterz@infradead.org, rostedt@goodmis.org,
	senozhatsky@chromium.org,  tfiga@chromium.org, will@kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v2 1/1] hung_task: fix warnings caused by unaligned lock pointers
Date: Wed, 10 Sep 2025 10:07:04 +1000 (AEST)	[thread overview]
Message-ID: <99410857-0e72-23e4-c60f-dea96427b85a@linux-m68k.org> (raw)
In-Reply-To: <yqjkjxg25gh4bdtftsdngj5suturft2b4hjbfxwe6hehbg4ctq@6i55py3jaiov>


On Tue, 9 Sep 2025, Kent Overstreet wrote:

> On Tue, Sep 09, 2025 at 10:52:43PM +0800, Lance Yang wrote:
> > From: Lance Yang <lance.yang@linux.dev>
> > 
> > The blocker tracking mechanism assumes that lock pointers are at least
> > 4-byte aligned to use their lower bits for type encoding.
> > 
> > However, as reported by Eero Tamminen, some architectures like m68k
> > only guarantee 2-byte alignment of 32-bit values. This breaks the
> > assumption and causes two related WARN_ON_ONCE checks to trigger.
> 
> Isn't m68k the only architecture that's weird like this?
> 

No. Historically, Linux/CRIS did not naturally align integer types either. 
AFAIK, there's no standard that demands natural alignment of integer 
types. Linux ABIs differ significantly.

For example, Linux/i386 does not naturally align long longs. Therefore, 
x86 may be expected to become the next m68k (or CRIS) unless such 
assumptions are avoided and alignment requirements are made explicit.

The real problem here is the algorithm. Some under-resourced distros 
choose to blame the ABI instead of the algorithm, because in doing so, 
they are freed from having to work to improve upstream code bases.

IMHO, good C doesn't make alignment assumptions, because that hinders 
source code portability and reuse, as well as algorithm extensibility. 
We've seen it before. The issue here [1] is no different from the pointer 
abuse which we fixed in Cpython [2].

Linux is probably the only non-trivial program that could be feasibly 
rebuilt with -malign-int without ill effect (i.e. without breaking 
userland) but that sort of workaround would not address the root cause 
(i.e. algorithms with bad assumptions).

[1]
https://lore.kernel.org/lkml/CAMuHMdW7Ab13DdGs2acMQcix5ObJK0O2dG_Fxzr8_g58Rc1_0g@mail.gmail.com/

[2]
https://github.com/python/cpython/pull/135016

  parent reply	other threads:[~2025-09-10  0:06 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09 14:52 Lance Yang
2025-09-09 16:46 ` Kent Overstreet
2025-09-09 16:55   ` John Paul Adrian Glaubitz
2025-09-09 19:02     ` Kent Overstreet
2025-09-10  0:45     ` Finn Thain
2025-09-10  7:34     ` Geert Uytterhoeven
2025-09-10  7:37       ` John Paul Adrian Glaubitz
2025-09-10  0:07   ` Finn Thain [this message]
2025-09-10  0:51     ` Kent Overstreet
2025-09-10  1:35       ` Finn Thain
2025-09-10  1:48         ` Kent Overstreet
2025-09-10  6:40           ` Finn Thain
2025-09-10  6:52     ` Andreas Schwab
2025-09-10  7:39       ` John Paul Adrian Glaubitz
2025-09-10  7:45         ` Geert Uytterhoeven
2025-09-10  8:02       ` Finn Thain
2025-09-10 11:26         ` Andreas Schwab
2025-09-10  7:36     ` Geert Uytterhoeven
2025-09-10 11:57       ` Kent Overstreet
2025-10-07 20:56         ` Andrew Morton
2025-10-08  0:40           ` Finn Thain
2025-10-08  3:03             ` Lance Yang
2025-10-08  6:14               ` Finn Thain
2025-10-08  7:09                 ` Lance Yang
2025-10-08  7:23                   ` Lance Yang
2025-10-08 10:12                     ` Finn Thain
2025-10-08 13:48                       ` Lance Yang
2025-10-08 21:55                         ` Finn Thain
2025-10-09  2:01                           ` Lance Yang
2025-10-09  4:04                             ` Andrew Morton
2025-10-09  7:11                               ` Geert Uytterhoeven
2025-10-14 10:11                                 ` David Laight
2025-10-08 12:56             ` Eero Tamminen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99410857-0e72-23e4-c60f-dea96427b85a@linux-m68k.org \
    --to=fthain@linux-m68k.org \
    --cc=akpm@linux-foundation.org \
    --cc=amaindex@outlook.com \
    --cc=anna.schumaker@oracle.com \
    --cc=boqun.feng@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=ioworker0@gmail.com \
    --cc=joel.granados@kernel.org \
    --cc=jstultz@google.com \
    --cc=kent.overstreet@linux.dev \
    --cc=lance.yang@linux.dev \
    --cc=leonylgao@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=longman@redhat.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mingzhe.yang@ly.com \
    --cc=oak@helsinkinet.fi \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=stable@vger.kernel.org \
    --cc=tfiga@chromium.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®