From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C685E163 for ; Tue, 3 Feb 2026 20:45:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770151526; cv=none; b=YiDvcAVaFRdIV4zWvqkjFOUXS2v/JfxCmFyC8+dTXbzKsDW+/sWVh25dqP3y5eJwm4z6zFrnsZ+SxCSSsBvUPcJUoKyQ++Rd06Y1lcW18sChJYGkoB3lASr3bVfWBQQNiE2FvPdcSxGJ0N/Vmb/F2W3l0q88nuXBdf2K8NGrHy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770151526; c=relaxed/simple; bh=JRBnZ+8tjOilMeZJMOzCmDnmZL1fwuQqpAz7EJltbms=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V65rhc0gUTIsBpYCBWm2VKIcXQuu9cZMF27UWoDcB0Q88ID0S+nJAyNNvJUrb6fspGni9BpFuCAGsvW7rCHo4tOyI2osRAz5+NNBf3MLz9VHCYVM69o+OC4/GWD7WA2y/qmynwB55WPiE7HsvAt70qh0Kk1V7x7chovG9oXFDeI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OMO8mzeq; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OMO8mzeq" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c227206e6dcso3691842a12.2 for ; Tue, 03 Feb 2026 12:45:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770151524; x=1770756324; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=SY6DYLnqRnlkJ6nNpwpLKHnvyItg1y7t+nOJ7MRScBQ=; b=OMO8mzeqrPH2Iho15bxaFba0CIj/FzxXX9jhgdFpPX30XknXQVNnN+qBoKiSXcuQNW 0JTQIgujgXWjoCm7PupI7ag6OsUWVj2O/6yiH4VBZv6AYKGMRM2wtxOmW66nkqTgRfI3 zVGlqknXFjFnOM0JBNDLGVOvRxdfvyqCm5L0/1O/DGg78N5oxuRrYAkgek4Tm13BtiHO 5TFXMv5kiw6Ufqk/AcTvMR7a9jPfROw5dfVvxSMAjDF8KJASvfNrt0iGHks/lBFDfvbX EGk0yfH7xwQY3NbmlgHqn58IB5kQtl0rFOKIz1YetLamT719nDZYjnK68K1bJv/4Ao2e LosQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770151524; x=1770756324; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=SY6DYLnqRnlkJ6nNpwpLKHnvyItg1y7t+nOJ7MRScBQ=; b=Z+Fv7tHdjO2YkzseOFfBVT/hHD4Ul3Bqpkx4qVQ5KifXps/cWFKaLb+FjIB9VZDtID gQFuY9r6v+wATKkPqh7BQ/8zv3DPPr2cv54L5oSi8Lu5/qRMnQ5xReLaFM/qkdPLWbfU CvDD+PFVkSZNJB4kYarUxrYv/za61XrInT+U7xQiwrhLhQdAtXRBWQbeZAEAs+6P4zgm h4BkWdWv4KpcTEtmvbodTs2XQlwfTd3PI90iBJ4CD9E1LSnuPwauNzOW/Wwc1vDVmgp1 axvXwdIUQEFSRL6PoNKL7+aqZB5JprSUQjvMkfKByoYrBUuPT/LJebkIQQp/u0cC1z5S 75yg== X-Forwarded-Encrypted: i=1; AJvYcCX6oIY+RChgX/4vzonnn4z3oXOqDp45kWcNHO4G1hC14SKpr2Kgq+OjN57lD6Pbz2MMEIiShTLQyeQmffY=@vger.kernel.org X-Gm-Message-State: AOJu0YxQu4dKDPn59Ty2wNaYDVN3Jr0Y38REi3IzwAuDlFLiTDmMJfL1 4K6Gtc0FPKO4da1vVHIVb6voXda/ynCgrhnv1JkHu4ezjliH7I7kfbSaRh0mUUDN X-Gm-Gg: AZuq6aKL7dHMvZDpyyDHeWBD42dLLxodw/fPzeDwsjVUNyrWQaiwz9pv7K7KwJ2C5FB zAAyu9vBTq77pNl9LDmIhPF10kHf/SGbtowG1C1U3aKtoBzEPxTGXkXVj3XNcfMG976jUnDD9ll 4TYDTU46wGV/VfRwDW6ZfTETzHdp417k5cOZ5gXMCDd8oBoRiAY6k3QWLsp1LssKYiOH9TvkFkW 5WBLtRhJGNKTen/9yhzMJ8gVYjT5ETSWaWrmFRp7m/VhXBhRQeznVd+oiOPPyLXGsTfNEG65v8Q UHaZgvww40fNRisujxzCRvQivi8IhNyey3ta5J6VmtfDW8nIs//bnOSTM3QEy2rtytkzrpcDrmq z+8aal91adRij8E5aS63suIxtr4ZL4sHyNrNxfUb8DhraBZYEbY8zwPgOaSCxjomROGIPS1VzvP F8LWv/8eCEOb+tIBJiEOBNSSSZamTx/5nS9n8= X-Received: by 2002:a05:6a21:718b:b0:393:7575:a8c7 with SMTP id adf61e73a8af0-3937575c9b3mr85990637.19.1770151524247; Tue, 03 Feb 2026 12:45:24 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6c8515f36esm175662a12.29.2026.02.03.12.45.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 12:45:23 -0800 (PST) Sender: Guenter Roeck Date: Tue, 3 Feb 2026 12:45:22 -0800 From: Guenter Roeck To: victor.duicu@microchip.com Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, corbet@lwn.net, marius.cristea@microchip.com, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v3 2/2] hwmon: add support for MCP998X Message-ID: <99479712-9847-4113-8092-b87f1298a6da@roeck-us.net> References: <20260127151823.9728-1-victor.duicu@microchip.com> <20260127151823.9728-3-victor.duicu@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260127151823.9728-3-victor.duicu@microchip.com> On Tue, Jan 27, 2026 at 05:18:22PM +0200, victor.duicu@microchip.com wrote: > From: Victor Duicu > > This is the driver for Microchip MCP998X/33 and MCP998XD/33D > Multichannel Automotive Temperature Monitor Family. > > Signed-off-by: Victor Duicu Gemini is having fun. Another good point. > +#define MCP9982_HIGH_LIMIT_DEFAULT 21000 AI: The default high limit of 21 degrees C is extremely low and likely to cause immediate alarms on many systems (e.g., room temperature is often > 21C, and inside a case it is almost certainly higher). Standard practice is to leave limits as configured by BIOS/firmware, or set them to the chip's maximum rating if unconfigured. Overwriting them unconditionally to 21C is a regression in expected behavior and usability. Me: I would not call this a regression, but Gemini does have a point. Why such a low high limit ? At the very least that warrants an explanation/comment. Thanks, Guenter