From: Komal Bajaj <quic_kbajaj@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <agross@kernel.org>,
<andersson@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <luca.weiss@fairphone.com>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: qcm6490: Add qcm6490 dts file
Date: Fri, 13 Oct 2023 11:11:00 +0530 [thread overview]
Message-ID: <994a6ff0-9b6c-0ac8-9a6c-694a2abd0f4d@quicinc.com> (raw)
In-Reply-To: <e846215b-faba-4af6-a108-bae9b1deb2be@linaro.org>
On 10/7/2023 5:03 AM, Konrad Dybcio wrote:
> On 3.10.2023 19:54, Komal Bajaj wrote:
>> Add qcm6490 devicetree file for QCM6490 SoC and QCM6490 IDP
>> platform. QCM6490 is derived from SC7280 meant for various
>> form factor including IoT.
>>
>> Supported features are, as of now:
>> * Debug UART
>> * eMMC
>> * USB
>>
>> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/Makefile | 1 +
>> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 333 +++++++++++++++++++++++
>> arch/arm64/boot/dts/qcom/qcm6490.dtsi | 94 +++++++
>> 3 files changed, 428 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> create mode 100644 arch/arm64/boot/dts/qcom/qcm6490.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>> index 73c3be0f8872..3a2d9dbaacce 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -82,6 +82,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-maple.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-poplar.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += msm8998-xiaomi-sagit.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += qcm6490-fairphone-fp5.dtb
>> +dtb-$(CONFIG_ARCH_QCOM) += qcm6490-idp.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb
>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> new file mode 100644
>> index 000000000000..d81a7810fd5a
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> @@ -0,0 +1,333 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
>> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>> +#include "pm7325.dtsi"
>> +#include "pm8350c.dtsi"
>> +#include "pmk8350.dtsi"
>> +#include "qcm6490.dtsi"
> As the kernel robot pointed out, this has clearly not even been
> compile-tested..
Sorry for this.. I made this change as per the comment that I got to
sort the
inclusion files in alphabetical order. Incremental build compilation
wasn't able
to catch this error.
I will move qcm6490.dtsi file inclusion before pm* files inclusion.
Thanks
Komal
>
> Konrad
prev parent reply other threads:[~2023-10-13 5:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 17:54 [PATCH v3 0/2] Initial support for the QCM6490 IDP Komal Bajaj
2023-10-03 17:54 ` [PATCH v3 1/2] dt-bindings: arm: qcom: Add QCM6490 IDP board Komal Bajaj
2023-10-03 17:54 ` [PATCH v3 2/2] arm64: dts: qcom: qcm6490: Add qcm6490 dts file Komal Bajaj
2023-10-04 6:53 ` Krzysztof Kozlowski
2023-10-06 14:48 ` kernel test robot
2023-10-06 23:32 ` Konrad Dybcio
2023-10-11 5:40 ` Mukesh Ojha
2023-10-11 9:47 ` Konrad Dybcio
2023-10-11 13:40 ` Mukesh Ojha
2023-10-11 22:55 ` Konrad Dybcio
2023-10-13 14:13 ` Mukesh Ojha
2023-10-11 17:35 ` Trilok Soni
2023-10-11 22:57 ` Konrad Dybcio
2023-10-06 23:33 ` Konrad Dybcio
2023-10-13 5:41 ` Komal Bajaj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=994a6ff0-9b6c-0ac8-9a6c-694a2abd0f4d@quicinc.com \
--to=quic_kbajaj@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®