From: "Arnd Bergmann" <arnd@arndb.de>
To: "Stanislaw Gruszka" <stf_xl@wp.pl>, "Arnd Bergmann" <arnd@kernel.org>
Cc: "Johannes Berg" <johannes@sipsolutions.net>,
"Kalle Valo" <kvalo@kernel.org>,
"Ben Hutchings" <ben@decadent.org.uk>, linux <linux@treblig.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] iwlegacy: don't warn for unused variables with DEBUG_FS=n
Date: Sat, 01 Mar 2025 13:38:16 +0100 [thread overview]
Message-ID: <994e4827-0e16-4e05-be7c-1ca7a86e4daf@app.fastmail.com> (raw)
In-Reply-To: <20250301122834.GA55739@wp.pl>
On Sat, Mar 1, 2025, at 13:28, Stanislaw Gruszka wrote:
> On Tue, Feb 25, 2025 at 03:53:53PM +0100, Arnd Bergmann wrote:
>
> But then the code will be compiled for !CONFIG_MAC80211_DEBUGFS
> case, it does compile for me:
>
> - 22475 1160 0 23635
> 5c53 drivers/net/wireless/intel/iwlegacy/4965-rs.o
> + 23008 1168 0 24176
> 5e70 drivers/net/wireless/intel/iwlegacy/4965-rs.o
Very strange, this really shouldn't happen. Which symbols
exactly do you see the compiler fail to drop with my patch,
and which compiler version are you using?
> How about moving
> static const struct il_rate_mcs_info il_rate_mcs[RATE_COUNT]
> under CONFIG_MAC80211_DEBUGFS ? Maybe inside the function that use it ?
It's not supposed to make a difference, let's try to figure
out if there is a compiler bug or a mistake in my patch first
and then fix it in the right place.
Arnd
next prev parent reply other threads:[~2025-03-01 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 14:53 Arnd Bergmann
2025-03-01 12:28 ` Stanislaw Gruszka
2025-03-01 12:38 ` Arnd Bergmann [this message]
2025-03-01 13:36 ` Stanislaw Gruszka
2025-03-01 13:49 ` Arnd Bergmann
2025-03-01 18:02 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=994e4827-0e16-4e05-be7c-1ca7a86e4daf@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=ben@decadent.org.uk \
--cc=gustavoars@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@treblig.org \
--cc=stf_xl@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®