From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9374EEB57B for ; Wed, 13 Sep 2023 03:27:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238227AbjIMD1z (ORCPT ); Tue, 12 Sep 2023 23:27:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234151AbjIMD1w (ORCPT ); Tue, 12 Sep 2023 23:27:52 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B45911719; Tue, 12 Sep 2023 20:27:48 -0700 (PDT) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38D2m5ZV020174; Wed, 13 Sep 2023 03:27:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=cUTWJon64x7MRrDRa/RUiDbLmlNR0nsD4wwiPTCsA6A=; b=ciWrAwPfBC6sNVVPE7QhhtyVB1hIryKggTiJEVnVCnewC/b14nYaMiaI3e7t4CPkGzrA BIjkfnzeznITodWTbjtPeHPhoQLJCVuWIFgvYBZGmWTaBMqpLDKqbBnZ00IngnfELqjT 5p1X60E6zTTdPRzB4zJyg+VbGSoSw20K9su9TJAT2SndBM45Q11wpibIeX6fn0jnreYa TMezLLwSQpAK+F6H97LlDIZOV1fYwnFzhQC+ZOw2A/xNwErTc8tNKUXlWJrsV844zRO3 WJFErvM1fiRZJUfddIhYBq2feaX5wr6TJ+t08PbPGJnMA5w4b64GexmhAlo/c7IB5SqU YQ== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t2y7trma3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Sep 2023 03:27:33 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38D3RW1P000371 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Sep 2023 03:27:32 GMT Received: from [10.253.32.174] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Tue, 12 Sep 2023 20:27:28 -0700 Message-ID: <9952fa20-a27f-3240-cc49-5c5109febfc1@quicinc.com> Date: Wed, 13 Sep 2023 11:27:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v6 4/4] clk: qcom: add clock controller driver for qca8386/qca8084 Content-Language: en-US To: Stephen Boyd , , , , , , , , , , CC: , , , , References: <20230901091823.30242-1-quic_luoj@quicinc.com> <20230901091823.30242-5-quic_luoj@quicinc.com> <27ae3297ad161fd67706db70b402db04.sboyd@kernel.org> <16d09acf-7bdd-04ee-6faf-936c0366df03@quicinc.com> <17681a9f756cc70a190c674c51b90140.sboyd@kernel.org> <5a4805f7-f802-b1ba-9804-59c0fe6c7f26@quicinc.com> <92058c25fb11b75ee0a2298a684825e9.sboyd@kernel.org> <82adb75659e0d278e25b65b0e81df99a.sboyd@kernel.org> From: Jie Luo In-Reply-To: <82adb75659e0d278e25b65b0e81df99a.sboyd@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 7BYyjn1zRs1uY_oh7kW-dxqVG4pvz1k5 X-Proofpoint-ORIG-GUID: 7BYyjn1zRs1uY_oh7kW-dxqVG4pvz1k5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-12_24,2023-09-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 phishscore=0 adultscore=0 impostorscore=0 malwarescore=0 clxscore=1015 mlxlogscore=999 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309130026 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/13/2023 1:18 AM, Stephen Boyd wrote: > Quoting Jie Luo (2023-09-12 05:07:02) >> >> >> On 9/12/2023 4:11 AM, Stephen Boyd wrote: >>> Quoting Jie Luo (2023-09-08 04:10:35) >>>> >>>> For example, when the uniphy works on PHY_INTERFACE_MODE_2500BASEX, then >>>> the parent uniphy clock rate is 312.5M, which is decided by hardware and >>>> can't be changed. when a branch clock requires a 25M clock, the parent >>>> uniphy clock maybe updated to 125M by clock framework if the flag >>>> CLK_SET_RATE_PARENT is set here, but the actual hardware clock rate of >>>> uniphy is still 315.5M since the uniphy still works in the interface >>>> mode PHY_INTERFACE_MODE_2500BASEX. >>>> >>> >>> If the parent rate can't change because CLK_SET_RATE_PARENT is missing >>> and the hardware doesn't allow it, then perhaps instead of having a >>> frequency table we should have rcg clk ops for determine_rate that >>> simply looks at the parent rates and finds the rate closest to what is >>> desired. And for the set_rate clk_op we can have it be simple and just >>> program a fixed divider. The benefit is less frequency tables that don't >>> do anything and less hard-coding of the frequency. I thought we already >>> had those rcg clk_ops but I couldn't find them with a quick glance. >> >> Thanks Stephen for the suggestion. >> looks you are saying the clk ops clk_dp_ops for the fix parent rate? >> which seems not meet the clock requirement of this clock. > > Yeah that is close, but the determine_rate clk_op needs to look at all > possible parents. With the dp clk_ops we assume that only one parent is > possible. > >> >> For the device qca8k, it is also possible to switch the interface modes >> between PHY_INTERFACE_MODE_2500BASEX(312.5M) and >> PHY_INTERFACE_MODE_SGMII(125M) during the running time, and there are >> multiple parent clock source(P_UNIPHY0_RX or P_UNIPHY0_TX) for the RCG >> clocks to select according to the current work mode. so the parent_map >> and freq_tbl are necessary to this clock. > > I still don't see why the freq_tbl is necessary. Hi Stephen, For clk_rcg2_ops, freq_tbl is used to find the closest rate to decided the parent clock, the configuration of clock source and clock divider are saved in the freq_tbl to configure the RCG hardware register, the mapping of parent clock and hardware register value is decided by the freq_tbl for the RCG clock.