mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Pankaj Raghav <p.raghav@samsung.com>,
	jan.kiszka@siemens.com, kbingham@kernel.org
Cc: gost.dev@samsung.com, linux-kernel@vger.kernel.org,
	song@kernel.org, mcgrof@kernel.org
Subject: Re: [PATCH] scripts/gdb: use mem instead of core_layout to get the module address
Date: Wed, 12 Apr 2023 10:52:50 -0700	[thread overview]
Message-ID: <9954a532-871a-e747-908f-bc5a3e32a55f@gmail.com> (raw)
In-Reply-To: <ffc82a81-c212-7990-53fb-2f95eb7af2ad@samsung.com>

On 4/12/23 04:26, Pankaj Raghav wrote:
> On 2023-04-12 13:15, Pankaj Raghav wrote:
>> commit ac3b43283923 ("module: replace module_layout with module_memory")
>> changed the struct module data structure from module_layout to
>> module_memory. The core_layout member which is used while loading
>> modules are not available anymore leading to the following error while
>> running gdb:
>>
>> (gdb) lx-symbols
>> loading vmlinux
>> Python Exception <class 'gdb.error'>: There is no member named core_layout.
>> Error occurred in Python: There is no member named core_layout.
>>
>> Replace core_layout with its new counterpart mem[MOD_TEXT].
>>
>> Fixes: ac3b43283923 ("module: replace module_layout with module_memory")
>> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
>> ---
> 
> I had one question:
> - Is there a way to import enum? I currently hard code 0 but it will better if we can
> use the MOD_TEXT enum instead.

You should be able to with updating constants.py.in and using LX_GDBPARSED()
-- 
Florian


  reply	other threads:[~2023-04-12 17:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230412112345eucas1p10c0ab064156268c9021abe9fc6bf1fd3@eucas1p1.samsung.com>
2023-04-12 11:15 ` Pankaj Raghav
     [not found]   ` <CGME20230412112608eucas1p2e8aa819cf92ccc2bacfe0ff9bfcd7a6f@eucas1p2.samsung.com>
2023-04-12 11:26     ` Pankaj Raghav
2023-04-12 17:52       ` Florian Fainelli [this message]
2023-04-12 20:06         ` Pankaj Raghav
2023-04-12 17:06   ` Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9954a532-871a-e747-908f-bc5a3e32a55f@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=gost.dev@samsung.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kbingham@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=p.raghav@samsung.com \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®