From: "Arnd Bergmann" <arnd@arndb.de>
To: "WANG Xuerui" <kernel@xen0n.name>, "Huacai Chen" <chenhuacai@kernel.org>
Cc: "Huacai Chen" <chenhuacai@loongson.cn>,
loongarch@lists.linux.dev, "Xuefeng Li" <lixuefeng@loongson.cn>,
"Tiezhu Yang" <yangtiezhu@loongson.cn>,
guoren <guoren@kernel.org>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] LoongArch: Add unaligned access support
Date: Mon, 17 Oct 2022 10:22:00 +0200 [thread overview]
Message-ID: <995e1d32-7818-4a44-9911-705dd1c62929@app.fastmail.com> (raw)
In-Reply-To: <52ada3c4-f4f2-dc27-5899-d29e5952189d@xen0n.name>
On Mon, Oct 17, 2022, at 10:05 AM, WANG Xuerui wrote:
> On 2022/10/17 15:38, Arnd Bergmann wrote:
>> On Mon, Oct 17, 2022, at 9:31 AM, Huacai Chen wrote:
>>>>> +/* sysctl hooks */
>>>>> +int unaligned_enabled __read_mostly = 1; /* Enabled by default */
>>>>> +int no_unaligned_warning __read_mostly = 1; /* Only 1 warning by default */
>>>>
>>>> The comment says 'sysctl', the implementation has a debugfs interface.
>>> Originally "enabled", "warning" and "counters" are all debugfs
>>> interfaces, then you told me to use sysctl. Now in this version
>>> "enabled" and "warning" are converted to sysctl, but there are no
>>> existing "counters" sysctl.
>>
>> I don't see the sysctl interface in the patch, what am I missing?
>
> FYI they are chosen by the Kconfig options and live in kernel/sysctl.c.
Got it, that's what I was looking for, I had completely forgotten
about how we got here.
> And I believe the debugfs interface (the counters) is inspired by the
> original mips code. Pretty niche use case but can be handy at times...
Right, I see what it does now, and I agree that this is not a problem.
A tracepoint is probably an even better way to handle this flexibly,
but since it's not a stable interface either way, this can be optimized
later on.
Arnd
next prev parent reply other threads:[~2022-10-17 8:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 13:34 Huacai Chen
2022-10-16 15:04 ` Xi Ruoyao
2022-10-17 0:16 ` Huacai Chen
2022-10-17 5:49 ` WANG Xuerui
2022-10-17 7:12 ` Arnd Bergmann
2022-10-17 7:31 ` Huacai Chen
2022-10-17 7:38 ` Arnd Bergmann
2022-10-17 8:05 ` WANG Xuerui
2022-10-17 8:22 ` Arnd Bergmann [this message]
2022-10-17 8:13 ` Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=995e1d32-7818-4a44-9911-705dd1c62929@app.fastmail.com \
--to=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=guoren@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=loongarch@lists.linux.dev \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®