From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B777C3F6B0 for ; Tue, 2 Aug 2022 08:08:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236251AbiHBIIa (ORCPT ); Tue, 2 Aug 2022 04:08:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236345AbiHBII2 (ORCPT ); Tue, 2 Aug 2022 04:08:28 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 255842637 for ; Tue, 2 Aug 2022 01:08:27 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id a9so8038891lfm.12 for ; Tue, 02 Aug 2022 01:08:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=HsSHGNI5OACJwEWXjbDzjjqUsgJ2e/s83LTa6i8r0GI=; b=x9+2qf4ZdKgMTZvBEcj6p1uz8yxPF/KbiP41BT7UBm02nqoaQcV08jWKe5qCE5a4K9 iRJ5Hx81rBXLs+eFmpXM02R8pj7Qi5ER5uGEzFauqq8zbP5hI/jNqXErDS2fDjRL3ELA QdJuzdGI0AFGk7ylTyPLFuYEjpV86+tZ82bjBTnaAWNeUUTPJJDeDSJ41K6C9ejCkaSZ JWp3D+OdgZTQki8hyYRZSyyEpbanEwNIHYq2WjRtFa6bUJfeQkaLu3Krk9AACkRYFuoh 3HpZ9ksUHPAn8tEWjWh4V0lcJ+ivfWefHK9lslCDHJb3wrGIADIufBGDDIQEMeK4etVO GLlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=HsSHGNI5OACJwEWXjbDzjjqUsgJ2e/s83LTa6i8r0GI=; b=EoQ5ULYx/kScb2278610RXRZKBD1NGsKYfcspQKT04sNEt4hoyxIiViIzl/pWk/CjP 3uSWH4myYf6dP+ymrzRl1JmxEX16+OvkdQtL0odhrAIAYp9IGXbDlDXgxcNcxe5E2J3F nJCq4m+CRZhPh8ScAFm9FODZrpV8lt7BVELkIoxdD0Y5xOJMvbhBmT41VkXOZ3tMQ1JH 5XjN/G6AbSaklKE5cDHS2ZB2TsPS1aYo9rU+iX2ThKLzS/4YsXXyDqCuDhij+0vVSndT zFHSzQ8QTDOHgRv98x9MWY01B1v4Vps547+4+pfSoPEz5479PbkfxFWqNdJdlTBLjvV0 8WdQ== X-Gm-Message-State: ACgBeo2sIJNMQ1rLSrI5GT3a5hy/laQgKbQ4iBbK4r+qvGX7zz7MAqWJ AigY0U4KxJfyOkh1qJnIROLSrg== X-Google-Smtp-Source: AA6agR6fhg7bVDtnj6MaImLAqneEW0TB3bldN3JTZEOELsJkGM35fAWCQzptDK4wcs1ivPOsQuqJbg== X-Received: by 2002:a05:6512:3609:b0:48a:ef9f:9465 with SMTP id f9-20020a056512360900b0048aef9f9465mr4871576lfs.115.1659427705492; Tue, 02 Aug 2022 01:08:25 -0700 (PDT) Received: from [192.168.1.6] ([213.161.169.44]) by smtp.gmail.com with ESMTPSA id f16-20020a056512361000b0048af4dc964asm894454lfs.73.2022.08.02.01.08.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 01:08:25 -0700 (PDT) Message-ID: <995fbb2b-2b34-d407-6bfd-4798de2251d7@linaro.org> Date: Tue, 2 Aug 2022 10:08:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 2/2] dt-bindings: gce: add gce header file for mt8188 Content-Language: en-US To: Elvis Wang , Jassi Brar , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , CK Hu Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220729084319.6880-1-Elvis.Wang@mediatek.com> <20220729084319.6880-3-Elvis.Wang@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20220729084319.6880-3-Elvis.Wang@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/07/2022 10:43, Elvis Wang wrote: > Add gce header file to define the gce subsys id, hardware event id and > constant for mt8188. > > Signed-off-by: Elvis Wang > --- > include/dt-bindings/gce/mt8188-gce.h | 1079 ++++++++++++++++++++++++++ > 1 file changed, 1079 insertions(+) > create mode 100644 include/dt-bindings/gce/mt8188-gce.h > > diff --git a/include/dt-bindings/gce/mt8188-gce.h b/include/dt-bindings/gce/mt8188-gce.h > new file mode 100644 > index 000000000000..b15e965fe671 > --- /dev/null > +++ b/include/dt-bindings/gce/mt8188-gce.h Use vendor in filename, so mediatek,mt8188-gce.h > @@ -0,0 +1,1079 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ Dual license. > +/* > + * Copyright (c) 2018 MediaTek Inc. > + * > + */ > +#ifndef _DT_BINDINGS_GCE_MT8188_H > +#define _DT_BINDINGS_GCE_MT8188_H > + > +/* assign timeout 0 also means default */ > +#define CMDQ_NO_TIMEOUT 0xffffffff > +#define CMDQ_TIMEOUT_DEFAULT 1000 How CMDQ_TIMEOUT_DEFAULT is part of bindings? How is it related to bindings? > + > +/* GCE thread priority */ > +#define CMDQ_THR_PRIO_LOWEST 0 > +#define CMDQ_THR_PRIO_1 1 > +#define CMDQ_THR_PRIO_2 2 > +#define CMDQ_THR_PRIO_3 3 > +#define CMDQ_THR_PRIO_4 4 > +#define CMDQ_THR_PRIO_5 5 > +#define CMDQ_THR_PRIO_6 6 > +#define CMDQ_THR_PRIO_HIGHEST 7 > + > +/* CPR count in 32bit register */ > +#define GCE_CPR_COUNT 1312 No register values in the bindings. > + > +/* GCE subsys table */ > +#define SUBSYS_1400XXXX 0 > +#define SUBSYS_1401XXXX 1 > +#define SUBSYS_1402XXXX 2 > +#define SUBSYS_1c00XXXX 3 > +#define SUBSYS_1c01XXXX 4 > +#define SUBSYS_1c02XXXX 5 > +#define SUBSYS_1c10XXXX 6 > +#define SUBSYS_1c11XXXX 7 > +#define SUBSYS_1c12XXXX 8 > +#define SUBSYS_14f0XXXX 9 > +#define SUBSYS_14f1XXXX 10 > +#define SUBSYS_14f2XXXX 11 > +#define SUBSYS_1800XXXX 12 > +#define SUBSYS_1801XXXX 13 > +#define SUBSYS_1802XXXX 14 > +#define SUBSYS_1803XXXX 15 > +#define SUBSYS_1032XXXX 16 > +#define SUBSYS_1033XXXX 17 > +#define SUBSYS_1600XXXX 18 > +#define SUBSYS_1601XXXX 19 > +#define SUBSYS_14e0XXXX 20 > +#define SUBSYS_1c20XXXX 21 > +#define SUBSYS_1c30XXXX 22 > +#define SUBSYS_1c40XXXX 23 > +#define SUBSYS_1c50XXXX 24 > +#define SUBSYS_1c60XXXX 25 > +#define SUBSYS_NO_SUPPORT 99 > + > +/* GCE General Purpose Register (GPR) support > + * Leave note for scenario usage here > + */ > +/* GCE: write mask */ > +#define GCE_GPR_R00 0x00 > +#define GCE_GPR_R01 0x01 No. These are no bindings. Do not embed device programming model into bindings header. I'll stop review. Best regards, Krzysztof