From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753790AbcHRMkq (ORCPT ); Thu, 18 Aug 2016 08:40:46 -0400 Received: from mail-db5eur01on0094.outbound.protection.outlook.com ([104.47.2.94]:21189 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752404AbcHRMkn (ORCPT ); Thu, 18 Aug 2016 08:40:43 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH] UML: don't discard .text.exit section To: Dmitry Vyukov References: <1471446611-16250-1-git-send-email-aryabinin@virtuozzo.com> CC: Jeff Dike , Richard Weinberger , user-mode-linux-devel , LKML , Stefan Traby , stable From: Andrey Ryabinin Message-ID: <995ff767-9220-f9c8-c052-2b717cc7e91d@virtuozzo.com> Date: Thu, 18 Aug 2016 13:08:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AMSPR02CA0039.eurprd02.prod.outlook.com (10.242.225.167) To DB6PR0802MB2549.eurprd08.prod.outlook.com (10.172.251.147) X-MS-Office365-Filtering-Correlation-Id: 1b94cbbc-788f-4f5c-b2be-08d3c74f70d4 X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2549;2:NFSZvw5NevESUHGPqz0fd8Bz//mSlEVvkQU7jPndcUVAR5Ee/7O7lYRmwlAw9XpvCv1Hc/zrDE4LalX1MMxcWBp0HDFPPV8pglWujFrBUUxoDt+FYbRc/lZpudzrOfajGx2OBKSo/Quo4JBjeVc+U1f+HdtY+ZegE8xtXPya77ZaNWnPyn7fABRgfCJzgMeU;3:GSG+uGaCbsXANNHAsqP2I/psORhbFyd4XmB42Qf8ztvrvmSBsYvVahOzYTK/u91BLxoUM9ONRBfj37i9SFWNjXlv5apqWOTqFgGAxqIIvXoGMPq+LQEWTfj23wKIahD4;25:CBQGx6Q+/lS8OXKAfOnMwvNCnV2PTTGLQR07Wky1PYSJI4YfHH9SUX/JJFNKIYIDgFuCclto7n5JfN14+lyrD9DAMoyKQhEiH6adufM7pYMN3ccmvZg7ebu9aJXheQSnnmFTFpMx8IYobQ7UauQFnpjMN6q0q0cwQ+DGDCcBtL98Uq3ma87CesQD/gdH3WnxkMCb/jnnO2M2zL6hHpd/6+h+UU11GK6qGOM2amr4ksbBLsAYBE2h50DwDbt6ge527/tWQs4czdxylnScdolJ3sVQ+jyvbxgP4CZT9C2Kt0LRcaSKj+uKQDq5gS5IrwQrDbDeeRmCyNa2YO9IGpUjcWibGHBkiGNj11cZmY59/oYI+LqVTuo3Vu2wadwx3ZcXJsBjbtyJ6H11ZArLY5TWex7kAqZpAyPGOzz7FuyC2OE= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2549; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2549;31:CgidEQVwEJQDgZ9k84JCcwdras1FkOuwIlY6TgEO55kSgzQb9j8id93rVwdmV4u+B8E+FTBkZuA8zFFtbJONPFuPwD09g9Uo3G4CPVYCf+5W4GSgAeiRpiyQktdwMVDiHlSw7X/fLHYBX6OZC7QUOU4eBYgFxIND33a4hhWjv8yBNlrpvj01/bGJKbZzk6bH/HtzkBDlnks4X2p1UmQ5SMpLHjiYosdaXJVJW6vcrmA=;4:CWzaoulyoi4kHh8CvS+6FZFjTuYds81ExQUNEyW+YXGr9gE4oJGtw8WrIjvL4OXyvT0YuV+GR3JX6kjWaRrCcEa1ta+Qh1JmptvkshncJvl6Vuk1onSnCmxx7JhMgVoy8nyhQQNIAu6Pbi1JTHMte2z/dm8S0JqJI3ykOqxZg462t2N5ft3tPaFuoqwfrePZM1rE1Wlom/E4ewNskfBzdU1IFza3MNFUjQVUGbY84MQ+M95UzS9WtgwE2NO/bSrGd5JC4+tvarWYijzIC92vCk7lv1PpkqBLhFuNC9Lyf7YCMMUY+VeklZ63FY8EstR9J0fUEIjRYx3owQrwmENijy37O0BK+/iFlsellEbtHfvFaGXt2mcxVswFS0gGc0IZQ5VxqRn1TmErYzXIurkwjKEJjlsYZ6nhmLLWj5paT3vNWyQvi9uZFWGRFjFQMQ8yOjz3yNVgxrX4pY2rgfLPgg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6043046)(6042046);SRVR:DB6PR0802MB2549;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2549; X-Forefront-PRVS: 0038DE95A2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(57704003)(189002)(377454003)(199003)(24454002)(586003)(6116002)(3846002)(83506001)(54356999)(230700001)(76176999)(4326007)(50986999)(2906002)(23676002)(31696002)(92566002)(47776003)(36756003)(2950100001)(77096005)(305945005)(105586002)(7846002)(7736002)(101416001)(64126003)(8676002)(86362001)(33646002)(68736007)(81156014)(81166006)(31686004)(66066001)(65956001)(106356001)(65806001)(19580405001)(50466002)(19580395003)(110136002)(189998001)(97736004)(4001350100001)(42186005)(65826006)(142923001);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0802MB2549;H:[10.30.19.223];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjA4MDJNQjI1NDk7MjM6b1doZVB1ZDhEMW5yT1NtVmo4Y3I0UWVz?= =?utf-8?B?UzNzcXZsNnlxM3BxR0VGZzNHWm5VZEZoWGNEaUtZM1FLVWZDbVdDSys0cEUw?= =?utf-8?B?aWpGKzUzbUozQlV2QnNFVzFVY3JjODNZT2dIOEdTbm5Pa2NSZU0rRlo3RzBo?= =?utf-8?B?aDRIR29nTWVybGNJMFlCSXFtdFE3ejhKaU1tNlVYVjgxaTNZL1hyL3NFUDVZ?= =?utf-8?B?MkdCRmQxZW1JUHI1bjJQNGl6T3FiTHFtbmhKdkErekVFMFdVcTZoRVFub0hJ?= =?utf-8?B?cEVFaDJueStlWE5rVVY1NnE2R1lOYkRDMHVHZnRZd2dxSFdqbmhRKzh5STJ0?= =?utf-8?B?b1RoeHdTQis5WnpyWCt1c05uZTRMRzBKa2s5UW5jN2xZZ3hhZzFxZzg3Y0RJ?= =?utf-8?B?bUtvazA2VGRGaU0rSWtEcXNNYXJyOE10VnVOTFQzVWE0aTd0QWQ5ZlNqOVdi?= =?utf-8?B?WkR5MldVTjRCMzIrcFFsMlgzWUFmTFBjZmJWWnp0dmFKL3BheFZGM2trRGFy?= =?utf-8?B?ZDBvNWhyN1VBM0N5Yis2MmpXMGtoTEJ3SWJaMEJ0aWdNcnM0eStmQ2xOblVm?= =?utf-8?B?TUhoZndPNlNnTzVjZWs4ZktNdjl6OTBQT2pGdjY1K3BaZk94dE8rdFZLUHdn?= =?utf-8?B?bDZ2UUtCaWdVVkRna0ZpT3lsV0VWOStJclM5Z1RLRTJla29KK0RucFVjM0xa?= =?utf-8?B?Q2FvRDZPTU40TThJNVZBbCtiSldyc0JUTWQ3SWd2dG5rL2lTQk9ISzN6c3Ji?= =?utf-8?B?Y2ZvVlIzUTJPVHU5UDZ0cnUzbWtvclh2S1VQZ3U0L24zRG4xMTlWdGR5M3FK?= =?utf-8?B?aXdMR29tUStqN0YzMHF6L1ZDMVJ4UnM0Q04vazdzbDl6TDl2YXVXMlR6WXBO?= =?utf-8?B?TlpzZ01TNFJFUW9TZ0pwZ3FlclZybUFmMVNFZlRsM0pYQlNzVHV4aERFTVI0?= =?utf-8?B?YjZXSlZxUVFJTnZqTWxEQXNoY2RhR1dZMzVsQTVBNUVGR2d1emUrYU94RUFw?= =?utf-8?B?TlRHR0ZtY0RuTVA1azh1em1nVUJDeVNZZ1ZYV2xHTDRxaHBGUXJKa3MydDgv?= =?utf-8?B?NnduZXNzbkVJbVNGYkQ1UndZT0JFZUtHc1duTm5xNWJWNWFhdVY3QXdWNGZF?= =?utf-8?B?SDNkWWpuUkpmVWFJV2RaeGo0a0FqdEFnZEFhNHowUENqankyYTdiR2N5cUpm?= =?utf-8?B?dk9oejdHKy9lcysrcDl2ckt3bFRqS1VyZ0RFb0dTMCtJSEc4R2E3aHBjZjN3?= =?utf-8?B?dm81bG5SUmdoMGpQT2xWYkwycWFtTTZTOHgyeFZSMWhaVCtZSC83SnhkeEdx?= =?utf-8?B?WDIvYmZzVHBKeUMvYVFpTkNUWVJFN2g3QkUzaE1GdGxjRUdsU0xzTWViQ2F6?= =?utf-8?B?eERWNG9nVlhxcFRsN3A1b2tmL3c2UnZNNjgwZW9ub2pnNm1ORkpaZFo3UFA0?= =?utf-8?B?KytjWXN0MFk1alBNZnZYVDNTK3dlalQ0Wmo0UmljNEtEcVJBZEh5V0FYK2tz?= =?utf-8?B?d2NLdVJUUXJkVDhMejNVemcyaW9DbEVNOHRYTXd3MWhBcW01bDQ0OE5xcXR4?= =?utf-8?B?emlIWWJKMWxKQjJQQklMbnNDQTVKQXQ3anBWYjlMT2NrNVYydTdqMHVtN0lQ?= =?utf-8?B?NFlycll0Y1RZRThEcHA5YkRJUVRQMnhUa1drcnRzTTVHclJ0ajRLUHJkMndS?= =?utf-8?B?R2dSdXJoeFJZclF4SlA4OS9JSTd4UUEzdHVqQ0tDaFp0bEFOalhyRU95MEdl?= =?utf-8?Q?XVSX/MRwNLNqXN0xgl+wJaE3HIo7xtsuWh+SR/I=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2549;6:mt8mvosrziuqVF8VGoH/6l7Xjd/RO3Nu3oO4X+btndJjjcFxDuLZjAPjufYFZJyRlp5HpDHWSgrzZiu1VP1zMSYy4LzB5ubDJ7CDy32LuL1Oo7fP5cDcHbXpAm7vaO3FX17bjw+tOhjZSNIQ2SDn5NSIzr/4U2VlA+9afn0bW2W9FAFXE1wFH+FoaeW/L861NxTOc8UbcJzGlxo7gLx0Eqlq0YdzLVrUDYKQB+c0T5AUpjRotzBajJql2EUcHEMts5ipHnzgWvX7SztTMzgzeGPxtDXI3i93gvgl6PXejR/oewFvQTYRc0stWhRTt2a8;5:Cot+ZDGGcv9X+efBqv9BOG46KWUaIBLHbuNYk4ZgiCtUF4LKezCNAeAKROYHIL4Tgy2qKGI4VUo4BmbxX47MGGvAGIyAh+zC1rfu+XYLs8MtkU2pFnARKmliF5EbQq8jTYaLPZqCjqpAcxWmSl3+zQ==;24:oyiC4sw/fZMErwLUmHaSVH3NVS5Re9XCsDXuMUhDAm79gi5BWVERx6oQpRApjVqKiyr/FRHCnPhP4uV0WE7I4twyseHp6omi2VUf/sszf6s=;7:BWj22xem9kwaDVeyF0uweHNslAwkqyblgvG/RoPNKkIjMaHJujCOSLHgrcmMbGeZUmkLCPJad7lo55Y4Ftivh7Cd2jsV46iCYgQNEGI6aDBYyT23xs7F3Pz6pcwB1hffgSQJPu5OTo7qawf/cOzm0SrHLL4FctHLFUHUcg/a9GZbWZoeVSr1BWb3ddQIn+thJWXemj8wt8gI6ByyFpE8I01c91vCQqgPcS0DA80AmSWgB0sbyqu3RLTUU4zRWR3E SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2549;20:Emak0OWrZWaNDUt2h11gHB1Ls+iLHbfuDXbFki+2M9ZyUkKQOQorXtBePlVLrrx7VyHuKZvscDmUj+zXW20bTDRSdN402vmM7+rIyPNoUaINzgfRd/1jO8idiHiy2ytotJ0445qbLZ1XsZ1TIMMmg/PZvV8rHnzfvv/FLfxss/M= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2016 10:07:19.2578 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2549 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/17/2016 08:11 PM, Dmitry Vyukov wrote: > On Wed, Aug 17, 2016 at 8:10 AM, Andrey Ryabinin > wrote: >> Commit e41f501d3912 ("vmlinux.lds: account for destructor sections") >> added '.text.exit' to EXIT_TEXT which is discarded at link time by default. >> This breaks compilation of UML: >> `.text.exit' referenced in section `.fini_array' of >> /usr/lib/gcc/x86_64-linux-gnu/6/../../../x86_64-linux-gnu/libc.a(sdlerror.o): >> defined in discarded section `.text.exit' of >> /usr/lib/gcc/x86_64-linux-gnu/6/../../../x86_64-linux-gnu/libc.a(sdlerror.o) >> >> Apparently UML doesn't want to discard exit text, so let's place all EXIT_TEXT >> sections in .exit.text. >> >> Fixes: e41f501d3912 ("vmlinux.lds: account for destructor sections") >> Reported-by: Stefan Traby >> Signed-off-by: Andrey Ryabinin >> Cc: # 4.0+ >> --- >> arch/um/include/asm/common.lds.S | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/um/include/asm/common.lds.S b/arch/um/include/asm/common.lds.S >> index 1dd5bd8..1330553 100644 >> --- a/arch/um/include/asm/common.lds.S >> +++ b/arch/um/include/asm/common.lds.S >> @@ -81,7 +81,7 @@ >> .altinstr_replacement : { *(.altinstr_replacement) } >> /* .exit.text is discard at runtime, not link time, to deal with references >> from .altinstructions and .eh_frame */ >> - .exit.text : { *(.exit.text) } >> + .exit.text : { EXIT_TEXT } >> .exit.data : { *(.exit.data) } >> >> .preinit_array : { >> -- >> 2.7.3 >> > > > Sorry for delays, I am travelling. > Do we need ".fini_array" section? It's also destructors that we don't > run. Or does UML use them? Does discarding ".fini_array" help? > libc has desctructors and use them for whatever purpose it needs.