From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2924D1AA7A6 for ; Tue, 2 Dec 2025 06:35:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764657323; cv=none; b=k3H8V5NFenygQfSGwDBCY2/7sYQnfkWeJODAk70V7Zb8tvY2rqXOmuECzCj3R34QYQv0uWzzAgDetqbIskgfr0/+s0WdoHzY/S+4aIZzEWafjKUyxPkJD+eU5iRQnhNwgGzmlb0ejFas+H0AfCDGCwYWeNCe339XzjvcUNEJA8E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764657323; c=relaxed/simple; bh=ankNTt4neXOcPc9gnzhoIk3xndCsYDDRUnulh5w1llo=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=ErjHoBjf6sCvchaAB3TJ1vUAkdzkJv9Op3bowZk+dVoImirnv3iILcAWQ80kEQxI04DMyUpFrMR0F2IRk4mfbzsQ88DurzrT5nkJpUVs06De0mQqRJhNUVesx2wEqkzl4a7izVvAKpMRk7JfmbsCPXUKQpcokDi0FyGWhvtMfxo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PLi/7kpn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Qu4Zjw5g; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PLi/7kpn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Qu4Zjw5g" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B1Krx621375791 for ; Tue, 2 Dec 2025 06:35:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9taXAkv/HCL/GxtpivIx6rAO9Nhr3mG7qvCltfnBsLI=; b=PLi/7kpnj6cxlxWh d69wX/letR+dM/SQStD2vN0OwL8jbiDb76f0vDb72vnHcLVZJGeTXzSxgsmNGmmM 4Qq/0kjWMFxV3sX6/rHlszao5qdn6qB53SX4ErKnbFshTbHeyQ1lqJCC4twhCNyO reIKCXklho4Sf1yLMhArCLGBrTc3nWfJxuWIQZaVgXjYF2oDvZlGrY4BPdU6D5O4 aOfS8zfts0X3EVhErVjlUK01zhS8vIHwUaStNP1Cd3T8bsc7J0+zjjvoV5itHGak TK3nOWJW6xEjzqFZghd9ybOGwtd4nNFnjAqXA7Ydw0ZWp0tBLC7lfMGukkAFCYcT RDjXuQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4asjf79eum-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 02 Dec 2025 06:35:21 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-299ddb0269eso61571935ad.0 for ; Mon, 01 Dec 2025 22:35:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764657321; x=1765262121; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9taXAkv/HCL/GxtpivIx6rAO9Nhr3mG7qvCltfnBsLI=; b=Qu4Zjw5gISPiX9mi0EtrIhG+KSgIopnKpNiUZZWlk3wgra5eWdld773O8gT2FQuYrH f/yEwZ7O+KIjaFPFdAV5NEQ9nKuygHPiOq3vLFOiPWBtIW8vy15v2iY5/8V1ytDgbjSR WXsFXjamNHtkLkZwR87IWUhx0tJ2/Bg/ma7if6A2hhoriY3DaCMhG8mOga0N2nc9s3U7 WQp1pVCInMecqFwmFAA0pGTol0urDWEXnMaFIqKKUEj81Vg2OKC1TtA2Ai8+7X++OMeh YFETE+A3HV4wXMcsGuT6OYHa6u9oRahahkzm13QDditAJ1oRup3r/hax9qQ+xYOuyC+6 bgeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764657321; x=1765262121; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9taXAkv/HCL/GxtpivIx6rAO9Nhr3mG7qvCltfnBsLI=; b=KDpxNhmbpe0mMYQulKrK+AinUyPG8RlbRv7D/6hmTtHdaWv4xkynniLGIqGzNs0BvW j8rwp5uHf91UWlFs1zV+O5OTU8BlQyCP0NrdOpNHWjPAags5ARM8beUxE2rLdWPrQj25 iHQfnmhpH/NbmArknH2YC25lZQJ3+kqud3wodjFJ9uKIteXE+BzxM/sTRZ38+a/vKav+ Un9NtO+UvZ1F0X7eLC0h+54yK0jvoVEHq4dX4mVkbyLWa/SPGjzzHlQIEysVloX60LsA NHGhaBPpf1czxdxV7bh5Mf9aD6iUQjFA0AiF0RRitTV4HYiblKOHhj0CqAoERF/s4Q8/ NIHw== X-Forwarded-Encrypted: i=1; AJvYcCVveyk5E0GiKNmk1cuazcTPhDSYGP8zpH3R5ntSCOIuAYQDsBPZFH+U6GviDWoRErOVx9YaZYlIuhRnngc=@vger.kernel.org X-Gm-Message-State: AOJu0YxUMTytZWirFGIbguKPRRrzZ5J8RlhL3zXZN3Js2R3IFj4SZIXn yZTO5bYgR4Yau0/GR4/tg7nnczMlGlovSzytrN6EJ9tK46XT/O/WSdlGMNGbq2xCaLzzgh5YGHQ 3Es48EUn/L+yy0HJAE2Ilzlij+VQaqHHJtXdZ/SpsR/eRqYB6uvLi1LR4hchZGM6YxxM= X-Gm-Gg: ASbGncvzmx0W6L8gVgh2fnbtFsS1QNwI+i/jKKv3piMMdrmMn6atm195m3skxjzmtDo kpM4RT8jtQytN+T1VrIqpP96tNF4/YnMCzx+UNaRvcnUAzNhqeEKCfnogqRiuJUzytLlZxRjSiG vrKjDFdB86ZOGDBoMKd/lp70sRz5pe1+ouEy+cq1Xim/vBypBjRC2JnhY8U7QE8CUGVPwtZu975 Rtirn9GIblRwbYEf5BxiqESJgDtqHMo6rTWcYZF411cB401tR0KpDAYZU5Gie5Q8M6irNeW4Nq2 rG8h2irUTQL30eLJMrekA5p79gWsH6lvtRWMvEyduMAexyiOetHirvKvN32y9WM7HZnpbspO9MJ WRPjoIuwRD5fiItkJKiFkJx2D1A45AfTfGPJ8dBulTwX/MdF1jrrdRLSVHeNbIQ/jgLDkbfF6e3 cWbyw= X-Received: by 2002:a17:902:ef51:b0:297:e575:cc5d with SMTP id d9443c01a7336-29bab141bc7mr345436075ad.35.1764657320615; Mon, 01 Dec 2025 22:35:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IGAAR4obs5E14wU8UmfWdKbVA2VsDO97CAfbLrhjF0gXIPJcW1X1uyl7T+CY3mCzNHNzJeJXg== X-Received: by 2002:a17:902:ef51:b0:297:e575:cc5d with SMTP id d9443c01a7336-29bab141bc7mr345435685ad.35.1764657320032; Mon, 01 Dec 2025 22:35:20 -0800 (PST) Received: from [10.249.18.58] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bce445927sm143810745ad.37.2025.12.01.22.35.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Dec 2025 22:35:19 -0800 (PST) Message-ID: <99609312-bd69-4506-be80-9c6aca6a10ad@oss.qualcomm.com> Date: Tue, 2 Dec 2025 14:35:15 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: wangao.wang@oss.qualcomm.com, quic_qiweil@quicinc.com, Renjiang Han , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] media: qcom: iris: Add intra refresh support for gen1 encoder To: Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Mauro Carvalho Chehab References: <20251127-batch2_iris_encoder_enhancements-v1-0-5ea78e2de2ae@oss.qualcomm.com> <54pZM7wO84wvdB_kwjNvPB0WMjjfGPPtDLg2eXpiGDYgz1N43hG2Z8TLP-nbVVhCwW-77N_i4K4QunzrO8HtKw==@protonmail.internalid> <20251127-batch2_iris_encoder_enhancements-v1-1-5ea78e2de2ae@oss.qualcomm.com> <0e00467c-6d24-43f0-8a66-72160631d2fc@kernel.org> Content-Language: en-US From: Wangao Wang In-Reply-To: <0e00467c-6d24-43f0-8a66-72160631d2fc@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: RPY7q6CrHtbyjqUINEA9xJLlSYMqGcmu X-Authority-Analysis: v=2.4 cv=VfH6/Vp9 c=1 sm=1 tr=0 ts=692e88a9 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=PgoIHAgY8_GuLWmOGKAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAyMDA1MCBTYWx0ZWRfX3QDTmByr5OIK xXC2TIogk65yljuk+H1cfePNkUP5Y2oTCBdHGa2Z/Cz3Y1T/IMmvxpkGLE7gFYarZVh82n5PEzv v49PK+jnIC42GUPMV9BDLywm3i+u7bFFIImg9/dyzXfX6fEBU2GMI65oss3ksTGuTDpBqlPnles kS2DKyrUOrpu6Rq3WNkKww8dOWSiPbYN3YZmUIw59kiylnHTsdeH6dsi5R/bmLm1YrmKNJeAlle z61ZWRtQVWQYPmTvu6TzwVRAQ0kCkIQhCslZnob0OgWBl81+RaqR4px9nu7f9g3Y8R0ksEoOSCn Tt0HNm+0ndYVX7cnms2vZ+1d/OJ+Wuz8L0j2oUXLfAoZdrg9cfQhvrbogAlYZvznXw+Jg5B8DQu wQF4+SRbhIjsOoqY7O2RN+tOTJakgA== X-Proofpoint-GUID: RPY7q6CrHtbyjqUINEA9xJLlSYMqGcmu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 suspectscore=0 impostorscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512020050 On 2025/11/27 18:35, Bryan O'Donoghue wrote: > On 27/11/2025 07:44, Wangao Wang wrote: >> +    hfi_val.mbs = fmt->width * fmt->height; >> +    hfi_val.mbs /= 16 * 16; > > 256 > > But why ? Also why express it as 16 * 16 ? > >> +    if (hfi_val.mbs % ir_period) >> +        hfi_val.mbs++; >> +    hfi_val.mbs /= ir_period; > > This code deserves some commentary. > > --- > bod 16 * 16 is the size of a macroblock. Here, we first calculate the total number of macroblocks in one frame, then determine the number of macroblocks that need intra refresh in each frame based on the ir_period. All macroblocks must be refreshed within a single ir_period. However, there is an issue: the macroblock sizes for AVC and HEVC are different. I will address this in a later patch and add comments accordingly. -- Best Regards, Wangao