Re: [PATCH 3/4] cpupower: Add 'help' target to the 'debug/x86_64' subproject makefile

[Shuah Khan <skhan@linuxfoundation.org>]

On 6/23/24 13:19, Roman Storozhenko wrote:
> Add 'help' target, describing all user-available targets, to the
> 'debug/x86_64' subproject makefile.
> 
> Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
> ---
>   tools/power/cpupower/debug/x86_64/Makefile | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/tools/power/cpupower/debug/x86_64/Makefile b/tools/power/cpupower/debug/x86_64/Makefile
> index b1b6c43644e7..4b35b2474182 100644
> --- a/tools/power/cpupower/debug/x86_64/Makefile
> +++ b/tools/power/cpupower/debug/x86_64/Makefile
> @@ -28,4 +28,16 @@ install:
>   	$(INSTALL) $(OUTPUT)centrino-decode $(DESTDIR)${bindir}
>   	$(INSTALL) $(OUTPUT)powernow-k8-decode $(DESTDIR)${bindir}
>   
> +help:
> +	@echo  'Build targets:'
> +	@echo  '  all		  - Default target. Could be omitted. Put build artifacts'
> +	@echo  '                    to "O" cmdline option dir (default: current dir)'
> +	@echo  '  install	  - Install previously built project files from the output'
> +	@echo  '                    dir defined by "O" cmdline option (default: current dir)'
> +	@echo  '                    to the install dir  defined by "DESTDIR" cmdline'
> +	@echo  ''
> +	@echo  'Clean targets:'
> +	@echo  '  clean		  - Clean build artifacts from the dir defined by "O" cmdline'
> +	@echo  '                    option (default: current dir)'
> +
>   .PHONY: all default clean install
> 

I don't see a value in adding this - these are common targets and
nothing new about them.

thanks,
-- Shuah