From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDD4F38C2C6 for ; Wed, 24 Jun 2026 07:59:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782288001; cv=none; b=KafkZW/qkeGzxolg9h+LfGkfscN865d9nmTW5z852zFlMhchV8sf+qK9u/TyAQCmretbckTi2wscB2ZAlEgCUcLOPP99nnJACZ5qnxUgo9CuTH/Oa/mAqNbWYw+qYvgaXLq0wgnp3lWMhj5LqRRZRLWztwOgCRPflLSckfC48Wg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782288001; c=relaxed/simple; bh=PoMtRmBnrxMpeXjVWALlkhZR7MOSmDLg/HtlBaZghvI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ouydh54jiwKLePpo+6xe75O/tqh6mUNoURI62yvPudQvB31EyXfWY1kBZl3KoW7ea9YOEE9rPsxnNpe05muT3QPmOd8HSlPuEe0E1xLk2NbH9TYYNh7X7P+iXdCYG1pTVEw3VtHpAO09zowgmCgrNVnorD3ZZPRFtHozqPQHOso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eDVl8/lF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Yud/1KlW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eDVl8/lF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Yud/1KlW" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65O7FtF92440420 for ; Wed, 24 Jun 2026 07:59:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6fZ7VuqcPXvlOshGMCZyxgJiDan4vtXvkbaxQbf6mCY=; b=eDVl8/lFMFgqjYfH AFR7LjZRLmq0AqxHum60bHAqvrRwKxSQxDx1OE9VlZBvf5kzQNoMSufU6wzsDBzm GXYzM31Ce8MgmT3NwysyP3bltFNp2X5vh2GmeMtDDNBtIDEYPLaBh7WoVHgRNShG zcT10bL+D8l5nvXz+jttc0d1h1MlOz4J8GTNvmAr55mZJFIVRj3aOPgYAs7x0PDm LUXdcAMz2h15PdtlCeNF0S1QOy6z4Yej+FHtVBHdfEQ8mmdsC2hpmyE7bX7h5TK9 +CvH9dPQMK7vnnNtppUL0fut1/ifcM7lIDZHoTElgfWiwg/q+kNX6DvRfVrbHP38 Q+RBaw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f0apq051a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Jun 2026 07:59:57 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51a07295d67so2446401cf.2 for ; Wed, 24 Jun 2026 00:59:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782287997; x=1782892797; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6fZ7VuqcPXvlOshGMCZyxgJiDan4vtXvkbaxQbf6mCY=; b=Yud/1KlW4/G0j79IGVQUmIOXhUqC+K7VR0GebGu8vg52kuuswiZJ698YBXtWEfcCQf hDZDTwzFjWK3jwwyNubM4l8omrVkk5I1vBSvizuMu7jHzIyIFxK0SDJjD5d22mpTjxPQ Lyp9wWxGVszz6Ra+rWHsBPm90pEuoesdkfJRnMZjvEwz261ObV50M2u+G6M0hYfjRock HQGvadByBFsRQXIP7HgAgpw+10cuhUgtEWQN2hkssJAYrZmli2JMwV2sDyh/z6dT6hkx 3LCXCYGQ97EpNO6U7Dq0UJPx7Bw5PXEalw8ofEvt1YhungaV+NASKXgS0tnQUjQlYtt1 jOTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782287997; x=1782892797; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6fZ7VuqcPXvlOshGMCZyxgJiDan4vtXvkbaxQbf6mCY=; b=iaY5B/NPabnIruVIleBlEuaI5MnAZpi/xxXKG1Gq2vy6t+/YnWWdCdh84FjfoMx+qO 4AbxHkEXghO+jH2rh13vXTSlo5r5BPqn1wb63utRyXmL6QbnfpEO859HOS9oh3twYoas +gtRSW5hBEkYpg336SeiBdGRaKI7SqqTxqRNk/kCnrnWGIoWodkrMcTeqCM/chfxnpIx XFcpmGvatB4zIxZ64G0/oWF+2JEeDU96nsv5DL57cmfsBVLdokN1hEhGbehGE2I/V9WB cJk0eBhbDymNljIjARLUX7koNkVNTNLqWks8K6Grwg0iPm6rmjmuZwmQ+VCK2/ZnGQhz 2V2A== X-Forwarded-Encrypted: i=1; AFNElJ8du8Yt3QkadIiTSRx/9PqNDDP6EB+F7RA76zAQlxd7USVSih2yT6bYNIYuN855MzeHC2QwXlWGecpDXek=@vger.kernel.org X-Gm-Message-State: AOJu0YzPi8AZnhsjgE6mwC+0yEmvGVdpdUJUf8ecoR0+eaG3NMmJkF2N YVvyliVzb2nRgAy9kZNReGs9/hAEXNuapfVbDuun1emaSJ+dlLigtLtAKs3fez+FVU5dZsAw+P/ h0MTxtUvtHASgbqqDtbqgdl2ye1wiTeK4U+9yBMLVk9SZk/6FoUC6XliLz+BTcIITh2k= X-Gm-Gg: AfdE7clzu7lgOyhOX572n5WbrMQIGqF7lsg4rQbtE6pYrqWOwfxtEzYtI+3E5cUoyyf iPKDX+BhTLWvXpQbzLEnziLQDyS9Fjs2YS922aSJ8D6oLDol4f9Oyaqc7Qey8I/PUxMcMJchihl mIbqA8LBuc3a39bIvh9kEt4rpms1OzzsJJIcSqYdzCtUcGs+gP1oMcU1VgauttlUWqCZM+br0lD dzIfrKU36LHRDfTkZejR/xG533T6kFRxe+01++ocFRlVub9evw7N6/7VJw3+FaENKEWvFRlNCLV OxFlBL5Rc9i7nz3vKOeSp0FrVWWsWGItHx8gaZlrPlrcP3Uho/+RyhkBxkEMh05lZd0whmKsNw8 CYvMUDslMrzojmlsoHlZaBOzjteOemXlDKAE= X-Received: by 2002:a05:620a:f0f:b0:915:fad5:9096 with SMTP id af79cd13be357-925cb33c4d6mr894295385a.7.1782287997412; Wed, 24 Jun 2026 00:59:57 -0700 (PDT) X-Received: by 2002:a05:620a:f0f:b0:915:fad5:9096 with SMTP id af79cd13be357-925cb33c4d6mr894293885a.7.1782287996987; Wed, 24 Jun 2026 00:59:56 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0c5eaa64c8sm629274366b.26.2026.06.24.00.59.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jun 2026 00:59:56 -0700 (PDT) Message-ID: <99654e01-3a52-4a9e-b003-24230aa6a248@oss.qualcomm.com> Date: Wed, 24 Jun 2026 09:59:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: kodiak: Sort pinctrl subnodes by pins To: Luca Weiss , Vladimir Zapolskiy , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260612-kodiak-cam-mclk-v1-0-fd294ff003a2@fairphone.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI0MDA2NSBTYWx0ZWRfX46ThuU0X8Ysj LK/cdFw3CypKKX/q7A1AzS4Iy/flRzb7DvJl3mq6bgNNV4VoDc/qvyY6dqIpwFywn5NFLcxmJ4j xvWF/GO7NKilC3s8FNRDygnCtfRuTBI= X-Proofpoint-GUID: lBP8k2qtp4QBxz3IK9oTsaC84AxCL2_k X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI0MDA2NSBTYWx0ZWRfX/T+9mFpnvWXg /Ws0pjqjjUj+QKlM0G+3LMpFTjvFguZYGFKUHMSHF87jK+s8GnmholCZo4KWllypjA5IYIUxoQh 0+knIutqUX+OqxUDurWu02DNvVUipRuucTzTCUIbqN5SmcJBZgcJkPtrAXyUzQJfaTyHGn5Pcmn pkF276KFNyEBsGLYtNQ1tuH7gVqkknl2FtBJp/1VtUG9oy/tsbr8jlpkjymAC84ZOLoDT1WxT4O +Q0ODPL7erIbyMsLLKLz45p1e8wvD9/brHfUnBKLFybyRbba/PrR3M5HB0HRCcNeV4rjsIe3lhA oNrYdJLJWzWyJ2MEU4uhoFoTrmqLITg49GW1YXoHPe2U716WngzIgqhKEV9/CohbEYXExc1a/rv 2dmZrL8Q+tn+xqnUOlYR8Ey6effRMQ== X-Authority-Analysis: v=2.4 cv=NpbhtcdJ c=1 sm=1 tr=0 ts=6a3b8e7d cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=6H0WHjuAAAAA:8 a=XHLXOlM-ELWRbcIoZxcA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-ORIG-GUID: lBP8k2qtp4QBxz3IK9oTsaC84AxCL2_k X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-24_02,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 bulkscore=0 spamscore=0 suspectscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606240065 On 6/22/26 9:05 AM, Luca Weiss wrote: > On Mon Jun 15, 2026 at 2:09 PM CEST, Konrad Dybcio wrote: >> On 6/12/26 3:46 PM, Luca Weiss wrote: >>> On Fri Jun 12, 2026 at 2:59 PM CEST, Vladimir Zapolskiy wrote: >>>> As documented in the "Devicetree Sources (DTS) Coding Style" document, >>>> pinctrl subnodes should be sorted by the pins property. Do this once for >>>> kodiak.dtsi so that future additions can be added at the right places. >>>> >>>> No functional change intended, verified with dtx_diff. >>>> >>>> Signed-off-by: Luca Weiss >>>> --- >>>> arch/arm64/boot/dts/qcom/kodiak.dtsi | 1382 +++++++++++++++++----------------- >>>> 1 file changed, 691 insertions(+), 691 deletions(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi >>>> index fa540d8c2615..62daef726d32 100644 >>>> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi >>> >>> >>> >>>> + qup_uart12_cts: qup-uart12-cts-state { >>>> + pins = "gpio48"; >>>> + function = "qup14"; >>>> + }; >>>> + >>>> + qup_uart12_rts: qup-uart12-rts-state { >>>> + pins = "gpio49"; >>>> + function = "qup14"; >>>> + }; >>>> + >>>> + qup_uart12_tx: qup-uart12-tx-state { >>>> + pins = "gpio50"; >>>> + function = "qup14"; >>>> + }; >>>> >>>> I understand and support the intention to keep this change non-functional, >>>> but this pad "gpio50" is for qup16 also, right? >>> >>> According to my QCM6490 data sheet, GPIO_50 has these functions: >>> * UART for qup14 (OK) >>> * SPI for qup14 (OK) >>> * SPI for qup16 (no pinctrl) >> >> "no pinctrl" meaning "not defined in the upstream dt as of today"? > > Correct. > >>>> Similarly pads "gpio54"/"gpio55" for qup14 function, "gpio62"/"gpio63" >>>> for qup16 function, I find all of these are missing on the original list. >>> >>> GPIO_54: >>> * UART qup15 (OK) >>> * SPI qup15 (OK) >>> * SPI qup14 (no pinctrl) >>> >>> GPIO_55: >>> * UART qup15 (OK) >>> * SPI qup15 (OK) >>> * SPI qup14 (no pinctrl) >>> >>> GPIO_62: >>> * UART qup17 (OK) >>> * SPI qup17 (OK) >>> * SPI qup16 (no pinctrl) >>> >>> GPIO_63: >>> * UART qup16 (?) >>> * SPI qup16 (lane 3) (?) >>> * SPI qup16 (lane 5) (?) >>> >>> But the GPIO_63 looks weird, is the data sheet wrong?! Where would >>> UART_RX of QUP1 SE7 go? Maybe it should be UART qup17 and SPI qup17 and >>> then SPI qup16 ?? >> >> GPIO63: >> >> QUP1_SE6 SPI_CS2 >> QUP1_SE7 UART_RX/SPI_CS0 > > That matches pinctrl driver and kodiak.dtsi at least. Still, the data > sheet is just wrong there. If you have any contact to relevant people > there, please let them know! Please share the 80-xxxx-xx number and I'll see what I can do Konrad