From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941473AbcIVWIx (ORCPT ); Thu, 22 Sep 2016 18:08:53 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:39569 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935045AbcIVWIv (ORCPT ); Thu, 22 Sep 2016 18:08:51 -0400 Subject: Re: [PATCH v4 0/3] nvme power saving To: Keith Busch , J Freyensee References: <13b0fe95-01b8-89d7-df76-efc1aa14b27a@fb.com> <0a2ffd51-6e0f-7db3-8135-84317d8f77bc@fb.com> <1474580016.15303.31.camel@linux.intel.com> <20160922221613.GC14301@keith> CC: Andy Lutomirski , "linux-kernel@vger.kernel.org" , , "Andy Lutomirski" , Christoph Hellwig From: Jens Axboe Message-ID: <99658698-219c-02c2-2f79-ae673693cbcf@fb.com> Date: Thu, 22 Sep 2016 16:07:11 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160922221613.GC14301@keith> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [66.29.164.166] X-ClientProxiedBy: CY1PR21CA0041.namprd21.prod.outlook.com (10.161.247.51) To BN6PR15MB1185.namprd15.prod.outlook.com (10.172.205.139) X-MS-Office365-Filtering-Correlation-Id: 6ed0d7da-694e-49a7-ceb6-08d3e334d17a X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;2:BdJVNDlbPim96AF+xcJ1kyXbqfmw4dIUwaRew5fURoiHWX8iqAKeU6RJBwdTAITfXpk5Urny7R/ADu/pkA9QFiNoedw4N1tmjKEDqt6vyBrBedQCarbsE5lrV0ECDHROktTlPKwPPkY2A4h3ARgdNebxP+J8Kyt2PQyRpJ2Gwb7rng9nJ8catkKQy2YR2rV8;3:AEFvzDIFIKRlkP2ghz0tvbCKSYsCqbt/ceUVS1qFeT/1gRSwSLT+TdqOZN+pjOCwZWopyFadtOLj4pMqByP9YZwNLZVEtX3Nw6+sKz25w5qObK08sedtWTs+9n11cmTv X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1185; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;25:EtGS77g6ab3sEvjFHuq3hcbze6coBnbjABYcy3iUWblvjARiEnxO9UYXq5Tl5Nx9fEtEqy9NM4YOhm6fvIOUlzCrZd5vMD4XXRLeCYgYKtnGKo96NdcucwlZXg2z18V9NuAr4hNLLf5ErR4KgLsPu9bXNc4KqI9Cr4lSW4w6azuEGphaaRlmj5t1O4yLh9XNg0GCWXKv08BlCrIUjII07W6AIGrCqwDo0y6DPQbbVERKSPvJMDpzBTKMIlh1znPryAK8ROnz+jgMrkW0hIwxi0hyoEyd2W6a+jEEFz7nA77+MUtpqUsfzRV7+vcb0ZwWUSCHEYug6SHp1otF5xgZgOnPVG1BkIqyXmwvEzItzOkwugqcmMFSIvn6agYpu1172MbePZS6nzQ3kNaq05dVr8ywA0CVocumx7wIUFECOaRpa8E/OhLZy4wY6GSHdzh1+Eyud+nQ7SFniaLOajM5Y5MmIDXB6qnj1eoLBwHAfYDbWtJcCFWXq7JSiHZbZJrBYo1MmAEduk5PtdsCtX+BTJPDKm+cHL1a6STjyEY9aQbFNiR6CXhTm8rsKrMy0lRTLCdr8wEbz8uDFjIPEutkjlGpXZIk6vZ9oUcHxmkAirW7tYIER8ZX8jCRhynUorhZPcxWk0l6sQqGV1I0Wq9T56Voxk6TxQEgQxH8DQjVArrwzao/JmZQYaakW/xr4LPiheSmnKf6VBOmI1ncci5kQQ==;31:MSXB+4q8m0se/1zQ+orH2l4eT0kFWDvJ4wfnErNRPND7kyCouKyDzd907hlOvpOhWzSVTnY0tKOeBqMeVWgLZz5euY7zRNoE6ZQv4ToCxVt3Xaf5uoOk1QWVKzAJoQ937TbPapogxGblIga8OnUUD89lTjqJpXJNnOApbnTxPhsgfscA5HE+ZrufAOQTApewy+qvMO1hIJWk+R+tJw3Xdhhy986m/G1Vt88lmB/ELMc= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;20:ppM9uY9yx/sXxHRy1H0DGG5uHaVdAokV59hRqdSd9SWM3z6kZUqQuMC72IJH5YoWJIQmGO9y1tx29dO74SlPlyx0pwnB9LPxJqkqi2txztcBcdpnQQpbXwyM6T4EQMom+2fxzgsuHWIkKxC0SNgVwQl5AImObTjvTlZNvFSnbuA=;4:087drEfViWlkGO26c2ZjUY4k/Q8r6xov1e+2/VcYSQOfd9WlS4QlsRZsd/xlONrFps/E8cqGZTY5U3S+WFgiqCFAVmscAxednCuLtSaHZxGRZBcYbn8Un19xhJklSBzlXYGqrFwSQ7EbS1w44LGePH8jW7hYnb9o2Eu7SNnvN//XSuEHhZ/YgNH6oM2NcrPps8WLnNmGSZEFFXX+6s1bO2Jp8Dy4Hoqa9mEE77KISQT69tEFanYhVWHpCmn+HIHooP4qpaeXeuGuGhQB0lhimC4rSV68W/8onJqcBNZLntlc7jY7Je8+RSR6gGQ3SKrpmoeOr/N02nwsjvr2VfQ+HR7jBFsShcDGfxfRXV4a2CI8Ng6ut7k3V2C2dxo71UCZ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:BN6PR15MB1185;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1185; X-Forefront-PRVS: 0073BFEF03 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(24454002)(199003)(377454003)(189002)(64126003)(4001350100001)(117156001)(33646002)(101416001)(93886004)(76176999)(36756003)(50986999)(54356999)(50466002)(2906002)(7736002)(4326007)(31686004)(97736004)(5660300001)(7846002)(305945005)(92566002)(105586002)(68736007)(5001770100001)(3846002)(6116002)(47776003)(66066001)(81156014)(42186005)(2950100001)(81166006)(83506001)(586003)(230700001)(106356001)(86362001)(8676002)(189998001)(65806001)(65956001)(65826007)(77096005)(23746002)(31696002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1185;H:[192.168.1.176];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR15MB1185;23:RyAan6omKLlzbweykgiJHvXq2Ddfe8QZ/zy3Y?= =?Windows-1252?Q?QHcwTdJFSnVG010/G92WDqfvm0+LiflDvl0g4B5bd9BpCnTipg39l/WX?= =?Windows-1252?Q?i1y7bsb9jcpbtKSaXsrpDw1iZJh+QyAPfAUDdTTCMVvvQwYvLajqhhU7?= =?Windows-1252?Q?Yn3l+FiSwt2AM89HbNp0wy1OWYiJAPCJyr8mXH522AAaX5+jKhGVffs1?= =?Windows-1252?Q?B+6gNIsNt4DLnDwcIESwVu7M5ENSuhCF7fBQBc7vkqyAD8XrR1txtJNa?= =?Windows-1252?Q?fPTATe4xPlAQmgMSwxnyvJYrIv+z7V1lYPkEj9Rqg+NdxfOKj11iRhfM?= =?Windows-1252?Q?A8Lxlm/dHyvBRNz/jODRcLWioJpJB7ZiMTRpsRbOwByfZ7a7e5pGyJ8z?= =?Windows-1252?Q?/dOLQgnmXNSNS9qE+PxtGJbZO+2XWXXUQ9PaLBi+8vbuVP8e+fpMciNd?= =?Windows-1252?Q?d0DYzRjczkhYVGwEGgiAlcGAW/4eIeMA06gtwdjaXR+MuTgq55O7tGqR?= =?Windows-1252?Q?OF+AoCWEsKVPwVn1kPeuSAGEHk2/NqpBkR8X6kfgTlK/tTTTCpNozURi?= =?Windows-1252?Q?OAA2xUwd/q/5M9/zCNKvbrNHWN43ptglV9DfV6yPpLvPbrqH+aChVy5g?= =?Windows-1252?Q?pNgCsspTIVqyDPFmVqI2zMCwF55CpW0jHIcJltHAiRK583YlJ4mZdK3j?= =?Windows-1252?Q?9UpJ7pPW+I3TYK/DzWGCpwSVINTAvQrUmny8R55q5S9Vca+ChoUSlqgb?= =?Windows-1252?Q?mAmoVli+lLLaOuuDay8ccRoPbtosNsJ9U116+IwceGKmHgVQ6+2Cc+p2?= =?Windows-1252?Q?zXAT3m3QxM9xtkZNha4JhnyuSZ+PaPreoUR/UvyfPfAgwl5ziQAxEIEm?= =?Windows-1252?Q?pXUB+XKxdovLaq3CfiHaBVMnkEFHBzhXlYc9aVnELyC4X4vI05nIReKk?= =?Windows-1252?Q?XAE5V6Y8wXiZtOKoQ3PzpRLAei7PepkIeKRfA5OWjqz1Aq0cVCKQ2KYG?= =?Windows-1252?Q?gXguMpmq1OLeea/9D3jviyGxp7IYZi7mXvha0CaLpOZKBdNy6WQD0zqc?= =?Windows-1252?Q?qS7e9b2yJx8QE41hqdiNqR1FZfkB1Wih3qBm/l2/vBkfuEyUSQm9rMSb?= =?Windows-1252?Q?c72bQsAIUqCAxEvyV98QFRxv6yBCFKcrAYeyVjl3LRBrrBvf9Q5XNhZQ?= =?Windows-1252?Q?Uwo6rT/6+7KHzK1RiFZEUhFg5qDXRkZVy+Ga1/2dIJTo4/wHdvUvhQG8?= =?Windows-1252?Q?339hygWFBfKTNMsLVjP5akfusDlNrU/ttKZ1J4kyjmP1oqqxdSkzog/8?= =?Windows-1252?Q?YT5Wh+U6zb19/qxgJf9q7DndKWb7hElwhY7i4qwO5zar84wMPnIrJdWt?= =?Windows-1252?Q?edNopB1TsK/nM4i7ktIFXNAln8ABgMp9A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;6:XuMFAhKC1gHH2lnjN5nL/xWGaG1keLcdV+ww6NbqDqZoOSSQDRfeMJDm7zr3o/DEWlKn9PB4R8SkhZRKGihLNYPj/0CU/twZKUMu1z1gBOfsdp6gpivsXV5xnWT/67BzWE126AyDXYr7HpCZadye4uyJThsdTeOa1gLleSygMEEG1whp1Y7Z1ZXlJG9Ty81hgQByVJFuUvYXQ1Nks9AmIExJyb63FJRYLg47TT066T4zSm/HtjhTfUdRf0k0g6M/XtwGhYssfeTLMIqtkye14TLP1cNHmRw6IwhVsijiZIg=;5:UhJL9fNxZADJQMbCiMnuZCGLF6rVwmkCO4R7sqJemu9p0k3woSL15fcXXfUoS2BJTD0ptHdFG3+MNMnpZF8o8SpuI0GUOM6MJYE4QGuIJYtYIeh/0xZvVS0Jpunp8nu21mmko8eZdLZNLk3WDHOc/A==;24:d5VS6gPDjwQn2oIt02SwckuYg2CgrUDJmSsSl3hBz5Z8HOqWFEerwOjhOvdLNN4lgWQQx5I8z+v1qqHhDzajeAVwHW04cgM6tskQR/7Ue1E=;7:P1AYnWuwVMHLhoGyFPeDPgl41163kqeQQcus+axDwQyOhIKJQqKDLBhDtU+aiuDdbs67acLgN4j0FUapUiHwQiU5ahGqpF1J9yxp75mW8mJEKFyw16yVfE57JlK0brsPvjkeT38yE5CBUQkrZ+zmc/d5b45X6BY/8/JDsSCIbjuFyYWN94MOBiqauPKiNuybsXkAsH8wEYbx7biBJbrREngneGceKNSZ9mBPdl17SgRXsWypezMWDmRFScS6kNhX6BKJvC1F2W6VkXkMB3XXHnov4w/bk3N+WsWO9NDYfJkSftCpvv49c0GUft7/Mglw SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;20:99/WM3gEHkE1X49jMg+rEVAMxC084qVt/hZyPAz+P34EWhVxNLNdKcN0wiLm9sUfNu2Ryj4avswrbFz/u8cmB9jvHomqH701CnR+4HXK9NAzOSl2LOE+vcvV/WMJlwjWH1IgQh6sLQRHH/REW84ZgQVgdJBiG/T53Cj9sdgDFeU= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2016 22:07:15.7142 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1185 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-22_10:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/22/2016 04:16 PM, Keith Busch wrote: > On Thu, Sep 22, 2016 at 02:33:36PM -0700, J Freyensee wrote: >> ...and some SSDs don't even support this feature yet, so the number of >> different NVMe devices available to test initially will most likely be >> small (like the Fultondales I have, all I could check is to see if the >> code broke anything if the device did not have this power-save >> feature). >> >> I agree with Jens, makes a lot of sense to start with this feature >> 'off'. >> >> To 'advertise' the feature, maybe make the feature a new selection in >> Kconfig? Example, initially make it "EXPERIMENTAL", and later when >> more devices implement this feature it can be integrated more tightly >> into the NVMe solution and default to on. > > Should we just leave the kernel out of this then? I bet we could script > this feature in user space. That actually might be the sanest approach. Then we can tie it into some generic PM latency setup in the future, from the kernel, when it's available. That way we don't get left with some odd NVMe specific PM sysfs knob that is exposed to userland. -- Jens Axboe