From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932365AbeARRxu (ORCPT ); Thu, 18 Jan 2018 12:53:50 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:56572 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932103AbeARRxr (ORCPT ); Thu, 18 Jan 2018 12:53:47 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20180118175344euoutp0158a359b00852490a4f777dd15fc1a4e3~K_QUbVubM2584725847euoutp01z X-AuditID: cbfec7f2-f793b6d000003243-aa-5a60df267270 Subject: Re: [PATCH] crypto: n2_core: Add empty hash export and import From: Kamil Konieczny To: Herbert Xu Cc: "David S. Miller" , Bartlomiej Zolnierkiewicz , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Message-id: <99689cdf-781f-9e24-7fcd-e810e30c57f2@partner.samsung.com> Date: Thu, 18 Jan 2018 18:53:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset="utf-8" Content-language: en-US Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42LZduzneV31+wlRBk9nMllsnLGe1WLO+RYW i+5XMhb37/1ksri8aw6bA6vHlpU3mTy2HVD16NuyitHj8ya5AJYoLpuU1JzMstQifbsErowr MwoK3nFX/O07zdLA+ISzi5GTQ0LAROL21iOsELaYxIV769m6GLk4hASWMkqsn/GUHcL5zCgx fVYDC0zHpAd/WSESyxglDr+cxwzhPGOUOH5+KVALB4ewgJvE7Z1SIA1sAuYSj7afYQKxRQR0 JFa+XAzWzCywkFHiR/95dpAEL1D9qU87GEFsFgFVia3XroNtExWIkOh6tosVokZQ4sfke2Bx TgF3id8NX8GGMgtoSrz4MokFwhaXaG69CWXLS2xe8xbsOAmBHWxAl25hhnjBRWLFCoiLJASE JV4d38IOYctIXJ7czQLR0M8osfzGKXYIZwrQa9OuQnVYSxw+fpEVYgWfxKRt05lBXpYQ4JXo aBOCKPGQmLngPyOE7Shx7FEjEySIZgHD6+Rs9gmM8rOQfDQLyRezkHwxC8kXCxhZVjGKpJYW 56anFhvrFSfmFpfmpesl5+duYgSmktP/jgOD7+sJq0OMAhyMSjy8GxYnRAmxJpYVV+YeYpTg YFYS4X3nDRTiTUmsrEotyo8vKs1JLT7EKM3BoiTOaxvVFikkkJ5YkpqdmlqQWgSTZeLglGpg NCuROrRy+RMBhbmPNWR8eXUef/hV2Hv/1Jl6Zqf2knzN+257dkxf+OqTYgbHlRWdfhV75PZY 6FhslJyZ9PLEnFrd4OTcyYaV3m87nxcd9nA23ZV6Njz46UzZzGBeGcm23l172s8k93i4rz81 yZtFyiw1vIl3bR/r/9V//j7JO7dT8CX3/dpJSizFGYmGWsxFxYkAkxljDyEDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrALMWRmVeSWpSXmKPExsVy+t/xa7pq9xOiDLb9FbHYOGM9q8Wc8y0s Ft2vZCzu3/vJZHF51xw2B1aPLStvMnlsO6Dq0bdlFaPH501yASxRXDYpqTmZZalF+nYJXBlX ZhQUvOOu+Nt3mqWB8QlnFyMnh4SAicSkB39ZIWwxiQv31rN1MXJxCAksYZT4O/UdK4TzjFHi /5b3TF2MHBzCAm4St3dKgTSwCZhLPNp+hgnEFhHQkVj5cjFYPbPAQkaJSYuPQTXPYZT4+ugl 2ApeoOZTn3YwgtgsAqoSW69dZwGxRQUiJJpmzoWqEZT4MfkeWJxTwF3id8NXsMXMAuoSU6bk goSZBcQlmltvskDY8hKb17xlnsAoOAtJ9yyEjllIOmYh6VjAyLKKUSS1tDg3PbfYSK84Mbe4 NC9dLzk/dxMjMNy3Hfu5BejSd8GHGAU4GJV4eDcsTogSYk0sK67MPcQowcGsJML7zhsoxJuS WFmVWpQfX1Sak1p8iFGag0VJnLd3z+pIIYH0xJLU7NTUgtQimCwTB6dUA+OEpfv22/AtmpvX 9MIs0nfZzz8vHX6HvONcEM4x8dCFh/H2q/9MYXn36fLxr9PbzQViRZcs3C9/k3PTlH6Nx7Z6 yS3rOfonN/x+VpgTmRBufOiq7+XjZZ53L4dPKlc7sfREmUpCVHsbby1TRlMbc0z8z+vnX/tM L1d8oMwcvaBg7fWkuw1fD4QosRRnJBpqMRcVJwIATVH7i3MCAAA= X-CMS-MailID: 20180118175342eucas1p2821faa1cdfef2a0285843a28f09551f2 X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180116161844eucas1p27634e8860ca620b45224fa9efe491e2c X-RootMTR: 20180116161844eucas1p27634e8860ca620b45224fa9efe491e2c References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please drop this as I will resend it as part of patchset. On 16.01.2018 17:18, Kamil Konieczny wrote: > Crypto framework will require async hash export/import, so add empty > functions to prevent OOPS. > > Signed-off-by: Kamil Konieczny > --- > drivers/crypto/n2_core.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/crypto/n2_core.c b/drivers/crypto/n2_core.c > index 662e709812cc..80e9c842aad4 100644 > --- a/drivers/crypto/n2_core.c > +++ b/drivers/crypto/n2_core.c > @@ -359,6 +359,16 @@ static int n2_hash_async_finup(struct ahash_request *req) > return crypto_ahash_finup(&rctx->fallback_req); > } > > +static int n2_hash_async_noimport(struct ahash_request *req, const void *in) > +{ > + return -ENOSYS; > +} > + > +static int n2_hash_async_noexport(struct ahash_request *req, void *out) > +{ > + return -ENOSYS; > +} > + > static int n2_hash_cra_init(struct crypto_tfm *tfm) > { > const char *fallback_driver_name = crypto_tfm_alg_name(tfm); > @@ -1467,6 +1477,8 @@ static int __n2_register_one_ahash(const struct n2_hash_tmpl *tmpl) > ahash->final = n2_hash_async_final; > ahash->finup = n2_hash_async_finup; > ahash->digest = n2_hash_async_digest; > + ahash->export = n2_hash_async_noexport; > + ahash->import = n2_hash_async_noimport; > > halg = &ahash->halg; > halg->digestsize = tmpl->digest_size; > -- Best regards, Kamil Konieczny Samsung R&D Institute Poland