From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CAF1309F1D for ; Fri, 3 Jul 2026 08:18:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783066706; cv=none; b=KUwHVLzUJgQApfc0vdBeJqlsq/0CYfgUPJkmp8wBygCceb1ZlIP58d1p1kIYpIQSRHaTgDxVJ6iiNOKHDLy2p1ThydVStoYV8FJpVhWrL4WVpORFjmdpFFfc/zY6zIeL4UypoR5xd0xV7tJDAoSf1irHViHyMxocDsnFfqmUH/8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783066706; c=relaxed/simple; bh=X7A2d8nw06smgyIcTq9KpSNNtCB1qTjlb0Lz/P935uw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a9d9UGQ2OIAOfpas6muAKMNv8vhp4ND2yuylciJfcYv0cejlNDRoFe5ln91ixsbZs8nXCvlQSNVWFqQMIgjwjohyp6qdn5szppdZSFx4Hy301rRUVMkMvIPau2JmF0TNUpDVV5jBvrQEp86eon8x7RmJ8EdvGIDBJxycLN8YIuI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CZAkf10s; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KqQRdGYc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CZAkf10s"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KqQRdGYc" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6637IVxP3195235 for ; Fri, 3 Jul 2026 08:18:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yHznjqxcH8V5jOn4X+unmnLf9eh1cHDxSeH30hTY1dU=; b=CZAkf10sVKZ+Z5It TiO0mQoDevx3Rhg54OrCNL1N+ozBkP9FH/slp89WHvQSsEq7DcyJPp+3imxnfm8y PaoLWfGsaocaQEXd4AnUZD/4sPMLMk6tX0POejoffawL1mYG3hk9IYMmwyN3lDCv Rz4YRz55iSURxWmjSE5JO57fQ4/JQbHN7yHwE/8DozGSROFGVX2FOP02Wv29AY/n qirXwrLFrDzgawSuwiL4ZI3R5qR0DDrw0TtmAvz4Pq0zlrlI9rVL+Iw69F/o0uLh LZICJLQMOsqvl4WBWZD4tvlelnoGytXTR46G5IfixDRLg0u5jvebUHtNeLYR+mTX bx8K3g== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f68jyr73e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 08:18:24 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c98136ceff4so610958a12.2 for ; Fri, 03 Jul 2026 01:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783066704; x=1783671504; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yHznjqxcH8V5jOn4X+unmnLf9eh1cHDxSeH30hTY1dU=; b=KqQRdGYcXY8seHqrd9YjwbAW5LqBHF9+QjtjOc02sU2ar8D353jqCkk/QTyLO4WovL pRBNHUqcVLBeGJYJrXd2rKaJdE95tZ5MgjNgVT3zhcXfc9pUGvsaxEqvuZdwrwtZ8JIg FxOlh3ZslSvDgJTmd414di7siOYSIQY5PqUQQ77m3OMFIk48DfQrYJemmtFC3W1twyts pfCJ9ScLR9puEHjOpMmnmrxQJJnHvtTJRO/nYuCqc8y0JS+9N90vwYMnMfhYRNdzVWDg SEVDd0DyHsvzTubwMR7T/5tynNxtddDyxJbi4TScBT5UsEvricjLVEemqSLMc2DSj4E5 hCpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783066704; x=1783671504; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yHznjqxcH8V5jOn4X+unmnLf9eh1cHDxSeH30hTY1dU=; b=ZJNhU9T9p58VnqUD0b9fvVT2EyvXyK3ZHrTanyp8vVwtAHrvHpT96d67mavj4MZ051 bi26ydgBm7ruJ4hj+ge8ikwrr3MEQ/OMVZCchmltV5kPvKgtRlkUljcI/LbzQ+vPXOyd r/Cn55DBicC+3miXwatoqSjlTGFVTd+nNHj1HJcPqjYBEw8vas4IYhVPGIzmLLhLXiUp VJiIy7zVKYbI0TpNuafXf8pphPNMmBkreJpk/NI88fqkZ+MVuzjrtfsiUcYZxWIjZ3y8 VBszYu6pNrl7TimHqEeoMkYUbAC+NCIbryYjTiWH6toXf+p1bfYIYaxoVAQKJ46lj3UW OeZQ== X-Forwarded-Encrypted: i=1; AFNElJ+Syfdn1GE5suz3BB4mope1LV1DVAdgHzBqTPGUSxObuUE4dQyIOfuomA6Wr8+O6u7ITdsEapAz8vJQ/aA=@vger.kernel.org X-Gm-Message-State: AOJu0YzptfYzjx4G8JFG3o94raBs3G6CAoBG8zdXE9AnRYwqF16bWlT4 3WQjQR+aVODAt9/20+PN0bT4dVhNvy6p667jrr7Jj+8z+DlLX4gJX9rCXjTrpuhw/yA802DnjZ/ qVAGcQ3cOauAHUagxgwnRq4yeo/rnvLXG2/QVR79OwHyP6dBwOnalIBkGZJpiuvjiNdc= X-Gm-Gg: AfdE7cnGs8jZ693P4Uut/qWzUELwZBsRG6qPWGC9R0okzLtipnTLDZsd9vTq38am9n5 JbbkS7U6tk4OB9fgsHo+0Y8LI0m/gU2pniBrOHH3zPjRukj2v/C4KiUQfxl2ccrL/r5nhyOm+w7 uFSmhIHg5DT0BHlDCWyzASSXlDREqEMWYEJBeMJErc13ajCzdf8f0hJV3PqjrmbfnlIY900/dS4 3jgBEOdTDVtes2Y0RPAK6yJaIsJqTxViBWe2ksA2MJiVEscoVdTUbR8+QZRuknfwLUjW1UeQv/7 /E/nL3jFK1KNIiMKj8Is2s+3rT5dTx2CS71ktmFR6uct2unmhkx2ktGSHmM2kK0C0qQAK14kJuS PbeBOdk6nAgkKuDUJY/NVA5mTFRnJEvHUgy9rUaVe X-Received: by 2002:a05:6a21:9f07:b0:3bf:6c08:2847 with SMTP id adf61e73a8af0-3bff42f825bmr10946885637.54.1783066704021; Fri, 03 Jul 2026 01:18:24 -0700 (PDT) X-Received: by 2002:a05:6a21:9f07:b0:3bf:6c08:2847 with SMTP id adf61e73a8af0-3bff42f825bmr10946858637.54.1783066703563; Fri, 03 Jul 2026 01:18:23 -0700 (PDT) Received: from [10.217.198.242] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b3c870effsm21148189c88.12.2026.07.03.01.18.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2026 01:18:23 -0700 (PDT) Message-ID: <996d66e3-76a3-4d12-9e79-8dfe3e96137d@oss.qualcomm.com> Date: Fri, 3 Jul 2026 13:48:17 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/8] irqchip/qcom-pdc: restructure version support To: Thomas Gleixner , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Sneh Mankad References: <20260616-hamoa_pdc_v3-v3-0-4d8e1504ea75@oss.qualcomm.com> <20260616-hamoa_pdc_v3-v3-1-4d8e1504ea75@oss.qualcomm.com> <87mrwcqejt.ffs@fw13> Content-Language: en-US From: "Maulik Shah (mkshah)" In-Reply-To: <87mrwcqejt.ffs@fw13> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDA3OCBTYWx0ZWRfX0wW97AA96bmR JpPm9wA27mfbMs/xNlUQzWGt6kctlO4SHsQ74uPMloCW7b0+sPPCdAVr9m1qyittAzV3qT6KUCT oeS0KD1/7WTw/oCLrQ4jM6xvChmKepnR4w0DrqeVlxMXQu7dyvwcCS7b5lz9Bt6HrJAgF/JZcCp l0zuJRnPMv21GdgtLRVIIEysq1JkYej96T+LwVsvDM3lJ+qCBfOt6jgP9vMKU284QiBQpIu+/qx FrnlzbeSGOMurzdBW/OAVwfalU39j5gzSBgJNPMCvLDNk+nuUOqz3a5YJ99EdNbRQkya0ifsBtk 9x6ZgSbUSfi45/iPZG6dLa79oxfrNYZrYMhqed/uybXaNFbt2cc5gU5OxVO51rW5D7PXD2CVkij HcnAgshqBao6nMmDflW+30fA1vLsHb0hKUWW4t6gox0E1AOwu1LkqjRn4EYEGFaJ97UKlTLeb9M Gj0rdEAxsHkcuXKKKDg== X-Proofpoint-GUID: IRCkT27Y_gcmGYB_KrhQzxdyqav_cjvk X-Authority-Analysis: v=2.4 cv=QbFWeMbv c=1 sm=1 tr=0 ts=6a477050 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=xxOP1YzqUXX0Hlv9yD0A:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-ORIG-GUID: IRCkT27Y_gcmGYB_KrhQzxdyqav_cjvk X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDA3OCBTYWx0ZWRfX5z1zHiDIy5HU XnNTOHQJETHY1YohBRrzoWdIvbyrTeyGGsayFO59sHHzBlaOqUAl2KkX5AT9uYwABJMTx0HdHBQ Ib9j+w8e/O11fwolZ135r7o3eeNbP2w= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_02,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0 clxscore=1015 bulkscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030078 On 6/30/2026 8:08 PM, Thomas Gleixner wrote: > On Tue, Jun 16 2026 at 14:55, Maulik Shah wrote: >> @@ -336,7 +418,8 @@ static int pdc_setup_pin_mapping(struct device_node *np) >> return -EINVAL; >> >> pdc_region_cnt = n / 3; >> - pdc_region = kzalloc_objs(*pdc_region, pdc_region_cnt); >> + pdc_region = devm_kcalloc(dev, pdc_region_cnt, sizeof(*pdc_region), >> + GFP_KERNEL); > > No line break required. You have 100 characters > > Other than that nit, this looks sane now. Sure. I will update in v4. Thanks, Maulik