From: Krzysztof Kozlowski <krzk@kernel.org>
To: Arpit Saini <arpit.saini@oss.qualcomm.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
devicetree@vger.kernel.org, rajeevny@qti.qualcomm.com
Subject: Re: [PATCH 1/2] dt-bindings: display: panel: add optional wled-supply
Date: Thu, 1 Oct 2026 08:57:52 +0200 [thread overview]
Message-ID: <997cefa0-384c-466f-b318-077939946768@kernel.org> (raw)
In-Reply-To: <20261001-private-wooden-chachalaca-51aa57@quoll>
On 01/10/2026 08:55, Krzysztof Kozlowski wrote:
> On Tue, Sep 29, 2026 at 06:42:20PM +0530, Arpit Saini wrote:
>> Some boards drive the ILI7807S panel's backlight from an external
>> WLED driver whose enable input is wired to a GPIO, typically modeled
>> as a fixed regulator (e.g. vreg_wled).
>
> You describe something else. What's fixed regulator should not matter
> here. Which pin is it in ILI7807S?
>
> It seems you just want to represent GPIO with a regulator. This is just
> confusing and typical downstream workaround.
What's more, you basically REVERT the review YOU RECEIVED in v1. Really,
just sneak the same stuff 3 months after like the review never happened.
NAK
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-01 6:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 13:12 [PATCH 0/2] drm/panel: add WLED supply support Arpit Saini
2026-09-29 13:12 ` [PATCH 1/2] dt-bindings: display: panel: add optional wled-supply Arpit Saini
2026-10-01 6:55 ` Krzysztof Kozlowski
2026-10-01 6:57 ` Krzysztof Kozlowski [this message]
2026-10-01 9:55 ` Dmitry Baryshkov
2026-10-01 18:09 ` Arpit Saini
2026-10-02 8:22 ` Neil Armstrong
2026-09-29 13:12 ` [PATCH 2/2] drm/panel: ili7807s: Add WLED supply Arpit Saini
2026-10-01 7:01 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=997cefa0-384c-466f-b318-077939946768@kernel.org \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=arpit.saini@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rajeevny@qti.qualcomm.com \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®