From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f228.google.com (mail-oi1-f228.google.com [209.85.167.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DBDD3E929D for ; Mon, 16 Mar 2026 19:54:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.228 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773690893; cv=none; b=Nt19s6AVjDqO2FNjQeHcOPJWMcDUduz9sZUKawvT1DfzxqPCgNGO20oVR+GrsbS2q1p72/OExfg7By3jmcr0OlyHBX1wF0LtDHDzu7Wxdzf/on4oqtPV0+9N3SWc2lZtSz7HlLgn+EVHoCF/qugDuq6Re+emXTkCMRtMET1xDsY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773690893; c=relaxed/simple; bh=VNC4IJKud+73KOf230kzDqFIXdI6+MPx4jgJ2TcM77I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CBlHolaAKAXcYTI1+FaJUgClDpSxytoAgYRatim1yKIcaMkv5ln/wNT06MKFZ4773GhbcgzLt2osy0P+BDSgJOi2EaeodN5yRk84RbkWtYfGkqB6qJc7Z5pkRJfRt9ljvxDsFudkQGIbymlvSLnHHF569f+lvR2IANH9gzUu3s4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=c+JSDY+G; arc=none smtp.client-ip=209.85.167.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="c+JSDY+G" Received: by mail-oi1-f228.google.com with SMTP id 5614622812f47-46704177508so3180027b6e.0 for ; Mon, 16 Mar 2026 12:54:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773690891; x=1774295691; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9IDaJ6oXa0HJPHD2SrYVZIn4JOWUZueJBTKzvHn9pvs=; b=RZXSWcQx0OQBtgluZ28MnI52JCC+fneCaGh/71R+V+8O0aH3O4inWFvMQuVCAwKUkq HQUnXBjG6ExLw2Y6C6Sex83NJ9k1L9XWDnJcliDc8O886NJZyFb2FsBNuTsrA/VaoGAx 1rtKRsgurJgPQyUZXrJwo9FgtlIdEKTB7SyYt/HrWEF0QAOHBzJNTOW3PjbsW2jg+8Cq zUrnWCs/my6q3zZZWI8sDxhMPRZn7df+KTQPqG9UFuBrOpQOslxDGGQq0+9pVxyljkMF DPY77guBER+0b6QaSRW3exCD5kvJuuMMyXI8Dy49HG1jkLdZckICVN23Xj+S3SGAHEUJ XgJg== X-Forwarded-Encrypted: i=1; AJvYcCUun/CQlUHjwLo+FSbSY4yfdUMMmCxaFRjxEtz95xQIH76RPAbWgYxCEYYJ13UHXkPkU6VdY8OlMw26S2M=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5lcfD0eJBPHvOrSyGaV+kSHZ3J0QYVKH5Tc1rTF+yV/1Xjpo9 dUTSbQo115Symq9TFkqCSH4fhBH7/hj5/PRprqDgHhJ/pn/zNj1Kzr3E3bgbFnqmhWRg90TQMAt xT7+KIFVx/gwabZgc41adGG2mJ4AeP3iYEEHFMPVmmFBIZIlTmPWvNWU3/ip1wdqXKPSeCUf54L vhelBfOm0JCdWXgMAlwNBiDQzS2IOBRi2kUjmIXb2xQEIeeftOkjU8WqImznPGyTaShWy+ol6el VHEwNY1RiKI0Og2p7Te8jXC X-Gm-Gg: ATEYQzzcMFae+VfAbrxserO6Qyb3sgyQiLKHpDHqNN0xfDMLSJdFpk+q2Ne8gxP5mDY 5b7UIPJSS+q9pLpAOg9ZZfEoIN1XMeR5gDl6yk9GPGlYiCqFn95unBCg8CHWBj5eWOU6bVaG6Ra +6gI11YV9Vu2/jEqSRLuUfSf9QA4fY7XQe80tVnxxmNxq0TBscD4FJt5FduSqtiR+jeJOn/xJkj lgLfvgz/Yef3yNxhR+yAYbUFR6YtjrGF4KRYfJueflsoz7UHfBA6pgSwfenjSNwcSTJBTC4Ontn HanFhYCc9mSSziIRWz1VWvvOS4vLoX7l8iOdYPySew7/XjB9oSmrrwBLyvxLNXVqVE6XEnDcunP nb9rs1ioRFQ+WEYBYSUvcdlkYF+6IhW9Ky1cNGR/+eP9Z8bZEEkI6cW6jybe/lJiw7oA7ns4aLN 3bEawiABb6+AxbzClqPnhPlxA0M4Q2fy7u2OZ/ZZk7wiTGIuPLMYWSZzg+mjOG7Q== X-Received: by 2002:a05:6808:470b:b0:45f:a12:5c88 with SMTP id 5614622812f47-4675766c8c1mr7725904b6e.49.1773690891142; Mon, 16 Mar 2026 12:54:51 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-22.dlp.protect.broadcom.com. [144.49.247.22]) by smtp-relay.gmail.com with ESMTPS id 586e51a60fabf-4177e653f05sm2712542fac.15.2026.03.16.12.54.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Mar 2026 12:54:51 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-89c53a0264cso85887326d6.0 for ; Mon, 16 Mar 2026 12:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1773690889; x=1774295689; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=9IDaJ6oXa0HJPHD2SrYVZIn4JOWUZueJBTKzvHn9pvs=; b=c+JSDY+G+pasR42rwu/CmtSsl4A+h7yMkTBlbLrok1p/lvniB0Cu5jDZc1f8RR53YN guK+cCgbCWxe+T6QD5UHnwi9vLsegc4IMwUHSv6flWa2Vq/mOhbk4QtsK+uhkY+H9Yzl nQycr86WP5bQJw/RQzNcsbrrHKuBuOe9lNruc= X-Forwarded-Encrypted: i=1; AJvYcCXkk6b2Bir9gZyhBuNEoSngCCdOqvcSmFTkwN9CL4LgjrFmek9DSlPTLB0JFpckSWC6MtdiK2tcM/UvzWw=@vger.kernel.org X-Received: by 2002:a05:6214:2525:b0:89c:53a0:1c97 with SMTP id 6a1803df08f44-89c53a026f8mr63142346d6.11.1773690889506; Mon, 16 Mar 2026 12:54:49 -0700 (PDT) X-Received: by 2002:a05:6214:2525:b0:89c:53a0:1c97 with SMTP id 6a1803df08f44-89c53a026f8mr63141786d6.11.1773690888886; Mon, 16 Mar 2026 12:54:48 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89c4c018f5esm37577006d6.45.2026.03.16.12.54.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 12:54:48 -0700 (PDT) Message-ID: <997daf22-260b-40c4-a2d6-8c63f59df9a7@broadcom.com> Date: Mon, 16 Mar 2026 12:54:46 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net: bcmgenet: enable EEE TX LPI by default To: Nicolai Buchwitz , Doug Berger , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260303160225.542613-1-nb@tipi-net.de> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20260303160225.542613-1-nb@tipi-net.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 3/3/26 08:02, Nicolai Buchwitz wrote: > GENET never initializes priv->eee.eee_enabled or > priv->eee.tx_lpi_enabled to true, so the link-change callback in > bcmgenet_mac_config() always calls bcmgenet_eee_enable_set() with > enable=false. The result is that EEE is negotiated at the PHY level > but the MAC never enters Low Power Idle, wasting the power savings > that EEE is designed to provide. > > Users can work around this with 'ethtool --set-eee eth0 eee on tx-lpi > on tx-timer 250', but the MAC should enable TX LPI out of the box when > the hardware supports it, consistent with how phylink-managed MACs > behave (phylink calls phy_support_eee() which sets eee_enabled=true and > tx_lpi_enabled=true by default). > > Initialize EEE software state during bcmgenet_open() on GENET v2+ so > that the link-change path activates EEE in hardware once the PHY > negotiates it. Use an LPI timer of 250 us, matching the default used > by other MAC drivers (mvneta, mvpp2). > > Signed-off-by: Nicolai Buchwitz Reviewed-by: Florian Fainelli -- Florian