From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7509DC3A589 for ; Tue, 20 Aug 2019 14:11:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5530222DD3 for ; Tue, 20 Aug 2019 14:11:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730199AbfHTOLz (ORCPT ); Tue, 20 Aug 2019 10:11:55 -0400 Received: from out30-42.freemail.mail.aliyun.com ([115.124.30.42]:59739 "EHLO out30-42.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728248AbfHTOLu (ORCPT ); Tue, 20 Aug 2019 10:11:50 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07486;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=39;SR=0;TI=SMTPD_---0Ta-t.lc_1566310288; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0Ta-t.lc_1566310288) by smtp.aliyun-inc.com(127.0.0.1); Tue, 20 Aug 2019 22:11:31 +0800 Subject: Re: [PATCH 01/14] mm/lru: move pgdat lru_lock into lruvec To: Matthew Wilcox Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Mel Gorman , Tejun Heo , Johannes Weiner , Michal Hocko , Vladimir Davydov , Vlastimil Babka , Dan Williams , Oscar Salvador , Wei Yang , Pavel Tatashin , Arun KS , Qian Cai , Andrey Ryabinin , "Kirill A. Shutemov" , Hugh Dickins , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrea Arcangeli , "Aneesh Kumar K.V" , David Rientjes , Souptick Joarder , swkhack , "Potyra, Stefan" , Mike Rapoport , Alexander Duyck , Stephen Rothwell , Colin Ian King , Jason Gunthorpe , Mauro Carvalho Chehab , Peng Fan , Ira Weiny , Kirill Tkhai , Daniel Jordan , Yafang Shao , Yang Shi References: <1566294517-86418-1-git-send-email-alex.shi@linux.alibaba.com> <1566294517-86418-2-git-send-email-alex.shi@linux.alibaba.com> <20190820134032.GA24642@bombadil.infradead.org> From: Alex Shi Message-ID: <9980292a-a073-201c-ae06-c8cdbc9f98af@linux.alibaba.com> Date: Tue, 20 Aug 2019 22:11:28 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190820134032.GA24642@bombadil.infradead.org> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2019/8/20 ÏÂÎç9:40, Matthew Wilcox дµÀ: > On Tue, Aug 20, 2019 at 05:48:24PM +0800, Alex Shi wrote: >> +++ b/include/linux/mmzone.h >> @@ -295,6 +295,9 @@ struct zone_reclaim_stat { >> >> struct lruvec { >> struct list_head lists[NR_LRU_LISTS]; >> + /* move lru_lock to per lruvec for memcg */ >> + spinlock_t lru_lock; > > This comment makes no sense outside the context of this patch. > Right, Thanks for point out this. will remove it in v2. Thanks Alex