From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF04519CCFC for ; Tue, 1 Oct 2024 09:20:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727774457; cv=none; b=agO/NHQsdNU2/9GUxJXwEN452AsAxg9fLv17pZvNMEHoVokBY3T4NR9zNY5EeB2DEI2xngiAzoNJiws/6dTvJqDFOul6aExozMGXR8gQZQa3Hj6ITJRb8SFGt32k/kqNPSvuik1UpoTOemU7IRIRFB1+qq1DpbaJVTUj29l73vs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727774457; c=relaxed/simple; bh=52IMNoGjtf99CyRrdB3LZ+pHd2q6WDHjEC/EO7H4MgE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KXyG/qCzE+iSaIgN+TkZOIglkQdMDX+td0V9c/CbMHOeviFLF/j4GujMDPJYSHDU3rWgIymMPEThDoPV3Tp1cwZqcEqUXlCNxMrVZT9E1HJqjcYQBw8AZDPp918253RbdVEoY/uNv69o0f2dcy9C6yNjDwnUihGPmIrgUS+WrV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AUFEUynd; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AUFEUynd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727774454; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2Z6bQqCmFRAYWIokTtq6KZjfUYmd4+jPRAYrukjBoAQ=; b=AUFEUyndFj+em2B0D79/kDVsM+FOYi1DUwJSJF7udOD5/lF8JCvQfIbLV6FYxrNbLAlaz7 TlGK6vcCxKnv01KnsL/JBAap4oe2G6CHaMif/LaItSuTqkyHaoGXEN33Y45rnJ6wdn+egd AOIVq8EWUAEh3gCh0AsLWT4lSTCjte0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-Y3HB8KGhMoWz6X0S7ULQaQ-1; Tue, 01 Oct 2024 05:20:53 -0400 X-MC-Unique: Y3HB8KGhMoWz6X0S7ULQaQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-42cb374f0cdso28662195e9.0 for ; Tue, 01 Oct 2024 02:20:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727774452; x=1728379252; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2Z6bQqCmFRAYWIokTtq6KZjfUYmd4+jPRAYrukjBoAQ=; b=Q6gZsN/zARxSYu5BW/G1GoHja3d5W6+oC3oNYY5iOEopbPfswOzYCGZ4I4DptAf4K/ 13D2kacLHh2onMAI1GPkKjR1eBd8+3blL/FwnlW34PZFLgGyCel2aDZXMQrLOUCFJNgT 2R6Tnz1Iis2KzoE+oWpxguOxRi2YxVvZ6mvGGEbrfftnl832o8PKMpP2wE8mpCVxoncc 5O2Mobk78SEqHq4v2SrVNgC7A4+5kJvTUSx4SAAdMcQRM41gE0bphrp4QS6SwMQrgvIt v9diV8EE/zJc8BPpWh9FwDivaxJqX+5EU6tLusP6c3M8OWQUfvI+yirF32ATLadcLv8T mCTw== X-Forwarded-Encrypted: i=1; AJvYcCXLcrMPYe6huVeoEqO5XbiQ3bsvvEcKReDLIzTnwz77gsPR0lKfYO4pIf9K9WiPQPMawiPyxttMIRD5yw4=@vger.kernel.org X-Gm-Message-State: AOJu0YzQ4CJdy8I1XmEkJ3/GnBntx27sCjhpQuQgYORAbhrQVlwN5DnW kIJScT743xQvCgJehDG9eB2erOB9NiyqBMhGdRXP3cvNWwVvK9W9Vx7aAHslD9yRxy8Shb4DYHP 5T81L+JN0LatiXqn2zHIiMrq/7VGmC/qpdcDc22ii1HXBuwXMcjmj5UGK0TC4QA== X-Received: by 2002:a05:600c:4754:b0:424:a7f1:ba2 with SMTP id 5b1f17b1804b1-42f71385a8dmr13033925e9.17.1727774452491; Tue, 01 Oct 2024 02:20:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHOJV5mOCGH2U7gQYy/ih7+a9WULHZSwtnUxNtta7gzvyhknzvDfxI3Q/tjNxWfZohulqwtaw== X-Received: by 2002:a05:600c:4754:b0:424:a7f1:ba2 with SMTP id 5b1f17b1804b1-42f71385a8dmr13033765e9.17.1727774452086; Tue, 01 Oct 2024 02:20:52 -0700 (PDT) Received: from ?IPV6:2a0d:3341:b088:b810:c085:e1b4:9ce7:bb1c? ([2a0d:3341:b088:b810:c085:e1b4:9ce7:bb1c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f57d31283sm128091585e9.0.2024.10.01.02.20.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Oct 2024 02:20:51 -0700 (PDT) Message-ID: <998a4b7e-8d29-4702-87fb-726117369240@redhat.com> Date: Tue, 1 Oct 2024 11:20:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net 1/2] net: fec: Restart PPS after link state change To: =?UTF-8?B?Q3PDs2vDoXMgQmVuY2U=?= , Wei Fang , Frank Li Cc: Shenwei Wang , Clark Wang , Eric Dumazet , Jakub Kicinski , Richard Cochran , "David S. Miller" , "imx@lists.linux.dev" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20240924093705.2897329-1-csokas.bence@prolan.hu> <6be53466-fd53-44e9-b83a-b714737865dc@prolan.hu> Content-Language: en-US From: Paolo Abeni In-Reply-To: <6be53466-fd53-44e9-b83a-b714737865dc@prolan.hu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 9/30/24 10:20, Csókás Bence wrote: > On 2024. 09. 25. 6:37, Wei Fang wrote: >>> +/* Restore PTP functionality after a reset */ void >>> +fec_ptp_restore_state(struct fec_enet_private *fep) { >>> + unsigned long flags; >>> + >>> + spin_lock_irqsave(&fep->tmreg_lock, flags); >>> + >>> + /* Reset turned it off, so adjust our status flag */ >>> + fep->pps_enable = 0; >>> + >>> + spin_unlock_irqrestore(&fep->tmreg_lock, flags); >>> + >>> + /* Restart PPS if needed */ >>> + if (fep->ptp_saved_state.pps_enable) { >> >> It's better to put " fep->pps_enable = 0" here so that it does >> not need to be set when PPS is disabled. > > It doesn't hurt to set it to 0 when it's already 0, and it saves us > having to unlock separately in the if {} and else blocks. Plus, after > reset, PPS will be turned off unconditionally, since the actual HW gets > reset. I agree with Csókás, the proposed code looks simpler and more readable. I'm applying this. Thanks! Paolo