From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9932536CE1C for ; Thu, 11 Jun 2026 07:51:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781164266; cv=none; b=X/gRC3KkmfD1wy/EvLCguypPYaqCkygnPmxNk/Pa28qUVJrai2r8BGgu1QHWJDyXUpZCNxXV7MHY5cQtsU+jYnNVNstYron5h9eDjVUm9H9IM6QZoVZLRtiwa7vXvidg4JCI4+uqFG51CjrnXpUu/yGzQ79SsqY4BfyHyO/3KPA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781164266; c=relaxed/simple; bh=lfCX3uZP1EXZuVBT8IvLBFuruNNYFrUfs6D6xRBa/u8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iZZzzzrmLwbnrcoCdxu1o5ER+iCO2mLygl0IlzFdwSoBviqinkM4hJKEOKaEgoiy7B7zKRfW5nxs4UVYRaEw3RyJYmvsCUj8AcVbqyZveDetOF60cuEw91lEd2GBfAWHt34fGuBEkqaukQM779gdWm9jLLDNvO3Ti7OLlfDwBDc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OiQWMt0h; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dUwHt/4/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OiQWMt0h"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dUwHt/4/" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65B5GJE92247966 for ; Thu, 11 Jun 2026 07:51:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= p/X20Z2CefrI8yMv/8IpDBoqq2Hb9n39SsxgdwnIVWs=; b=OiQWMt0hPdkUmBxQ L0B8ZhmcJtjmI1w/TbShYSDVRgrpWZW3o6vafFjuE0HHB5d4eg5YBL1PKWZ1XKSv WWrAqqtcYVONSwYsxy1VvU1LPnHiBq99pR5mSGX1Wbg85GFooHwCicTtMacQLlcv qt66nVW97zM7XKl+3Dk3SCZDAyFw41fA9+BUTWUODQ4ubac9aHSme6wwEegIU9td 7JZObfCtWbHxPom/sUnpVg69aTqAmJ1cOwAnqfZ+7G41+pav2BuqsyD5Fgg1ZDiY LJQA2KS62PW3HlNLh3TUU0UdaM3hib3nSeF2Hsx2TmMeCFGAtp081s4WBYRsB32l vO0VRw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eqe79j8gj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 11 Jun 2026 07:51:04 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-5177b12d7bbso14245381cf.1 for ; Thu, 11 Jun 2026 00:51:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781164264; x=1781769064; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=p/X20Z2CefrI8yMv/8IpDBoqq2Hb9n39SsxgdwnIVWs=; b=dUwHt/4/R2SLS7/ZPz2bMnM+Hky8G0+BgVCwVXRYOz/9wXrY0KY+2ka7LZdtpqgpQK l/7OL3Zniz6N7i7+ldV6h3NTHbeDCseJyVJQXyJhBtl03iYDRqwz9P5GVYtYbV4WvPA7 f1ip6OMtpRBN4qXfzyylDfqSZ/31bQv6WREDpoCoJjD7sSru4xWyoCDJdcyETnqVdYyI x6jytSOeS/hHaITMFRyz6xS1khnksBEV6BxQO3RRuhlS9WIf1Y/KEo4yfGYUtUR2u958 Gu9+X3ZQcX9X0gag1YfowremJmDCrR/sPMD0kwrbYha18+ZXTUvEjJIRc1PHIgnT5FkR eDgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781164264; x=1781769064; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p/X20Z2CefrI8yMv/8IpDBoqq2Hb9n39SsxgdwnIVWs=; b=I6ozvr/aIp72lk/MUtepd72xn9TqtZKdkNqOvma8BT3mXqSPYBt8dSDU9/kZZzqx1u A9tphbQfgg6gNmOHh/t7oiA0gyyVU4PtN6ws7/OlMT/c8PhQ7Kag6LIAAsHQZcjdeh44 7vQDb/GP9KfMOu0hG6Pye6/ayOfaaCFH9FvVSOcd+GjUqyLNH3l/0YnIQbVb4QjAnH2N WpFc4Zy6w/xKnAS8a8Qo2Pc0FwP1/KI2xZf93pRvSWgDrFskrxjCprz2PLMoKedSN4pe 69JC4gRYy3PhRS3FxjGEmtFM5sOAcnh8QzSzDDy/wB+nRKgg0CUdcqJ2FGjldIEl0xeH KIbw== X-Forwarded-Encrypted: i=1; AFNElJ8wKHYUvtoUKg16I+86NxqAnxowvwPHLnWHQ4uEF2pwIxVzgFodOqq4ZnO5U7wZ8vwSZyO014JBaWyXpxg=@vger.kernel.org X-Gm-Message-State: AOJu0YyUrc0JlhJGHPquKSzUM+vsGQEd/zxptX/qUGowodPzb8Kr/I0s mzr+teBRkpT42iMx6mh2JIAcxRsbSr6WrlLUnmb1tA8jjfKdPUct4EFaIGVIQn0CrQ0yPlBqalv f72uWMgpobL7B48MsKl8Tz9Sc7TgBjKU170OrGUWTCwR0HWdNaudDXxbjeK8yx2hn8jE= X-Gm-Gg: Acq92OECEIsqr9ZecWtdBASKMceQyli6/kN5xFgU2Vxy+V2Oi3AO1N+YUdSeFXC6QcA Udm4+Uy+NUdO0CPJ9i9D2eVr+i3U5w1WJNSi6UVhCBjygR7zTLQZ50BVI8jv98N2ABjeTBBgivx KwvUasIT0cNJlAGIejNgnjpQ1neIzMgSAKph3rbDQuDoRB9aTGCtjSQTOx8qhC8f1hrFDnODSyv zZovAd78tN1Z5we4KBjcx4sgKzAkFCcdAHvG6pXwZaqCiUBC50/ZHFVOfcYiisTvELMN7riXRFj 53JHq904sMLadN1r5jGUTKSLhEGtYkk6iRxXAHay02Fte+Xwe7AtBbk3O/8+y184gp8Rrz1GZz1 iSOJoYKp6IXCp2W99vuEk2bAmCTW1H0r8D7+JKE63jaDYsseULztzqDkM X-Received: by 2002:a05:622a:c16:b0:510:144a:636 with SMTP id d75a77b69052e-517ee281cf9mr17195361cf.8.1781164263956; Thu, 11 Jun 2026 00:51:03 -0700 (PDT) X-Received: by 2002:a05:622a:c16:b0:510:144a:636 with SMTP id d75a77b69052e-517ee281cf9mr17195171cf.8.1781164263570; Thu, 11 Jun 2026 00:51:03 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfcb6a6cc97sm23272366b.63.2026.06.11.00.51.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 00:51:02 -0700 (PDT) Message-ID: <998b673a-9754-4bdd-a305-73824a8f8060@oss.qualcomm.com> Date: Thu, 11 Jun 2026 09:51:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] drm/msm/mdp4: keep the bus clock enabled while a CRTC is active To: contact@alex-min.fr, Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20260611-mainline-fix-mdp4-blue-screen-sending-v1-v1-0-22925600e4f2@alex-min.fr> <20260611-mainline-fix-mdp4-blue-screen-sending-v1-v1-1-22925600e4f2@alex-min.fr> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260611-mainline-fix-mdp4-blue-screen-sending-v1-v1-1-22925600e4f2@alex-min.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: NJuGo1IK3d9Ibk5mO2ZI048obLVyS4IW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjExMDA3NiBTYWx0ZWRfXzb1W7ttyk4KI TO+HB7Prq3IJRWwxmJLsofmY4V5hu8ivPk6MfvfnZB6xklACc8D5lWLaJ2ti4vtgYPcFh//ZziK +1d7ZKlGN0SyJJvoz1F8DFf/deWodSgov/JU0RvuZ2HkwcbTOqH22KUEJJ6iTFJEFkc9+LZlKBm aOyius6svvQ3biqW+8mPNJhsGZ7Hg0W3vETUE6ahG2gANjexvKE3JHJVrf7oOeW5SjjcFOfmso/ 1rOasoT+NsCsvqUpmLP+rgJU7GrbDH9kjC2mkcEFk4r+No0xRZCkYiiuCoDNWOihE4PXH6w+3Si R/rJ00q+jcuZwndDZDsBqnSio3Mv6V6N02ClsBcYC1QBXolruGkWTyayTZY6UKOS3LkJQeusCZN e36a3Tj6TPjLVqfVvx52GUftFHQGvGswjkO/I01VAVs7CXRNAPDwPKIS4ei+DVJq+KjuzwiQz1n fPQLz8j1/1w4vtRp/Jw== X-Proofpoint-GUID: NJuGo1IK3d9Ibk5mO2ZI048obLVyS4IW X-Authority-Analysis: v=2.4 cv=fbydDUQF c=1 sm=1 tr=0 ts=6a2a68e9 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=qYPBgzPrCaqp2f--smQA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjExMDA3NiBTYWx0ZWRfX21DoUYbgucrN fOPc1yIJoQtq6HjutpmReoOPJeg2wXh5gz3JywUgu6fwWTEojbMAaE//MnZVVv5ZcSCWSgMgT5V 4inlyA/zg21B4JRFq/whhCO5GNpoR4g= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_01,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 suspectscore=0 spamscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606110076 On 6/11/26 8:07 AM, Alexandre MINETTE via B4 Relay wrote: > From: Alexandre MINETTE > > MDP4 scanout continues to fetch framebuffer data while the CRTC is > active. Keep the AXI/bus clock enabled for the lifetime of each active > CRTC so that temporary MDP4 disable paths do not gate the bus clock > while scanout is still running. > > This avoids display corruption seen on the Samsung Galaxy S4 when the > display pipeline is active. > > Signed-off-by: Alexandre MINETTE > --- [...] > +void mdp4_crtc_bus_put(struct mdp4_kms *mdp4_kms) > +{ > + mutex_lock(&mdp4_kms->clock_lock); If you use guard(mutex)(&mdp4_kms->lock_lock), you can drop the manual _unlock() calls (the lock will be dropped once you exit the scope Konrad