From: Guenter Roeck <linux@roeck-us.net>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Joel Stanley <joel@jms.id.au>,
Avi Fishman <avifishman70@gmail.com>,
Tali Perry <tali.perry1@gmail.com>, Nancy Yuen <yuenn@google.com>,
Benjamin Fair <benjaminfair@google.com>,
linux-watchdog@vger.kernel.org,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH v1 4/4] watchdog: npcm: sets card ext1 and ext2 bootstatus during probe
Date: Sun, 1 Mar 2020 08:10:44 -0800 [thread overview]
Message-ID: <998cedf4-82cb-be1b-699f-608ea7a21064@roeck-us.net> (raw)
In-Reply-To: <CAP6Zq1hPsnJ1UxAQ-wK_pkaJqzWRQ-_g5-k0Kag2YoP+c2fPjQ@mail.gmail.com>
On 3/1/20 8:08 AM, Tomer Maimon wrote:
> Sorry Guenter probebly I didnt explain it well.
>
>
> On Sun, 1 Mar 2020 at 12:48, Guenter Roeck <linux@roeck-us.net <mailto:linux@roeck-us.net>> wrote:
>
> On 3/1/20 1:40 AM, Tomer Maimon wrote:
> > During probe NPCM watchdog sets the following bootstatus flags:
> > - WDIOF_CARDRESET represent power and core reset.
> > - WDIOF_EXTERN1 represent watchdog 0-2 reset.
> > - WDIOF_EXTERN2 represent software 1-4 reset.
> >
> > Each flag is representing a group of bootstatus.
> > The user can configure through the device treethe exact reset
> > to each flag group.
> >
>
> Sorry, this doesn't make sense to me. I could understand reporting
> the above, but it looks to me like devicetree is used to associate
> a reset bit from the controller with one of the above.
> Devicetree only seems to be used to associate reset status bits
> from the controller with WDIOF_CARDRESET, WDIOF_EXTERN1, or
> WDIOF_EXTERN2. That adds a lot of complexity for little if any
> gain.
>
>
>
> It would make sense to set the bootstatus bits as suggested above,
> but that doesn't require devicetree properties.
>
> More comments inline.
>
> Guenter
>
>
>
> In the NPCM750 we have the following reset types:
>
> 1. board reset (Power on reset, Core reset)
> 2. WD reset (0-2 WD reset).
> 3. SW reset (1-4 SW reset).
>
>
> Each board can use different reset types, because in the WD status bit there is not enough bits to represent the entire NPCM750 resets.
>
> The NPCM750 reset groups are represent as follow:
>
> - WDIOF_CARDRESET represent power and core reset.
> - WDIOF_EXTERN1 represent watchdog 0-2 reset.
> - WDIOF_EXTERN2 represent software 1-4 reset.
>
Exactly, and I don't see a need to be more specific than that.
This can be implemented without all the DT complexity.
Guenter
prev parent reply other threads:[~2020-03-01 16:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-01 9:40 [PATCH v1 0/4] watchdog: npcm: support new capabilities Tomer Maimon
2020-03-01 9:40 ` [PATCH v1 1/4] dt-binding: watchdog: add restart priority documentation Tomer Maimon
2020-03-01 10:05 ` Guenter Roeck
[not found] ` <CAP6Zq1gYvoGwNwr2zCopQ5CcyVUjgdYK6yX1wVMmWh5gapp+zQ@mail.gmail.com>
2020-03-01 15:46 ` Guenter Roeck
2020-03-01 9:40 ` [PATCH v1 2/4] watchdog: npcm: add restart priority support Tomer Maimon
2020-03-01 9:40 ` [PATCH v1 3/4] dt-binding: watchdog: add bootstatus reset type documentation Tomer Maimon
2020-03-01 9:40 ` [PATCH v1 4/4] watchdog: npcm: sets card ext1 and ext2 bootstatus during probe Tomer Maimon
2020-03-01 10:48 ` Guenter Roeck
[not found] ` <CAP6Zq1hPsnJ1UxAQ-wK_pkaJqzWRQ-_g5-k0Kag2YoP+c2fPjQ@mail.gmail.com>
2020-03-01 16:10 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=998cedf4-82cb-be1b-699f-608ea7a21064@roeck-us.net \
--to=linux@roeck-us.net \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=wim@linux-watchdog.org \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®