From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B31173D47D2 for ; Wed, 8 Apr 2026 15:24:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775661897; cv=none; b=cLN5GadBQHgkkOwteb9CJrlWXQ+DEJBlUJMSXLPUK38DKsz4P/+J+dQtLf/kWNnWmda4v6+crUzKpVvC+vXkzNydjXwbFCt3/hHHqlkTzmMhCZlqwursQdA85KfuNmyA/fwKCbgGTEuvJx5mqui7yHXlx9RQr7iRUPE8vgNPOKw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775661897; c=relaxed/simple; bh=Xvx5NbnOpNGEloDoPzkjBb0luYYTDDyuKVmozJ9v8uc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LwgM/wORMCcNa1k+Gi3mcwqrqiY/RI742ZNVdbCbLLNfcc4cdex17SDzaQx/q53nQNRD5UwMRovju6uyKeD1CYxE792e5nFlpanJAFgFpePyaRsrvuRguDmAymG+Ge9MYPOj2dgXEfVGt4eaCsGKo0cnu/WaqBvI2yvA7CKu7oE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=IvuKMKQ9; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="IvuKMKQ9" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4887fd35e60so42371735e9.2 for ; Wed, 08 Apr 2026 08:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1775661894; x=1776266694; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=laiXp2rBEiPl8a2Z73ajRETlDqB8PAbCI44ILQPyqZU=; b=IvuKMKQ9jtZ/dVP06vkY7CTiZM4OuHmVnp8SRil2wsw+5I0ykRWCnGsExOFOYPKIZg U6Ymn0/O77U8r+O+X+q0jabDGdfKvl4xj/EVc6AbKwQCSaWk7TWUeaiWfTalUFOZIYwj UPJFmGWJvvQm1KCG/J4smh5BcB6Glm8/m6U7SDcCyZtDb2okWxp0w60hXrLmar/TF+uG MekJaoDfdS/tOTqmOE8U+XkxteSIrZUp/94aBnnQvTa+1ktb38KpLj5hY7MeUbXy0zdj /RUTGXZgXYhP2IYM0fqk90rFWks8YnbcCt0VLrYVoKTIjbP0yFZlQ6Zl6euxmwuC8P9O TdzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775661894; x=1776266694; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=laiXp2rBEiPl8a2Z73ajRETlDqB8PAbCI44ILQPyqZU=; b=fxq7NNh7fY3JRcaH1cGDcICDFJUdxKbySKrxLfRQFXiMrG9HTjRmoY2r2rRg2fflFO F2B++nhlYI7JyYZxeXjFv6WcH2v2XWjnK60XPmOUfKeKRynL0jBruAfHzFFimX7tW/6P kfUTPWqaFEUBKX5Bq22/bBLDQzsbTYDo/f0kvolHJLz0jHh6Oc3ykODgSFO25Tawv0SE BFsDD+mdxMjG3QTTHBD8T6BqtPqCi/JkJsEY4n7N5Tn9G9UajWvwxbguV8j1fvD0fK42 HVHynulpjkfPf4jsmPCu0dd1Z/7yHkl74mkY5PGttjMEEF1E+wbtfWfeLIV+HyoXPUX+ EEXw== X-Forwarded-Encrypted: i=1; AJvYcCWcQZ6MFAcHUvALa2cmMIkevMFAlXGhom8814XfFJJorCXgyQS408IvVSo8KhUkLL5SeqW04oFr95gdP9U=@vger.kernel.org X-Gm-Message-State: AOJu0YyRRPM7SWj24/lEMHerHGaNRkkM2ZUgUgN7URY3RW4Y8WEOfjVm OJ8O8mTMG//dJoAcsKOHfBGA74kZBaiseIF2nbDZ2aXFWpTfeESXy0rf/7QGoaMKn8k= X-Gm-Gg: AeBDievkKn+N8+XYPQy/kJXLKMSm9AfA91fC/NImNGDa/+o2osK2PajotFatX2oAsoa Om0LZ88yrSK32iAQWu8/nF3TE9LBdjj9lFkGFxtoBHuo8jdKn5GykS4nLUSWqICAa7hTsXSQ8Mp wEvMMKylitar5KHUe2+MGSOuqRAfpuLL6FlEKgBxhHVnStxWegyGtpzdpi4ZpS8CNlPkxfClT2r 9WkNCxxLdIda6klcaMFnSnca9a2DfKoxbos6ymfzYTmc/YTf0JUeQDEp949b3y0ssOcwWOJnDfU CANi35GZpifPN/f7yp67MMvg1PvrzXbzo0clKknyu0E1BjTpZJOue2s8F0K+K7tgk5DOsomFcub imXxLC7OHS24xnC6ybisFPrZK3flRbA1nvmF0T+i24mseErRJpb0qORspKUwfJt4+nlu2EVw6p3 BhOH/wASSUTn1Df6cfsqEc31dbcvlElXt+0gxN+l8wBcqm X-Received: by 2002:a05:600c:6208:b0:488:aa3d:fab1 with SMTP id 5b1f17b1804b1-488ccfc0554mr2091505e9.17.1775661894090; Wed, 08 Apr 2026 08:24:54 -0700 (PDT) Received: from [10.100.51.209] (nat2.prg.suse.com. [195.250.132.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488cd1bb778sm32985e9.7.2026.04.08.08.24.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2026 08:24:53 -0700 (PDT) Message-ID: <999772c1-ec48-407a-a0fe-64665620d855@suse.com> Date: Wed, 8 Apr 2026 17:24:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] module/kallsyms: fix nextval for data symbol lookup To: Stanislaw Gruszka Cc: linux-modules@vger.kernel.org, Sami Tolvanen , Luis Chamberlain , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, live-patching@vger.kernel.org, Daniel Gomez , Aaron Tomlin , Steven Rostedt , Masami Hiramatsu , Jordan Rome , Viktor Malik References: <20260327110005.16499-1-stf_xl@wp.pl> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20260327110005.16499-1-stf_xl@wp.pl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/27/26 12:00 PM, Stanislaw Gruszka wrote: > The symbol lookup code assumes the queried address resides in either > MOD_TEXT or MOD_INIT_TEXT. This breaks for addresses in other module > memory regions (e.g. rodata or data), resulting in incorrect upper > bounds and wrong symbol size. > > Select the module memory region the address belongs to instead of > hardcoding text sections. Also initialize the lower bound to the start > of that region, as searching from address 0 is unnecessary. > > Signed-off-by: Stanislaw Gruszka Looks ok to me. Feel free to add: Reviewed-by: Petr Pavlu As a side note, I wonder if manually determining symbol sizes this way is the best approach for modules, instead of simply returning the st_size of the symbol. The logic comes from the original implementation in "[PATCH] kallsyms for new modules" [1]. Unfortunately, the description doesn't explain this aspect but considering that the patch rewrote both the main and module kallsyms code, I expect it was done this way for consistency between vmlinux and modules. [1] https://git.kernel.org/pub/scm/linux/kernel/git/mpe/linux-fullhistory.git/commit/?id=d069cf94ca296b7fb4c7e362e8f27e2c8aca70f1 -- Thanks, Petr