mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Eric Gonçalves" <ghatto404@gmail.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] arm64: dts: qcom: r0q: enable hardware clocks
Date: Sun, 05 Oct 2025 00:50:16 -0300	[thread overview]
Message-ID: <99D0B281-03A5-447E-A6BF-892C99829D0B@gmail.com> (raw)
In-Reply-To: <d16e8c07-6c10-4c91-9bbe-a260f0497d29@oss.qualcomm.com>



On September 25, 2025 10:09:48 AM GMT-03:00, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote:
>On 9/20/25 3:46 AM, Eric Gonçalves wrote:
>> Enable the real-time clocks found in R0Q board.
>> 
>> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
>> ---
>>  arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts | 15 +++++++++++++++
>>  1 file changed, 15 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts b/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
>> index c1b0b21c0ec5..c088f1acf6ea 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
>> @@ -225,6 +225,21 @@ vol_up_n: vol-up-n-state {
>>  	};
>>  };
>>  
>> +&pmk8350_rtc {
>> +	nvmem-cells = <&rtc_offset>;
>> +	nvmem-cell-names = "offset";
>> +
>> +	status = "okay";
>> +};
>> +
>> +&pmk8350_sdam_2 {
>> +	status = "okay";
>> +
>> +	rtc_offset: rtc-offset@bc {
>
>Is this an offset you took from somewhere downstream?
>
>Generally you *really don't want to* poke at random SDAM cells,
>as they contain a lot of important settings (incl. battery/charging)
From another sm8450 device, I'm sure it's okay.
>
>Konrad

  reply	other threads:[~2025-10-05  3:50 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-20  1:46 [PATCH 0/5] arm64: dts: qcom: r0q: enable more peripherals Eric Gonçalves
2025-09-20  1:46 ` [PATCH 1/5] arm64: dts: qcom: r0q: add gpio keys Eric Gonçalves
2025-09-20 15:45   ` Dmitry Baryshkov
2025-09-20 18:02     ` Eric Gonçalves
2025-09-20 20:15       ` Dmitry Baryshkov
2025-09-20 20:22         ` Eric Gonçalves
2025-09-20 23:21           ` Dmitry Baryshkov
2025-09-20  1:46 ` [PATCH 2/5] arm64: dts: qcom: r0q: add touchscreen support Eric Gonçalves
2025-09-20 15:46   ` Dmitry Baryshkov
2025-09-25 13:08   ` Konrad Dybcio
2025-09-25 21:37     ` Eric Gonçalves
2025-09-20  1:46 ` [PATCH 3/5] arm64: dts: qcom: r0q: enable max77705 PMIC Eric Gonçalves
2025-09-20 15:48   ` Dmitry Baryshkov
2025-09-20 18:04     ` Eric Gonçalves
2025-09-25 13:06   ` Konrad Dybcio
2025-09-26  2:19     ` Eric Gonçalves
2025-10-08  8:34       ` Konrad Dybcio
2025-10-09 20:31         ` Eric Gonçalves
2025-10-20 12:06           ` Konrad Dybcio
2025-09-20  1:46 ` [PATCH 4/5] arm64: dts: qcom: r0q: enable hardware clocks Eric Gonçalves
2025-09-25 13:09   ` Konrad Dybcio
2025-10-05  3:50     ` Eric Gonçalves [this message]
2025-10-06 12:31       ` Konrad Dybcio
2025-10-06 15:49         ` Eric Gonçalves
2025-10-08  8:48           ` Konrad Dybcio
2025-10-09 19:20             ` Eric Gonçalves
2025-09-20  1:46 ` [PATCH 5/5] arm64: dts: qcom: r0q: enable ufs storage Eric Gonçalves
2025-09-20 20:16   ` Dmitry Baryshkov
2025-09-25 13:07   ` Konrad Dybcio
2025-09-25 21:37     ` Eric Gonçalves
2025-10-06 12:08       ` Konrad Dybcio
2025-10-06 15:49         ` Eric Gonçalves
2025-09-22 17:27 ` [PATCH 0/5] arm64: dts: qcom: r0q: enable more peripherals Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99D0B281-03A5-447E-A6BF-892C99829D0B@gmail.com \
    --to=ghatto404@gmail.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®