From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752785AbeDFGZ5 (ORCPT ); Fri, 6 Apr 2018 02:25:57 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:54792 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751975AbeDFGZ4 (ORCPT ); Fri, 6 Apr 2018 02:25:56 -0400 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [RFC PATCH 1/1 v2] vmscan: Support multiple kswapd threads per node From: Buddy Lumpkin In-Reply-To: <20180405061015.GU6312@dhcp22.suse.cz> Date: Thu, 5 Apr 2018 23:25:14 -0700 Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, hannes@cmpxchg.org, riel@surriel.com, mgorman@suse.de, willy@infradead.org, akpm@linux-foundation.org Message-Id: <99DC1801-1ADC-488B-BA8D-736BCE4BA372@oracle.com> References: <1522878594-52281-1-git-send-email-buddy.lumpkin@oracle.com> <20180405061015.GU6312@dhcp22.suse.cz> To: Michal Hocko X-Mailer: Apple Mail (2.3273) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8854 signatures=668697 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=886 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804060063 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id w366Q31S005313 > On Apr 4, 2018, at 11:10 PM, Michal Hocko wrote: > > On Wed 04-04-18 21:49:54, Buddy Lumpkin wrote: >> v2: >> - Make update_kswapd_threads_node less racy >> - Handle locking for case where CONFIG_MEMORY_HOTPLUG=n > > Please do not repost with such a small changes. It is much more > important to sort out the big picture first and only then deal with > minor implementation details. The more versions you post the more > fragmented and messy the discussion will become. > > You will have to be patient because this is a rather big change and it > will take _quite_ some time to get sorted. > > Thanks! > -- > Michal Hocko > SUSE Labs > Sorry about that, I actually had three people review my code internally, then I managed to send out an old version. 100% guilty of submitting code when I needed sleep. As for the change, that was in response to a request from Andrew to make the update function less racy. Should I resend a correct v2 now that the thread exists? —Buddy