From: paul.devriendt@amd.com
To: pavel@suse.cz, davej@redhat.com, linux-kernel@vger.kernel.org,
aj@suse.de, mark.langsdorf@amd.com, richard.brunner@amd.com
Subject: RE: Cpufreq for opteron
Date: Sun, 24 Aug 2003 10:31:56 -0500 [thread overview]
Message-ID: <99F2150714F93F448942F9A9F112634C080EF00E@txexmtae.amd.com> (raw)
It appears to me that the BUG_ON() macro will take the machine
down ? The BUG_ON() checks in this code (a sample below, but
this applies to all of the driver) are not fatal conditions -
execution can continue if an error is returned. Taking the
machine down to report on a non-fatal condition seems somewhat
rude.
Paul.
> -----Original Message-----
> From: Pavel Machek [mailto:pavel@suse.cz]
> Sent: Friday, August 22, 2003 3:06 PM
> To: Dave Jones; kernel list; Devriendt, Paul; aj@suse.de; Langsdorf,
> Mark; Brunner, Richard
> Subject: Re: Cpufreq for opteron
>
>
> Hi!
>
> Here's an updated version. It is quite a bit shorter, and thats
> good. Does it look good enough for inclusion?
> Pavel
>
> +static int
> +write_new_fid(u32 fid)
> +{
> + u32 lo;
> + u32 savevid = currvid;
> +
> + if ((fid & INVALID_FID_MASK) || (currvid & INVALID_VID_MASK)) {
> + printk(KERN_ERR PFX
> + "internal error - fid/vid overflow on fid write\n");
> + return 1;
> + }
> +
> + lo = fid | (currvid << MSR_C_LO_VID_SHIFT) | MSR_C_LO_INIT_FID_VID;
> +
> + dprintk(KERN_DEBUG PFX "writing fid %x, lo %x, hi %x\n",
> + fid, lo, plllock * PLL_LOCK_CONVERSION);
> +
> + wrmsr(MSR_FIDVID_CTL, lo, plllock * PLL_LOCK_CONVERSION);
> +
> + if (query_current_values_with_pending_wait())
> + return 1;
> +
> + count_off_irt();
> +
> + BUG_ON(savevid != currvid);
> + BUG_ON(fid != currfid);
> + return 0;
> +}
next reply other threads:[~2003-08-24 15:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-24 15:31 paul.devriendt [this message]
2003-08-25 9:35 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2003-08-27 0:43 paul.devriendt
2003-08-27 5:13 ` Dominik Brodowski
2003-08-25 14:09 paul.devriendt
2003-08-25 12:53 paul.devriendt
2003-08-25 13:51 ` Pavel Machek
[not found] <99F2150714F93F448942F9A9F112634C080EF006@txexmtae.amd.com.suse.lists.linux.kernel>
[not found] ` <20030825084616.GC403@elf.ucw.cz.suse.lists.linux.kernel>
2003-08-25 10:56 ` Andi Kleen
2003-08-22 20:09 paul.devriendt
2003-08-25 8:46 ` Pavel Machek
2003-08-25 13:30 ` Valdis.Kletnieks
2003-08-22 16:25 Andi Kleen
2003-08-22 13:59 Pavel Machek
2003-08-22 14:43 ` Dave Jones
2003-08-22 19:55 ` Pavel Machek
2003-08-22 20:05 ` Pavel Machek
2003-08-26 23:02 ` Dominik Brodowski
2003-08-22 14:52 ` Christoph Hellwig
2003-08-22 14:55 ` Dave Jones
2003-08-22 19:54 ` Pavel Machek
2003-08-23 7:55 ` Rogier Wolff
2003-08-23 17:50 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99F2150714F93F448942F9A9F112634C080EF00E@txexmtae.amd.com \
--to=paul.devriendt@amd.com \
--cc=aj@suse.de \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@amd.com \
--cc=pavel@suse.cz \
--cc=richard.brunner@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®