From: paul.devriendt@amd.com
To: pavel@suse.cz, davej@redhat.com, cpufreq@www.linux.org.uk,
linux-kernel@vger.kernel.org, davej@codemonkey.ork.uk
Subject: RE: powernow-k8-acpi driver
Date: Wed, 3 Mar 2004 17:57:35 -0600 [thread overview]
Message-ID: <99F2150714F93F448942F9A9F112634C109A3935@txexmtae.amd.com> (raw)
> One more thing: is there any reason for "use-array-as-struct"?
>
> static int query_current_values_with_pending_wait(u8 *perproc) { ...
> perproc[PP_OFF_CVID] = hi & MSR_S_HI_CURRENT_VID;
> perproc[PP_OFF_CFID] = lo & MSR_S_LO_CURRENT_FID; }
>
> having
>
> struct cpu_power {
> int numps, share, cvid, cfid;
> char pstates[0];
> }
>
> should do the trick...
> Pavel
Yes, I could get rid off the PP_OFF_crud using something like you
suggest. I'll do that while I am also doing the back port and get
them both out next week sometime.
Paul.
next reply other threads:[~2004-03-03 23:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-03 23:57 paul.devriendt [this message]
2004-03-04 13:44 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2004-03-04 2:00 richard.brunner
2004-03-04 23:16 ` Pavel Machek
2004-03-03 23:48 paul.devriendt
2004-03-04 12:35 ` Pavel Machek
2004-03-03 21:54 Pavel Machek
2004-03-03 22:27 ` Dave Jones
2004-03-03 22:35 ` Pavel Machek
2004-03-03 22:48 ` Dave Jones
2004-03-03 22:54 ` Pavel Machek
2004-03-03 23:36 ` Dave Jones
2004-03-04 0:07 ` Pavel Machek
2004-03-04 9:38 ` Russell King
2004-03-05 19:18 ` Bruno Ducrot
2004-03-07 13:15 ` Colin Marquardt
2004-03-03 23:09 ` Pavel Machek
2004-03-03 23:11 ` Pavel Machek
2004-03-03 23:39 ` Dave Jones
2004-03-03 23:45 ` Pavel Machek
2004-03-03 23:26 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99F2150714F93F448942F9A9F112634C109A3935@txexmtae.amd.com \
--to=paul.devriendt@amd.com \
--cc=cpufreq@www.linux.org.uk \
--cc=davej@codemonkey.ork.uk \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®