From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02744C2D0A3 for ; Tue, 3 Nov 2020 09:14:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9918820756 for ; Tue, 3 Nov 2020 09:14:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726489AbgKCJOk (ORCPT ); Tue, 3 Nov 2020 04:14:40 -0500 Received: from mga01.intel.com ([192.55.52.88]:30837 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725988AbgKCJOj (ORCPT ); Tue, 3 Nov 2020 04:14:39 -0500 IronPort-SDR: unqTT/uaTmYCcnDjf+//gpUIqNDwggZD00RwFbl6BtwViO7CBjzG0G0bL0EjVSj+uAHrkmv+og IXf9xh3KBLCg== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="186867497" X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="186867497" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 01:14:39 -0800 IronPort-SDR: eFTHNZBxqYN5dcGuDSmldVZPzDXE44+XDO/whjJgYBwHJ7nuOWNzglzewY25fZHYRAKFkkk21v lfzYIUGSFTkg== X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="538418690" Received: from vfarcas-mobl.ger.corp.intel.com (HELO [10.214.241.76]) ([10.214.241.76]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 01:14:35 -0800 Subject: Re: [PATCH v4 0/7] Convert the intel iommu driver to the dma-iommu api To: Lu Baolu , Joerg Roedel , Tom Murphy , David Woodhouse , Christoph Hellwig Cc: Ashok Raj , Intel-gfx@lists.freedesktop.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Joonas Lahtinen References: <20200927063437.13988-1-baolu.lu@linux.intel.com> <8bac9e91-36a0-c1d6-a887-4d60567ac75a@linux.intel.com> <3f5694f3-62f9-cc2b-1c2b-f9e99a4788c1@linux.intel.com> <1ce5b94a-38b3-548e-3b1a-a68390b93953@linux.intel.com> <82dab98e-0761-8946-c31c-92f19a0615b4@linux.intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <99a0d1eb-7fde-dff4-225f-92b68fbf7620@linux.intel.com> Date: Tue, 3 Nov 2020 09:14:32 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <82dab98e-0761-8946-c31c-92f19a0615b4@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/11/2020 02:53, Lu Baolu wrote: > On 11/2/20 7:52 PM, Tvrtko Ursulin wrote: >> >> On 02/11/2020 02:00, Lu Baolu wrote: >>> Hi Tvrtko, >>> On 10/12/20 4:44 PM, Tvrtko Ursulin wrote: >>>> >>>> On 29/09/2020 01:11, Lu Baolu wrote: >>>>> Hi Tvrtko, >>>>> >>>>> On 9/28/20 5:44 PM, Tvrtko Ursulin wrote: >>>>>> >>>>>> On 27/09/2020 07:34, Lu Baolu wrote: >>>>>>> Hi, >>>>>>> >>>>>>> The previous post of this series could be found here. >>>>>>> >>>>>>> https://lore.kernel.org/linux-iommu/20200912032200.11489-1-baolu.lu@linux.intel.com/ >>>>>>> >>>>>>> >>>>>>> This version introduce a new patch [4/7] to fix an issue reported >>>>>>> here. >>>>>>> >>>>>>> https://lore.kernel.org/linux-iommu/51a1baec-48d1-c0ac-181b-1fba92aa428d@linux.intel.com/ >>>>>>> >>>>>>> >>>>>>> There aren't any other changes. >>>>>>> >>>>>>> Please help to test and review. >>>>>>> >>>>>>> Best regards, >>>>>>> baolu >>>>>>> >>>>>>> Lu Baolu (3): >>>>>>>    iommu: Add quirk for Intel graphic devices in map_sg >>>>>> >>>>>> Since I do have patches to fix i915 to handle this, do we want to >>>>>> co-ordinate the two and avoid having to add this quirk and then >>>>>> later remove it? Or you want to go the staged approach? >>>>> >>>>> I have no preference. It depends on which patch goes first. Let the >>>>> maintainers help here. >>>> >>>> FYI we have merged the required i915 patches to out tree last week >>>> or so. I *think* this means they will go into 5.11. So the i915 >>>> specific workaround patch will not be needed in Intel IOMMU. >>> >>> Do you mind telling me what's the status of this fix patch? I tried this >>> series on v5.10-rc1 with the graphic quirk patch dropped. I am still >>> seeing dma faults from graphic device. >> >> Hmm back then I thought i915 fixes for this would land in 5.11 so I >> will stick with that. :) (See my quoted text a paragraph above yours.) > > What size are those fixes? I am considering pushing this series for > v5.11. Is it possible to get some acks for those patches and let them > go to Linus through iommu tree? For 5.10 you mean? They feel a bit too large for comfort to go via a non-i915/drm tree. These are the two patches required: https://cgit.freedesktop.org/drm-intel/commit/?h=drm-intel-gt-next&id=8a473dbadccfc6206150de3db3223c40785da348 https://cgit.freedesktop.org/drm-intel/commit/?h=drm-intel-gt-next&id=934941ed5a3070a7833c688c9b1d71484fc01a68 I'll copy Joonas as our maintainer - how does the idea of taking the above two patches through the iommu tree sound to you? Regards, Tvrtko