From: Juergen Gross <jgross@suse.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86/boot: skip realmode init code when running as Xen PV guest
Date: Tue, 22 Nov 2022 07:28:21 +0100 [thread overview]
Message-ID: <99a452d0-18f2-f4ab-522a-dec15d913d3b@suse.com> (raw)
In-Reply-To: <Y3vMpbsHA35VoasD@zn.tnic>
[-- Attachment #1.1.1: Type: text/plain, Size: 2507 bytes --]
On 21.11.22 20:08, Borislav Petkov wrote:
> On Mon, Nov 21, 2022 at 05:24:33PM +0100, Juergen Gross wrote:
>> When running as a Xen PV guest there is no need for setting up the
>> realmode trampoline, as realmode isn't supported in this environment.
>>
>> Trying to setup the trampoline has been proven to be problematic in
>> some cases, especially when trying to debug early boot problems with
>> Xen requiring to keep the EFI boot-services memory mapped (some
>> firmware variants seem to claim basically all memory below 1M for boot
>> services).
>>
>> Skip the trampoline setup code for Xen PV guests.
>>
>> Fixes: 084ee1c641a0 ("x86, realmode: Relocator for realmode code")
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>> arch/x86/include/asm/realmode.h | 4 ++--
>> arch/x86/realmode/init.c | 3 +++
>> 2 files changed, 5 insertions(+), 2 deletions(-)
>
>> diff --git a/arch/x86/include/asm/realmode.h b/arch/x86/include/asm/realmode.h
>> index fd6f6e5b755a..5bfce58f1bab 100644
>> --- a/arch/x86/include/asm/realmode.h
>> +++ b/arch/x86/include/asm/realmode.h
>> @@ -78,8 +78,8 @@ extern unsigned char secondary_startup_64_no_verify[];
>>
>> static inline size_t real_mode_size_needed(void)
>> {
>> - if (real_mode_header)
>> - return 0; /* already allocated. */
>> + if (real_mode_header || cpu_feature_enabled(X86_FEATURE_XENPV))
>> + return 0; /* already allocated or not needed. */
>>
>> return ALIGN(real_mode_blob_end - real_mode_blob, PAGE_SIZE);
>> }
>> diff --git a/arch/x86/realmode/init.c b/arch/x86/realmode/init.c
>> index 41d7669a97ad..1826700b156e 100644
>> --- a/arch/x86/realmode/init.c
>> +++ b/arch/x86/realmode/init.c
>> @@ -202,6 +202,9 @@ static void __init set_real_mode_permissions(void)
>>
>> static int __init init_real_mode(void)
>> {
>> + if (cpu_feature_enabled(X86_FEATURE_XENPV))a
>
> This reminds me of the notorious if (xen) sprinkling from years ago.
> Please don't do that.
>
Okay, what about plan B:
- rework realmode/rm to:
+ replace header.S with main.c making it possible to initialize
struct real_mode_header using the struct definition
+ optional: merge stack.S into main.c
- include realmode/rm addresses needed outside of it in struct
real_mode_header
- setup a dummy struct real_mode_header in Xen PV code removing the
need to skip init_real_mode(), but making it basically a nop
Would you be fine with that?
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2022-11-22 6:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 16:24 Juergen Gross
2022-11-21 19:08 ` Borislav Petkov
2022-11-22 6:28 ` Juergen Gross [this message]
2022-11-23 0:07 ` H. Peter Anvin
2022-11-23 6:29 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99a452d0-18f2-f4ab-522a-dec15d913d3b@suse.com \
--to=jgross@suse.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®