From: Christopher Bostic <cbostic@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Greg KH <gregkh@linuxfoundation.org>
Cc: mingo@redhat.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, joel@jms.id.au,
andrew@aj.id.au, jk@ozlabs.org, linux-kernel@vger.kernel.org,
openbmc@lists.ozlabs.org, robh+dt@kernel.org,
mark.rutland@arm.com, linux@armlinux.org.uk,
alistair@popple.id.au, benh@kernel.crashing.org
Subject: Re: [PATCH v7 00/23] FSI device driver implementation
Date: Mon, 5 Jun 2017 14:21:34 -0500 [thread overview]
Message-ID: <99a6278a-2276-02ca-349a-1e6e79ef9a11@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170603172528.113ffe11@vmware.local.home>
On 6/3/17 4:25 PM, Steven Rostedt wrote:
> On Sat, 3 Jun 2017 19:05:10 +0900
> Greg KH <gregkh@linuxfoundation.org> wrote:
>
>> On Wed, May 31, 2017 at 12:17:05PM -0500, Christopher Bostic wrote:
>>> Hi Greg,
>>>
>>> Are there any further changes you require for this patch set? This has been
>>> extensively tested internally and all is working as expected. Would it be
>>> possible to move forward with integration in the near future? Any input
>>> would be appreciated.
>> Sorry for the delay. I just tried applying this to my tree, but got the
>> following build warnings, and then errors:
>>
>> In file included from ./include/trace/define_trace.h:95:0,
>> from ./include/trace/events/fsi.h:127,
>> from drivers/fsi/fsi-core.c:27:
>> ./include/trace/events/fsi.h: In function ‘trace_raw_output_fsi_master_write’:
>> ./include/trace/events/fsi.h:58:12: warning: field width specifier ‘*’ expects argument of type ‘int’, but argument 8 has type ‘size_t {aka long unsigned int}’ [-Wformat=]
>> TP_printk("fsi%d:%02d:%02d %08x[%zd] <= {%*ph}",
> From patch 16/23:
>
> +TRACE_EVENT(fsi_master_write,
> + TP_PROTO(const struct fsi_master *master, int link, int id,
> + uint32_t addr, size_t size, const void *data),
> + TP_ARGS(master, link, id, addr, size, data),
> + TP_STRUCT__entry(
> + __field(int, master_idx)
> + __field(int, link)
> + __field(int, id)
> + __field(__u32, addr)
> + __field(size_t, size)
> + __field(__u32, data)
> + ),
> + TP_fast_assign(
> + __entry->master_idx = master->idx;
> + __entry->link = link;
> + __entry->id = id;
> + __entry->addr = addr;
> + __entry->size = size;
> + __entry->data = 0;
> + memcpy(&__entry->data, data, size);
> + ),
> + TP_printk("fsi%d:%02d:%02d %08x[%zd] <= {%*ph}",
> + __entry->master_idx,
> + __entry->link,
> + __entry->id,
> + __entry->addr,
> + __entry->size,
> + __entry->size, &__entry->data
> + )
> +);
>
> Looks like the second __entry->size, probably needs a type cast.
>
> Would something like:
>
> __entry->size,
> (int)__entry->size, &__entry->data
>
> work?
Steven,
Yes that did the trick. Thanks for the input
-Chris
>
> I haven't looked at the others, but I'm guessing they are probably
> similar issues.
>
> -- Steve
>
>> ^
>> ./include/trace/trace_events.h:343:22: note: in definition of macro ‘DECLARE_EVENT_CLASS’
>> trace_seq_printf(s, print); \
>> ^~~~~
>> ./include/trace/trace_events.h:65:9: note: in expansion of macro ‘PARAMS’
>> PARAMS(print)); \
>> ^~~~~~
>> ./include/trace/events/fsi.h:37:1: note: in expansion of macro ‘TRACE_EVENT’
>> TRACE_EVENT(fsi_master_write,
>> ^~~~~~~~~~~
>> ./include/trace/events/fsi.h:58:2: note: in expansion of macro ‘TP_printk’
>> TP_printk("fsi%d:%02d:%02d %08x[%zd] <= {%*ph}",
>> ^~~~~~~~~
>> In file included from ./include/trace/trace_events.h:377:0,
>> from ./include/trace/define_trace.h:95,
>> from ./include/trace/events/fsi.h:127,
>> from drivers/fsi/fsi-core.c:27:
>> ./include/trace/events/fsi.h:58:44: note: format string is defined here
>> TP_printk("fsi%d:%02d:%02d %08x[%zd] <= {%*ph}",
>> ~^~
>> In file included from ./include/trace/define_trace.h:95:0,
>> from ./include/trace/events/fsi.h:127,
>> from drivers/fsi/fsi-core.c:27:
>> ./include/trace/events/fsi.h: In function ‘trace_raw_output_fsi_master_rw_resul
>> ’:
>> ./include/trace/events/fsi.h:95:12: warning: field width specifier ‘*’ expects argument of type ‘int’, but argument 9 has type ‘size_t {aka long unsigned int}’ [-Wformat=]
>> TP_printk("fsi%d:%02d:%02d %08x[%zd] %s {%*ph} ret %d",
>> ^
>> ./include/trace/trace_events.h:343:22: note: in definition of macro ‘DECLARE_EVENT_CLASS’
>> trace_seq_printf(s, print); \
>> ^~~~~
>> ./include/trace/trace_events.h:65:9: note: in expansion of macro ‘PARAMS’
>> PARAMS(print)); \
>> ^~~~~~
>> ./include/trace/events/fsi.h:68:1: note: in expansion of macro ‘TRACE_EVENT’
>> TRACE_EVENT(fsi_master_rw_result,
>> ^~~~~~~~~~~
>> ./include/trace/events/fsi.h:95:2: note: in expansion of macro ‘TP_printk’
>> TP_printk("fsi%d:%02d:%02d %08x[%zd] %s {%*ph} ret %d",
>> ^~~~~~~~~
>> In file included from ./include/trace/trace_events.h:377:0,
>> from ./include/trace/define_trace.h:95,
>> from ./include/trace/events/fsi.h:127,
>> from drivers/fsi/fsi-core.c:27:
>> ./include/trace/events/fsi.h:95:44: note: format string is defined here
>> TP_printk("fsi%d:%02d:%02d %08x[%zd] %s {%*ph} ret %d",
>> ~^~
>> CHK include/generated/uapi/linux/version.h
>> GEN .version
>> CHK include/generated/compile.h
>> UPD include/generated/compile.h
>> CC init/version.o
>> LD init/built-in.o
>> LD vmlinux.o
>> MODPOST vmlinux.o
>> KSYM .tmp_kallsyms1.o
>> KSYM .tmp_kallsyms2.o
>> LD vmlinux
>> SORTEX vmlinux
>> SYSMAP System.map
>> CC arch/x86/boot/version.o
>> Building modules, stage 2.
>> VOFFSET arch/x86/boot/compressed/../voffset.h
>> OBJCOPY arch/x86/boot/compressed/vmlinux.bin
>> RELOCS arch/x86/boot/compressed/vmlinux.relocs
>> CC arch/x86/boot/compressed/kaslr.o
>> GZIP arch/x86/boot/compressed/vmlinux.bin.gz
>> CC arch/x86/boot/compressed/misc.o
>> MODPOST 476 modules
>> WARNING: modpost: missing MODULE_LICENSE() in drivers/fsi/fsi-core.o
>> see include/linux/module.h for more information
>> MKPIGGY arch/x86/boot/compressed/piggy.S
>> AS arch/x86/boot/compressed/piggy.o
>> DATAREL arch/x86/boot/compressed/vmlinux
>> LD arch/x86/boot/compressed/vmlinux
>> ZOFFSET arch/x86/boot/zoffset.h
>> OBJCOPY arch/x86/boot/vmlinux.bin
>> AS arch/x86/boot/header.o
>> LD arch/x86/boot/setup.elf
>> OBJCOPY arch/x86/boot/setup.bin
>> BUILD arch/x86/boot/bzImage
>> Setup is 17532 bytes (padded to 17920 bytes).
>> System is 5445 kB
>> CRC 56d8089d
>> Kernel: arch/x86/boot/bzImage is ready (#387)
>> ERROR: "fsi_slave_claim_range" [drivers/fsi/fsi-master-hub.ko] undefined!
>> ERROR: "fsi_slave_read" [drivers/fsi/fsi-master-hub.ko] undefined!
>> ERROR: "fsi_slave_write" [drivers/fsi/fsi-master-hub.ko] undefined!
>> ERROR: "fsi_slave_release_range" [drivers/fsi/fsi-master-hub.ko] undefined!
>> make[1]: *** [scripts/Makefile.modpost:91: __modpost] Error 1
>> make: *** [Makefile:1214: modules] Error 2
>>
>>
>> Note, I'm using gcc 7.1.1, which might be what is showing the build warnings,
>> but that doesn't explain the build errors.
>>
>> So obviously, I can't take this as is :(
>>
>> thanks,
>>
>> greg k-h
next prev parent reply other threads:[~2017-06-05 19:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 21:00 Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 01/23] drivers/fsi: Add fsi master definition Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 02/23] drivers/fsi: Add slave definition Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 03/23] drivers/fsi: Add empty master scan Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 04/23] lib: Add crc4 module Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 05/23] drivers/fsi: Add slave & master read/write APIs Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 06/23] drivers/fsi: Set up links for slave communication Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 07/23] drivers/fsi: Implement slave initialisation Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 08/23] drivers/fsi: Set slave SMODE to init communication Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 09/23] drivers/fsi: scan slaves & register devices Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 10/23] drivers/fsi: Add device read/write/peek API Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 11/23] drivers/fsi: Add master unscan Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 12/23] drivers/fsi: Add documentation for GPIO bindings Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 13/23] drivers/fsi: Add client driver register utilities Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 14/23] drivers/fsi: Add sysfs files for FSI master & slave accesses Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 15/23] drivers/fsi: expose direct-access slave API Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 16/23] drivers/fsi: Add tracepoints for low-level operations Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 17/23] drivers/fsi: Add error handling for slave Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 18/23] drivers/fsi: Document FSI master sysfs files in ABI Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 19/23] drivers/fsi: Add GPIO based FSI master Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 20/23] drivers/fsi/gpio: Add tracepoints for GPIO master Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 21/23] drivers/fsi: Add SCOM FSI client device driver Christopher Bostic
2017-05-11 21:00 ` [PATCH v7 22/23] drivers/fsi: Add hub master support Christopher Bostic
2017-05-11 21:01 ` [PATCH v7 23/23] drivers/fsi: Use asynchronous slave mode Christopher Bostic
2017-05-31 17:17 ` [PATCH v7 00/23] FSI device driver implementation Christopher Bostic
2017-06-03 10:05 ` Greg KH
2017-06-03 21:25 ` Steven Rostedt
2017-06-05 19:21 ` Christopher Bostic [this message]
2017-06-05 19:20 ` Christopher Bostic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99a6278a-2276-02ca-349a-1e6e79ef9a11@linux.vnet.ibm.com \
--to=cbostic@linux.vnet.ibm.com \
--cc=alistair@popple.id.au \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®