From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759140AbcILOxg (ORCPT ); Mon, 12 Sep 2016 10:53:36 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:34355 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757525AbcILOxe (ORCPT ); Mon, 12 Sep 2016 10:53:34 -0400 Subject: Re: [PATCH] ARM: dma-mapping: add in missing white space in error message text To: Russell King - ARM Linux , Robin Murphy References: <20160912125212.32739-1-colin.king@canonical.com> <20160912143322.GW1041@n2100.armlinux.org.uk> Cc: Vineet Gupta , Hans-Christian Noren Egtvedt , Joerg Roedel , Jesper Nilsson , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Colin Ian King Message-ID: <99a64988-1c1d-db22-4d18-448acdd3dc04@canonical.com> Date: Mon, 12 Sep 2016 15:52:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160912143322.GW1041@n2100.armlinux.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/09/16 15:33, Russell King - ARM Linux wrote: > On Mon, Sep 12, 2016 at 02:06:09PM +0100, Robin Murphy wrote: >> On 12/09/16 13:52, Colin King wrote: >>> From: Colin Ian King >>> >>> A dev_warn message spans two lines and the literal string is missing >>> a white space between words. Add the white space. >>> >>> Signed-off-by: Colin Ian King >>> --- >>> arch/arm/common/dmabounce.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c >>> index 3012816..f47767b 100644 >>> --- a/arch/arm/common/dmabounce.c >>> +++ b/arch/arm/common/dmabounce.c >>> @@ -547,7 +547,7 @@ void dmabounce_unregister_dev(struct device *dev) >>> >>> if (!device_info) { >>> dev_warn(dev, >>> - "Never registered with dmabounce but attempting" >>> + "Never registered with dmabounce but attempting " >>> "to unregister!\n"); >> >> Per Documentation/CodingStyle, better to put the whole thing onto one >> line so that, say, "git grep 'attempting to unregister'" doesn't leave >> one scratching ones head in confusion. >> >> Of course, even better would be to get rid of the whole thing and >> convert ARM to use SWIOTLB, but hey, one thing at a time ;) > > I doubt that can happen - dmabounce does a little more than swiotlb > because it copes with DMA masks that are _not_ a number of zeros > followed by one bits. It was written to support things like SA1111 > DMA, where the device has a bug in that it can't drive certain > SDRAM address bits correctly. > > It also gets used for ITE8512 PCI controllers and IXP4xx platforms, > although these should probably be converted to SWIOTLB. However, > without having test systems, I'd recommend leaving them as-is. > OK, nevermind this patch, drop it into /dev/null Colin