From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752245AbcK1R1T (ORCPT ); Mon, 28 Nov 2016 12:27:19 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35906 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750832AbcK1R1N (ORCPT ); Mon, 28 Nov 2016 12:27:13 -0500 Subject: Re: [PATCH 1/6] perf tool: Add time-based utility functions To: Jiri Olsa , David Ahern References: <1480109999-36971-1-git-send-email-dsa@cumulusnetworks.com> <1480109999-36971-2-git-send-email-dsa@cumulusnetworks.com> <20161128135846.GD1928@krava> Cc: acme@kernel.org, mingo@kernel.org, peterz@infradead.org, namhyung@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org From: David Ahern Message-ID: <99a68c84-ef38-6707-b8d4-16332bda56d4@gmail.com> Date: Mon, 28 Nov 2016 10:27:08 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <20161128135846.GD1928@krava> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/28/16 6:58 AM, Jiri Olsa wrote: > On Fri, Nov 25, 2016 at 02:39:54PM -0700, David Ahern wrote: > > SNIP > >> diff --git a/tools/perf/util/time-utils.h b/tools/perf/util/time-utils.h >> new file mode 100644 >> index 000000000000..4368a481251d >> --- /dev/null >> +++ b/tools/perf/util/time-utils.h >> @@ -0,0 +1,12 @@ >> +#ifndef _TIME_UTILS_H_ >> +#define _TIME_UTILS_H_ >> + >> +struct perf_time { >> + u64 start, end; >> +}; > > hum, it's more interval rather than 'time' > would perf_interval, perf_time_interval suit better? I'll flip to perf_interval. ack to the other 2 comments on this patch.