From: Ritesh Kumar <quic_riteshk@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: <andersson@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<catalin.marinas@arm.com>, <will@kernel.org>,
<quic_bjorande@quicinc.com>, <geert+renesas@glider.be>,
<arnd@arndb.de>, <neil.armstrong@linaro.org>,
<nfraprado@collabora.com>, <m.szyprowski@samsung.com>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<quic_abhinavk@quicinc.com>, <quic_rajeevny@quicinc.com>,
<quic_vproddut@quicinc.com>
Subject: Re: [PATCH 2/2] arm64: dts: qcom: qcm6490-idp: add display and panel
Date: Tue, 23 Jan 2024 19:13:23 +0530 [thread overview]
Message-ID: <99a9a562-9f6f-411c-be1c-0a28fc2524dd@quicinc.com> (raw)
In-Reply-To: <CAA8EJpqQVuS+yqXQ2y5sNQrRVg7tcQAJ3ywsEjg+O=7TkUZWLQ@mail.gmail.com>
On 1/16/2024 6:27 PM, Dmitry Baryshkov wrote:
> On Tue, 16 Jan 2024 at 14:06, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>>
>> On 1/16/24 10:49, Ritesh Kumar wrote:
>>> Enable Display Subsystem with Novatek NT36672E Panel
>>> on qcm6490 idp platform.
>>>
>>> Signed-off-by: Ritesh Kumar <quic_riteshk@quicinc.com>
>>> ---
>>> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 100 +++++++++++++++++++++++
>>> 1 file changed, 100 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>>> index 2a6e4907c5ee..efa5252130a1 100644
>>> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>>> @@ -9,6 +9,7 @@
>>> #define PM7250B_SID 8
>>> #define PM7250B_SID1 9
>>>
>>> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
>>> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>> #include "sc7280.dtsi"
>>> #include "pm7250b.dtsi"
>>> @@ -38,6 +39,25 @@
>>> stdout-path = "serial0:115200n8";
>>> };
>>>
>>> + lcd_disp_bias: lcd-disp-bias-regulator {
>>> + compatible = "regulator-fixed";
>>> + regulator-name = "lcd_disp_bias";
>>> + regulator-min-microvolt = <5500000>;
>>> + regulator-max-microvolt = <5500000>;
>>> + gpio = <&pm7250b_gpios 2 GPIO_ACTIVE_HIGH>;
>>> + enable-active-high;
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&lcd_disp_bias_en>;
>> property-n
>> property-names
>>
>> all throughout the patch
Thanks, I will update in the new version.
>>> +&gpu {
>>> + status = "disabled";
>>> +};
>> Hm.. generally we disable the GPU in the SoC DT, but that doesn't
>> seem to have happened here..
>>
>> Thinking about it more, is disabling it here necessary? Does it
>> not fail gracefully?
> Missed this.
>
> I'd say, I don't see a reason to disable it at all. The GPU should be
> working on sc7280 / qcm4290.
With GPU device node enabled, adreno_bind failure is seen as the
"speed_bin" was not populated on QCM6490 target which leads to display
bind failure.
Spoke with GPU team and on QCM6490 board, only CPU rendering is
supported for now and there is no plan to enable GPU rendering in near
future.
In this regard, what do you suggest
1) Disable GPU in QCM6490 DT (as per the current patch)
2) Disable GPU in the SoC DT, but enable it in other platform DTs. (This
will prompt change in all the dt's and we don't have all the devices to
test)
Please let me know your views on it.
Thanks,
Ritesh
next prev parent reply other threads:[~2024-01-23 13:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 9:49 [PATCH 0/2] add display and panel on qcm6490 idp Ritesh Kumar
2024-01-16 9:49 ` [PATCH 1/2] arm64: defconfig: enable Novatek NT36672E DSI Panel driver Ritesh Kumar
2024-01-16 9:59 ` Dmitry Baryshkov
2024-01-16 10:25 ` Ritesh Kumar (QUIC)
2024-01-16 10:44 ` Dmitry Baryshkov
2024-01-16 9:49 ` [PATCH 2/2] arm64: dts: qcom: qcm6490-idp: add display and panel Ritesh Kumar
2024-01-16 9:58 ` Dmitry Baryshkov
2024-01-23 12:43 ` Ritesh Kumar
2024-01-23 13:07 ` Dmitry Baryshkov
2024-01-16 12:06 ` Konrad Dybcio
2024-01-16 12:57 ` Dmitry Baryshkov
2024-01-23 13:43 ` Ritesh Kumar [this message]
2024-01-23 15:12 ` Dmitry Baryshkov
2024-01-23 18:04 ` Konrad Dybcio
2024-02-12 12:28 ` Ritesh Kumar
2024-02-12 13:27 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99a9a562-9f6f-411c-be1c-0a28fc2524dd@quicinc.com \
--to=quic_riteshk@quicinc.com \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=geert+renesas@glider.be \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=neil.armstrong@linaro.org \
--cc=nfraprado@collabora.com \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_bjorande@quicinc.com \
--cc=quic_rajeevny@quicinc.com \
--cc=quic_vproddut@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®