From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADFBCC6FA99 for ; Tue, 7 Mar 2023 01:21:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229833AbjCGBVc convert rfc822-to-8bit (ORCPT ); Mon, 6 Mar 2023 20:21:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229663AbjCGBVa (ORCPT ); Mon, 6 Mar 2023 20:21:30 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80DC943457; Mon, 6 Mar 2023 17:21:17 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id B737C24E21B; Tue, 7 Mar 2023 09:21:10 +0800 (CST) Received: from EXMBX162.cuchost.com (172.16.6.72) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 7 Mar 2023 09:21:10 +0800 Received: from [192.168.120.42] (171.223.208.138) by EXMBX162.cuchost.com (172.16.6.72) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 7 Mar 2023 09:21:09 +0800 Message-ID: <99a9eccd-2886-832f-07e6-4ba620c522b5@starfivetech.com> Date: Tue, 7 Mar 2023 09:21:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v5 12/12] riscv: dts: starfive: visionfive 2: Enable gmac device tree node Content-Language: en-US To: Emil Renner Berthing CC: , , , , "David S . Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Richard Cochran , Andrew Lunn , Heiner Kallweit , Peter Geis , Yanhong Wang References: <20230303085928.4535-1-samin.guo@starfivetech.com> <20230303085928.4535-13-samin.guo@starfivetech.com> From: Guo Samin In-Reply-To: Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX162.cuchost.com (172.16.6.72) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2023/3/6 21:04:28, Emil Renner Berthing 写道: > On Fri, 3 Mar 2023 at 10:01, Samin Guo wrote: >> From: Yanhong Wang >> >> Update gmac device tree node status to okay. >> >> Signed-off-by: Yanhong Wang >> Signed-off-by: Samin Guo >> --- >> .../dts/starfive/jh7110-starfive-visionfive-2.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> index c2aa8946a0f1..d1c409f40014 100644 >> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> @@ -12,6 +12,8 @@ >> / { >> aliases { >> serial0 = &uart0; >> + ethernet0 = &gmac0; >> + ethernet1 = &gmac1; > > Please sort these alphabetically. Thanks, will fix. > >> i2c0 = &i2c0; >> i2c2 = &i2c2; >> i2c5 = &i2c5; >> @@ -92,6 +94,14 @@ >> status = "okay"; >> }; >> >> +&gmac0 { >> + status = "okay"; >> +}; >> + >> +&gmac1 { >> + status = "okay"; >> +}; > > Since you'll need to add to the gmac0 and gmac1 nodes in the board > specific files too and it's only one line, consider just dropping this > here and add the status = "okay" there instead. > According to Andrew's suggestion, can I put the nodes of mdio and phy here? >> &i2c0 { >> clock-frequency = <100000>; >> i2c-sda-hold-time-ns = <300>; >> -- >> 2.17.1 >> >> >> _______________________________________________ >> linux-riscv mailing list >> linux-riscv@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-riscv Best regards, Samin -- Best regards, Samin