From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7380EC43331 for ; Fri, 6 Sep 2019 15:17:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44B9E20650 for ; Fri, 6 Sep 2019 15:17:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390326AbfIFPRi (ORCPT ); Fri, 6 Sep 2019 11:17:38 -0400 Received: from foss.arm.com ([217.140.110.172]:57918 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726168AbfIFPRh (ORCPT ); Fri, 6 Sep 2019 11:17:37 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C359E1596; Fri, 6 Sep 2019 08:17:36 -0700 (PDT) Received: from [10.1.196.105] (unknown [10.1.196.105]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8F8623F59C; Fri, 6 Sep 2019 08:17:34 -0700 (PDT) From: James Morse Subject: Re: [PATCH v3 03/17] arm64, hibernate: remove gotos in create_safe_exec_page To: Pavel Tatashin Cc: jmorris@namei.org, sashal@kernel.org, ebiederm@xmission.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com, vladimir.murzin@arm.com, matthias.bgg@gmail.com, bhsharma@redhat.com, linux-mm@kvack.org, mark.rutland@arm.com References: <20190821183204.23576-1-pasha.tatashin@soleen.com> <20190821183204.23576-4-pasha.tatashin@soleen.com> Message-ID: <99aba737-a959-e352-74d8-a2aff3ae5a88@arm.com> Date: Fri, 6 Sep 2019 16:17:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190821183204.23576-4-pasha.tatashin@soleen.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, On 21/08/2019 19:31, Pavel Tatashin wrote: > Usually, gotos are used to handle cleanup after exception, but > in case of create_safe_exec_page there are no clean-ups. So, > simply return the errors directly. Reviewed-by: James Morse Thanks, James