From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B96943502A7 for ; Tue, 3 Mar 2026 14:50:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772549440; cv=none; b=cgc2X1nlqobxSpAebx/9zfwm8tETa0CrIX28B8fXFSWIqglafgEGKMrADPmHMytulnuZ2UXWt2F6S01cSsXhQxiH5cKaGGDA6Ksh9YfK1WICcLG+gfoLysr8rGxHwEa53z7RQmEfE4LaoVwcSeatvTyQ3oUnowj1wHjzjqELXBc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772549440; c=relaxed/simple; bh=+m1oPPpqfWeAOO56f1hf4+JV6zoMk3IpH9UEKIQQVdk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dUNZSEq4d3LzCsI/pVtZBNVHsOt+IvkL70mfj1noUIY9Rxw8EZroTG3WjKT5m8u5v7c8LNaglIPnO5nS29C/bpZ7Xcnx0ykJu2WbxW+edGVPHbyATKazKldjkcoeIvi1s024j7ijK3bm+0U/3TTWOzBN+rJLKjR5DROoRh84EVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lEEOcZuV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XGsR4dcw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lEEOcZuV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XGsR4dcw" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6239n5MQ582366 for ; Tue, 3 Mar 2026 14:50:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NE8pe8ib8kQOsIUrUjRQdb4uB8crsnoEVqb4KHhRpHw=; b=lEEOcZuVmN8xb/uJ I+DvIulht3sRtrS3pGsyaeHRJi827gjdR2vD2PkHANwMxX7PXjRzOD/YkWxYAGkv UZ1ptaV5RuJ17xo8I3HCBk8Kg3XMqSU9bzg8fOnhnj9WwaaoVwmseip012zHZ3uL 1urQ/QUsUvn7hRRtnwLoAAYObcH9ii2+/zxqCb5q0xeNfqDjSaKmMnS4OK1QsHeX wdVdwhOj3DH7p0PPPRezPDGIihJi8GjLt1x82lf0DDtFJAen5sHepvu4AuSLqqRO jM8tTnR1Ysrzw5oWTuYHouVfOvpySx+Wuv4541WClDtWnGNBotBJdROg5kM7y5KT j1BYBA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cnh6ubaj2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 03 Mar 2026 14:50:38 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2adef9d486bso51992805ad.2 for ; Tue, 03 Mar 2026 06:50:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772549438; x=1773154238; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NE8pe8ib8kQOsIUrUjRQdb4uB8crsnoEVqb4KHhRpHw=; b=XGsR4dcwa2YemqJ+kA6bC6Ua+M0kxFZRDJLYs0VXMUvTCkesOw3GrguWqDYskA5gRC MaMmCaprkQywPUjSUtcdldHfuNBwjwzSAxGtwjg0ETrUjeW/CNYe/iQ3qWbI1yFI2IxO NRDnial+3tRaomZJNLmMFRTB/mCd0PA7INrg4m3/3Wtu8ZtXF5lu8ULkO0SmMsQsV4Ss F3TtwwIjUGE+X1kKh/LoI0Aaz/Ek586y9hV7rHzDzH9caFJqh6k1o5/tGmhWDdORpoue +Ikh5SH9sb0obIIZ7ZjMgAw9uHmaDVk1geHqeerpHH01jBpimI6csu0F0+4FKcZ3rDHq MGCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772549438; x=1773154238; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NE8pe8ib8kQOsIUrUjRQdb4uB8crsnoEVqb4KHhRpHw=; b=wX3IBWiqLdeN845KA5BrTE0w2FKurI2b8R39sqA+6sQ7P8AMKw7tNGIpPrelijFfSi Bf0eTdl6B4Y82AkrbnjbjjIfNPQjGfROfs2Auv+2pdRYVQ3DJZEedQw36NYU5Lhe8tCg rAo37KIX83v0cZzdWmVcrqrb+btNoZMdrDQeejsB4neDoW/YFq2RU+cpeQaa4B02ryWY o0nKS9icEneKJ4xcFntWmJSdPj4DRqfj3PGCK8048BvCInBDeztIjUhbEYhwO0igGbFH 4bHKunJRBIBHxnApKJIXJZU4kZzj9bS5gqGBCGdp9PDCmGWDzYpA8nSc9s8EnbHe3Z9h mgyQ== X-Forwarded-Encrypted: i=1; AJvYcCXkaIhuZKfHzqkgfwA8rZM39mpxY8t0fAB4tZM0IsuehYEEq/p7TbSfgdvixh0MOdqHkC80dWMR793du9U=@vger.kernel.org X-Gm-Message-State: AOJu0YwamP3XzytYHi+7UppSXj81rjEsMqV5lVgmXoaX5yFp2/c7uNWG 3hyiY2TdH55T176i+4DO9/ZeLAzv7DQ1qRgQzq+TPhlz8Gec9RCHy7Idhp/i10BQH3ZrKNHIyuQ h35kq2mcgLMymxnzTRUmPWGyazEDh9ttDNzblWF3nfb+YXFNyFn5CVfo6ctc8Rnf4s8E= X-Gm-Gg: ATEYQzyyVAGR5oFTMD2FN2RjvJF2rcjTmbhwGA5HjaEgEJtRCqm/djK+twUi7dHBl9q PDBSKyKJ990URFqmC5nDDOL8xTAGdpWprtPoVm5stvDdoJLHYeyNClPZ0rndJp717JziSuDESbq bPPQA1b2S26rahvFvXzoUEsjhAHaZ3qFvpxKC4k8pIFxQlwKBj3/LOILIbREeiWgKDWeW+3QoHG wp5td1I8eXTuofC2Dtipo0nrLhvmNu63HzJbSEzMTcT97GMJqW8GIDuek8M4W8QKdw9zigpHoin 428bzdigM/lJDggIUloX8EOb2cznT6fNeVM8sCANmt/D7AGnuLxDPuMHtqofl8fJC/eLUEmV0su 8WrdzdpFM1EPo68d45ic07s9zBNjBE7MegTov4utROCgYT2iEgDI= X-Received: by 2002:a17:902:ce8d:b0:2ae:55bd:1473 with SMTP id d9443c01a7336-2ae55bd1983mr61678365ad.31.1772549438137; Tue, 03 Mar 2026 06:50:38 -0800 (PST) X-Received: by 2002:a17:902:ce8d:b0:2ae:55bd:1473 with SMTP id d9443c01a7336-2ae55bd1983mr61678135ad.31.1772549437633; Tue, 03 Mar 2026 06:50:37 -0800 (PST) Received: from [192.168.1.5] ([122.179.39.61]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb69f283sm170655295ad.49.2026.03.03.06.50.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Mar 2026 06:50:37 -0800 (PST) Message-ID: <99b76cfa-389b-409f-bdc4-74a077108a07@oss.qualcomm.com> Date: Tue, 3 Mar 2026 20:20:29 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] dt-bindings: interconnect: qcom,qcs615-rpmh: add clocks property to enable QoS To: Krzysztof Kozlowski Cc: Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Raviteja Laggyshetty , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Tipton References: <20260211091112.3285626-1-odelu.kukatla@oss.qualcomm.com> <20260211091112.3285626-2-odelu.kukatla@oss.qualcomm.com> <20260212-armored-kingfisher-of-admiration-bdef7c@quoll> Content-Language: en-US From: Odelu Kukatla In-Reply-To: <20260212-armored-kingfisher-of-admiration-bdef7c@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAzMDExOCBTYWx0ZWRfX+iamZ1kzE+G6 0pjQrxqjPZ7cw1IPW1fdtNMAzO0xVs/4VyIY06kxMupnmxh+3tb4V2U+/q+LlfYkCgaJoipcp/9 o6xIJRS8n3dV8t2+2YiFOA2EqWZI4ytaOBFekAdNHwKyNmZLgD9dpa6QSqhajoLVG+fzsWrBBry IJq/uxmmemJpfyH6fTUl+/uMbChgBtAayF/Spt7ZToxxajr3SjuMVSXKdF9F5Iisr9vyuSSNzMy anlL85hso+YQGb0MFBGTaONpCXVOFIgtYdKYjzjcpTgaF6qkNbIKheN65EurMJw9c9sSGhWC3eJ ITC6CvULGe4+euOqmcZmQAJxRKhCLEbl4I9v2lB4eLDAkAzJcTOVgNMh19eJoskePhgXOb6IH28 aquG2eugTABIGJU5VIC8mJcg737hUwZFoweOUUy6MPw3xyCKZ6/3EJMX8M4a+PMhlOmX6mibIZB 1fxXsHIRoj7rYwnZh2w== X-Authority-Analysis: v=2.4 cv=MuhfKmae c=1 sm=1 tr=0 ts=69a6f53e cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=U82GXnHrZkNfQIH0kmVtCQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=hh-M-2xEcZ6B0zPyQVMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: 7faEfUEY_RGZXi5384ge-gFkG1JQy103 X-Proofpoint-GUID: 7faEfUEY_RGZXi5384ge-gFkG1JQy103 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_05,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 suspectscore=0 malwarescore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603030118 On 2/12/2026 4:32 PM, Krzysztof Kozlowski wrote: > On Wed, Feb 11, 2026 at 02:41:10PM +0530, Odelu Kukatla wrote: >> Aggre1-noc interconnect node on QCS615 has QoS registers located >> inside a block whose interface is clock-gated. For that node, >> driver must enable the corresponding clock(s) before accessing >> the registers. Add the 'clocks' property so the driver can obtain >> and enable the required clock(s). >> >> Only interconnects that have clock‑gated QoS register interface >> use this property; it is not applicable to all interconnect nodes. >> >> Signed-off-by: Odelu Kukatla >> --- >> .../interconnect/qcom,qcs615-rpmh.yaml | 46 +++++++++++++++++++ >> 1 file changed, 46 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,qcs615-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,qcs615-rpmh.yaml >> index e06404828824..42679deb4607 100644 >> --- a/Documentation/devicetree/bindings/interconnect/qcom,qcs615-rpmh.yaml >> +++ b/Documentation/devicetree/bindings/interconnect/qcom,qcs615-rpmh.yaml >> @@ -34,6 +34,10 @@ properties: >> reg: >> maxItems: 1 >> >> + clocks: >> + minItems: 4 >> + maxItems: 4 > > Define the clocks here please. > >> + >> required: >> - compatible >> >> @@ -53,6 +57,37 @@ allOf: >> required: >> - reg >> >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,qcs615-aggre1-noc >> + then: >> + properties: >> + clocks: >> + items: >> + - description: aggre UFS PHY AXI clock >> + - description: aggre USB2 SEC AXI clock >> + - description: aggre USB3 PRIM AXI clock >> + - description: RPMH CC IPA clock > > And this entire "if" goes away... unless you already plan to correct other > devices. If so, please correc them now. > Hi Krzysztof, Thanks for the review. I will move the clocks definition to the top-level properties and remove the specific if block for aggre1-noc as suggested. Regarding the exclusion “if” block: I will keep it to align with your recent fix for SA8775P (dt-bindings: interconnect: sa8775p: Fix incorrectly added reg and clocks) where you enforced strict constraints. My plan for v3 is to: 1.Define clocks at the top level. 2.Remove "if" block for aggre1-noc 3.Keep "if" block to explicitly disallow clocks for the nodes that do not support them. I will send v3 with these changes shortly. Regards, Odelu > Best regards, > Krzysztof >