From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33F39C76196 for ; Thu, 6 Apr 2023 16:49:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239712AbjDFQtZ (ORCPT ); Thu, 6 Apr 2023 12:49:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239879AbjDFQtP (ORCPT ); Thu, 6 Apr 2023 12:49:15 -0400 Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADAF686AD for ; Thu, 6 Apr 2023 09:49:11 -0700 (PDT) Received: by mail-il1-x12a.google.com with SMTP id e9e14a558f8ab-325d21f7afaso249575ab.1 for ; Thu, 06 Apr 2023 09:49:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; t=1680799751; x=1683391751; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2dcRW4cznRuuVpkSa4JtvG2ynNPWMlAN993xuYHDgw8=; b=M+FxqiPiUJSvrSl6U59WLWbid3iEyTYJbUjGhJUr5MonYejbkZw/yA98ioyvBeWwyw jIoiDAsyILNtthV3PKIGiN2YoJfyy3gxnKyVtROrRQY4uNpodvYVhe1LNm6iP89mJTRi doqIwVOsQH9GRVeEQpvr5azvbJgOI7/jqcTj3SMgYgGcSdv65UNEr6+f7j3tPb75SJob bB4d6K2VvvmfDVtctzDHpTlwydRr31g1I4Sb1GZDsvPXiciX6U/xhN/7LaiuoLP5QA8U MtXY6xRDEtjEQng1q0UDf5bLbbzlK4W172+BskZdDMUqPfHJ6Nf3851uyFmYRxhOneAD v4Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680799751; x=1683391751; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2dcRW4cznRuuVpkSa4JtvG2ynNPWMlAN993xuYHDgw8=; b=lnthYEf/AoDK/oeJyUQMXonX7zL4Dw9bSNZOpkwEtzY/mw1GdrgetHrUrBvM0mSQbP N05G+GUUZTz+FPLg+i+37ia2IwqMD/CwPt73mZYIu564b7BvS1YQ+oLESMT64vHS5/2I YpCUMy/X4rw9alMCdQc/5w/DGLlJeD9czTsihzYROzoOgscHYiS1W/yeNJUIcUywRgt5 70Cw1f0skbDZL4GbZMIBDObXoccWsbc4sqpEF+iXQ8LLcTH1Vxggflrfwo6jJDBOT0Y4 w9//m4VTZnlXuaqFF1CWWlEqhjsdZRcL2jftgpHnOJjxM7uoBxSGJUKyVcMHRf3y9Vxs w5yQ== X-Gm-Message-State: AAQBX9eQYo5FOO4sWWK1gQUJdquOocO9vdhxbHlaZLEalQlISpMEwntS ex8dPzd3iPXnSP/X4bnc+/2MtA== X-Google-Smtp-Source: AKy350ZIZX1Ar8icMLnLUnfyx3SqXK4JeI1mnobKQyuOkftxckVlTBQKSIReEi+ecx+bYEc+nDJlzQ== X-Received: by 2002:a05:6e02:492:b0:325:e46f:a028 with SMTP id b18-20020a056e02049200b00325e46fa028mr3034999ils.3.1680799751004; Thu, 06 Apr 2023 09:49:11 -0700 (PDT) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id f4-20020a056e020c6400b00315327197d4sm448768ilj.23.2023.04.06.09.49.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Apr 2023 09:49:10 -0700 (PDT) Message-ID: <99c064d2-652a-8e3c-eacb-23cb46b3e3a6@kernel.dk> Date: Thu, 6 Apr 2023 10:49:09 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 0/5] add initial io_uring_cmd support for sockets Content-Language: en-US To: Keith Busch , Breno Leitao Cc: io-uring@vger.kernel.org, netdev@vger.kernel.org, kuba@kernel.org, asml.silence@gmail.com, leit@fb.com, edumazet@google.com, pabeni@redhat.com, davem@davemloft.net, dccp@vger.kernel.org, mptcp@lists.linux.dev, linux-kernel@vger.kernel.org, dsahern@kernel.org, willemdebruijn.kernel@gmail.com, matthieu.baerts@tessares.net, marcelo.leitner@gmail.com References: <20230406144330.1932798-1-leitao@debian.org> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/6/23 10:41?AM, Keith Busch wrote: > On Thu, Apr 06, 2023 at 07:43:26AM -0700, Breno Leitao wrote: >> This patchset creates the initial plumbing for a io_uring command for >> sockets. >> >> For now, create two uring commands for sockets, SOCKET_URING_OP_SIOCOUTQ >> and SOCKET_URING_OP_SIOCINQ. They are similar to ioctl operations >> SIOCOUTQ and SIOCINQ. In fact, the code on the protocol side itself is >> heavily based on the ioctl operations. > > Do you have asynchronous operations in mind for a future patch? The > io_uring command infrastructure makes more sense for operations that > return EIOCBQUEUED, otherwise it doesn't have much benefit over ioctl. Basically nothing returns EIOCBQUEUED, it's mostly sync/poll driven on the networking side. The primary use case for this is with direct descriptors, as you can't do get/setsockopt with those. And that means you'd then need to instantiate a regular descriptor first and then register it, rather than keep it all direct from the start. -- Jens Axboe