From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B16C2DB780 for ; Mon, 8 Jun 2026 06:29:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780900171; cv=none; b=HyC8oyrJ3CwSuaEfPjAkwx8lj7nQmUYWOcZOfHhVECyod7EmSohOMLaKbAWib7GZGGTFFLl/XdIcusEbw1drW4D3EAhBkpNJiou5NAgrM9/Jki5jONWsEuBmbH7xuzwvtJIP6Ie5tOXEBfEAl1ONhem4/Ez53Zv06ulmP9rhZNY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780900171; c=relaxed/simple; bh=Ne/wLNYEy8/uHyUaSwVZbmOO8k4n3YkLMmQLGm+/5IU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qY8ZnJOnrYhB8wnvTYKSir85UbpkKeI9cx3sEZUjqf7zun8RS4huSL9uNzJdBuYtHf/dDF1EXBjLHN+KYoOaOHastBd53tq+uVE05MFCUCbMfKTofr7JzVFFfvnAt/9UUy79pZjSwYkB4sNsG//Wd0dj2y++NAw7SqEgvtAA3Jo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=E53qr/Va; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fgrU9uxB; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="E53qr/Va"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fgrU9uxB" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6586OmCX2317598 for ; Mon, 8 Jun 2026 06:29:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8OZFMIAwE4JNyz//rZflVX4cjyjalWp8jCRtIDAdq2A=; b=E53qr/VaokkbaRQf Kno1hi6HWMkaMwxug9PJpuIYa05CKL8rMksO4ZrXSCQtO+09KqkEMEFvf2mEelXg sow8Jl8sNnZWdJXBsK2lVspKl58uvAwXLcauvdAir2D62VspSOZPFySwgrt/fOQX 2u32Uo6gJYbsw8G0W6lq2y1m+4NBfbSdqEOdhUoCKp1ibUqBTGtl9ZwGSqhpVtik 5rdIWDJw2na7bLJ7etec1nSbf4/oMKUhxKL1yo9NEzW8IUFgp1ZylqhpsWla4AC2 3KIsEY7xruzMeADybc+kjPcy42bXrAVSJgDxlXP1YSzaS7CcECI4KypzCILU7BlZ sYBk9g== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4emcadx12q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Jun 2026 06:29:27 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-8422b544a4bso2411219b3a.3 for ; Sun, 07 Jun 2026 23:29:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780900166; x=1781504966; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8OZFMIAwE4JNyz//rZflVX4cjyjalWp8jCRtIDAdq2A=; b=fgrU9uxB5vNjFrGJfXsHwarm+Hm3tNyWqL6QTgee3rOqXcDLop/Cpw8WnzTfBG33AQ 4wgmgRjjzyN6x8Tgm2evPQ65FiIUtOaXOzaPZN2qhJ9TUmRsociYg/6DNDuFMQN7u6UM PrfUATYT/WS1hDHQNsWN9uIAGZg0+F4gqfweuvPhgr43p57B09R4pjcTKITycTEMm9Nw +KDD7k+LWmet6KQYa6lnSLGLxnrulVnpK4PQi5hHbBUzaXuTXVK/djBI763S24OvmIT1 Q4+vygqR9sD//jnQ7u8bzmho4dQFPSkBUgWSQB5n0eWQy18yX6k6dkbrX7Ge4VfwD1DM aVDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780900166; x=1781504966; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8OZFMIAwE4JNyz//rZflVX4cjyjalWp8jCRtIDAdq2A=; b=dP7UikWNCrUdoYXqBieLUH7Te5JIs+scJip9ZCOWWIRj1A3RuF4hZjP3rK6szBzqX2 INX9enzTutxqP72C7ug1BWKYjE3cxyJ4f4bmwoy/WIkbUSz7tcYEyqBXrCpDmd9KsXtM qwt7z/NRyqGjUIzp4YGGqeJ5QXrFboKUfQeFi2QA9iGLnm74PgfcqhF3B/VV+UZQ/+uC o5Ijle+2sZswgfisW9aywqT+vvHRZIwsRIhQ0WarPcYjTUPHH9YJuE28J7dic5YReASJ kD7fVx0WtRI7yH6gy0HdYiaWR8MesJCnxqT3/m9hFh7IK176iyJdYSc3mWqpg8AcrhIA 71rg== X-Forwarded-Encrypted: i=1; AFNElJ/HIQghMqN/rIINRw0SAbcg+9jBXoQxo9+CVjIe0zFmxsLSxfGWXgULqAc+Ufs8T3fHm472jzqEOspdNYU=@vger.kernel.org X-Gm-Message-State: AOJu0YzOsKP0/ODEUTVORDUeeD6wE9fltvmaFL+OqYurmo9d1OLhKGPe zg8/gHjchbkz0um2EeTEm22IgmkaR/G5RUOfLwVW8wWRlcjRtYE6XuEdzEljx1AO+nH4fEqH1C+ nP9XvlJRHRwhjoY0IjFvSs9Io/dVUkPw6qxcjckXsSJjEgT+QyHNHerruwlzXcF3FkOrl3AtGgI o= X-Gm-Gg: Acq92OG/TL/iztjAiz3X60FkwGO+Auk2UsdpAk7tey+BEKUEFABCC9I6JiZMpLZjk8G mD0f4ejot6k+78tl/t5XS8tRh9r6jcWXPFJjGzC5No0gQx7dDDhnNwcRqRfmX/oaxeZrlUFyOXs fLSZYF3Hb26VNJq67oG2oyCK9g1Em/FPA2bFubyciUrL14wcorvH5tbYGhUwqvplYC5rWUnEiwe hC3uR3NqhQ1LXVBjpwQO2xO1KLWnZDJVdpEz/RMQV4Rec6XXeGDNp8WCIN0PGauVqCwxxxygUIy cvfTzyFQaOFKWHlVjadWNCBTu2+qxvQjlqhxqkY5C/CvoOMq2amGXwNHx025FNK3eFXReoI7ekH b7Uxf5ShqZ/34GhcVp8/HsW/UAJC3Ee8QQo6SITg8ZS4s2RrYJ7gAUIOcY/PhqKx8 X-Received: by 2002:a05:6a00:338c:b0:842:48ae:1d56 with SMTP id d2e1a72fcca58-842b104d70dmr14705125b3a.35.1780900166541; Sun, 07 Jun 2026 23:29:26 -0700 (PDT) X-Received: by 2002:a05:6a00:338c:b0:842:48ae:1d56 with SMTP id d2e1a72fcca58-842b104d70dmr14705088b3a.35.1780900165954; Sun, 07 Jun 2026 23:29:25 -0700 (PDT) Received: from [10.206.105.200] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84282372868sm19124227b3a.17.2026.06.07.23.29.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Jun 2026 23:29:25 -0700 (PDT) Message-ID: <99c109a5-26f4-4bf4-bf3e-941877ce9d0b@oss.qualcomm.com> Date: Mon, 8 Jun 2026 11:59:20 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 2/2] media: qcom: iris: rollback OPP vote on PM resume failure Content-Language: en-US To: Hungyu Lin , linux-media@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, vikash.garodia@oss.qualcomm.com, abhinav.kumar@linux.dev, bod@kernel.org, mchehab@kernel.org, hverkuil@kernel.org, stefan.schmidt@linaro.org References: <20260607232841.79275-1-dennylin0707@gmail.com> <20260607232841.79275-3-dennylin0707@gmail.com> From: Vishnu Reddy In-Reply-To: <20260607232841.79275-3-dennylin0707@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=DIa/JSNb c=1 sm=1 tr=0 ts=6a266147 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=pGLkceISAAAA:8 a=jtYqVK3DyQQmX1DrNcUA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-GUID: BuE4M6GrBoMnsu669S8TH9fl2xdmzeNg X-Proofpoint-ORIG-GUID: BuE4M6GrBoMnsu669S8TH9fl2xdmzeNg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA4MDA1NiBTYWx0ZWRfX9BVtKk8b4YST QYYSXVHqoW6U/2TnywbycMI2Jo1ou6vSfehdq2OafMx1wr94rDP1PgOqweLmMgRPcYFEws85eb1 P0Bxa8252dLHnWESFoyrr1qKo/szaReWjfupJ2ImlMcwU2jF8/zGDsbK5iHJdJ/F+NPe+7LadZA sxyLSt8SKJyLgMSVgSsKRJEIrD5TpdeBKXb8SFFC6UoGZCNrWOzDkEEVlTaiAhDN2CT0mNY/8ul wkX47VTyC+1cqFk46pPvlybOA4aaA/Y9+JrSGstDcSTGXwrGmMVcliI11QiX9xktW564anOpquT dWV5Puv2P005JA7aPRP5vpm2wlPQ5S7m/2vS4Y0ICtkhZ+WYd8UFORlts3W9My5+Bq3Ki85Arbt 2X1O3elMME4R88eLOsA/e19XP4diVRBq+RV9lPawFxBoUTzFayxtzNNpynkofK0Nibh+JoBhTxw cM649UCunxyqqZstW1g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-08_02,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 bulkscore=0 adultscore=0 malwarescore=0 clxscore=1015 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606080056 On 6/8/2026 4:58 AM, Hungyu Lin wrote: > Rollback the maximum OPP vote when > pm_runtime_resume_and_get() fails in > iris_enable_power_domains(). > > Use a standard rollback path to release the OPP vote when > power domain enablement does not complete successfully. > > Fixes: bb8a95aa038e ("media: iris: implement power management") > Signed-off-by: Hungyu Lin > --- > Changes in v4: > - Addressed Dmitry Baryshkov's review comment. > - Reworked the error handling path to use a standard goto-based > rollback flow. > - Roll back the OPP vote from a dedicated error label when > pm_runtime_resume_and_get() fails. > > drivers/media/platform/qcom/iris/iris_resources.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_resources.c b/drivers/media/platform/qcom/iris/iris_resources.c > index f5e3341e1430..9059cbe8fe5f 100644 > --- a/drivers/media/platform/qcom/iris/iris_resources.c > +++ b/drivers/media/platform/qcom/iris/iris_resources.c > @@ -80,9 +80,13 @@ int iris_enable_power_domains(struct iris_core *core, struct device *pd_dev) > > ret = pm_runtime_resume_and_get(pd_dev); > if (ret) > - return ret; > + goto err_opp; > > return 0; > + > +err_opp: > + iris_opp_set_rate(core->dev, 0); > + return ret; Please add a blank line between iris_opp_set_rate(core->dev, 0); and return ret; to match the coding style used elsewhere in the driver at end of the function. > } > > int iris_disable_power_domains(struct iris_core *core, struct device *pd_dev)