From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2651C26738C for ; Thu, 20 Nov 2025 04:55:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763614523; cv=none; b=n3utT8AkHwKC9WkExj98D8iNn3IpoTUvKp+Te9YqK88E+FO7FD+4JQ4VMZrWWBv0GuVu+qjSonS+ugxeuwMKnpnDFRDpX/HkKBjCmVckEzb8NquCbGUw9Uc5ppdd/t4zJdTsBwYG101uOfGYlDbZiUH1UefGbLeHmgA46i8UM0c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763614523; c=relaxed/simple; bh=AaqqIxdOGtjyFvjU79C2CKtPoEEELPnTs9irzQKnb9Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MN7awNRNUCsRDo3A63AHhkgx56DA6hjXTm0t6PXi30UqrBCdiN1PZZb1fxaekI/wuPOzUyS18suryGAazybfTd23FeZDUeNp9BzYYWZHCUhqTizsxI7foDs9TTIy77fft1HfFes2HhCbMwC+dwuN+U7okyxIWP2TUa3+zxsv3N4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HBhIOL0o; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LpT0E22P; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HBhIOL0o"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LpT0E22P" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AK4prJT4184961 for ; Thu, 20 Nov 2025 04:55:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DncpN4eTwVmWaxuFQwCTjhRzoIYadgkKUlbtMRPPtuM=; b=HBhIOL0osIYFltyV 6yArROHTS3sssJaZ/SMTuI1/SnowjHrHFk3VxWINiZr0JwhmQMdnMij7W1ed0ip1 MmnhCoMxMA1epDUKpgNsxCOqCvO2JoeD40HXGL/p9RjtB2vx/uSfR6vzCqvAoOeg trH25HRKVTP53nEi/1FNccjhg8/5otDEDYMbFzWguSzUyJYV6yxncq9/pIgrWvpA FqzZxl+jTJ7t+97tKt2SDGZ4G4twv+QQRQzKjt+gsnlF0SPFHEKinpQdu7d11WSG Qw21WQiDJJV15vTAKbcwwR0UqSww2y2froWDnT/hPslixlANHpanTyeOVzdKrA76 ot0Tkw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ahbt6tyrs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 20 Nov 2025 04:55:20 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-297fbfb4e53so8840155ad.1 for ; Wed, 19 Nov 2025 20:55:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763614520; x=1764219320; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DncpN4eTwVmWaxuFQwCTjhRzoIYadgkKUlbtMRPPtuM=; b=LpT0E22PcG5ryqmhaD2n8ArbKz/HQjcLAq5ifuxC2ssYNfWcvnYBL8DRhPnY3pTeqK PzZAu0nM9jRUxjtUFjcWxEApA2edWwgJtJlyuLdE5xC8tQoxkAIFNnRkJa1aDXEXVLY5 FU4daXYcrsKjfnSAgvCrRlHHus3w0kOFxKc6ZuFGks9P0BiOL4dZR8vwn/W+PA9KiNk3 97TdspvqVBIHGS64Leu3GA2CJwlZBcKGGft/9dCPvbovnFGb5gGTdtsUSACYgex/Eb6v UUvKGIVBZEtr2MqX2e2nRaeIdrhoFe9l5o2WI0EuYnSwTIyBeBlxVVibS1gbIt+iTOJa GzWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763614520; x=1764219320; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DncpN4eTwVmWaxuFQwCTjhRzoIYadgkKUlbtMRPPtuM=; b=bRR1uVs4eGsuNT/hRJfAq/uNwH9s0Wnw5ffJT8IAGns4CowAe/imu499keXAk3y14z UCM0+o7grXQTjrCA/f8GATzFomsTU5/Mkrb91DW1ounh+XK3jobKc3HpYRBGLWR9DmGb esTc40pOxPxxRkc+HKqHu+rcQ5P2H1DvImZDDp8sIRVqXrVfpjxlzo9nFpJb2Qj9SsCm i92bZKJWgZttLl2z0YTAu71bIQB4hY9ItzmKuZgHgbfeeHXOBtRvxRT0VOWKVRIY1Wnu VUQRNPs38GuAaL5mo2NdOQnmKviQhrAG4AKivEH7AS+rRPLG5bLDizLz91IrsXSAHWlf +zCA== X-Forwarded-Encrypted: i=1; AJvYcCXRujfJthuVVuCbC4z+zeNfsBb/qS8OpRjGRwlCUW3ncmhQeeYZ9Wc8GHsBqA/QijPOV4g48F6WHc03CCs=@vger.kernel.org X-Gm-Message-State: AOJu0YzDsS3yebx8By2zmMebIM3RIQ/QO9y4L6pEmX/SnRfZJXAHUmPj uupK0GXWdYNbvaOoXIVebyKoI9ycywGjrBLwN4FRmGNuBNIijD+zScrcAqsRdgxcc7GOtWTmgxQ ABwRykOIVfc0cFRR/CVBwXeEuUH72W3dZNxM8HZQOljNDToB0kQVD7WqdFlKAMx+ehvM= X-Gm-Gg: ASbGnct/ybw77hcxrsWF0Bm0CYl5hUFyz1u89qtIOZhrGOCckB+WAV/u0/MMclawXqr Q9O6m4I2+AO2eD1gg1Jp7jCf3zAsR2Bhb+GgPsqAbNNe0uDmpC0rNcuiFPDStt5wLs40I2oBX4k KdhgU8DUFJhHwKCTU7+6jUWQ/vGNGQPdn0nw9sIi+fJNXIVdQmBXJ/nctQm8+4kTKJMUfutzMzY puvjuJbm2MpZfJFyHleemGUoXx3+H0EMyAlieEEZ/nuXJMEzbgG1JwDPUdc0T7KSPezBGfNPK1e JbKG7KhyEN7eZ5Wy5DHcea82S1IiVgY2pdgGvpnBFrw9jwWr+MhdTNCrOjhB3s3dWlFqqn/5gSo ZDsB+J6oxYCR6X1xzjMuRM9cg6c1MERyC4VHHesMW X-Received: by 2002:a17:902:ef09:b0:297:dfae:1524 with SMTP id d9443c01a7336-29b5b0599ecmr23010815ad.16.1763614519221; Wed, 19 Nov 2025 20:55:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IE9wEYeJGmIMH4x08ZM2uAK1wl8/ybQKArVIWz3buvqwW+M1nh22erxRUrOrddYdQiIylejYQ== X-Received: by 2002:a17:902:ef09:b0:297:dfae:1524 with SMTP id d9443c01a7336-29b5b0599ecmr23010485ad.16.1763614518708; Wed, 19 Nov 2025 20:55:18 -0800 (PST) Received: from [10.206.107.125] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b111acfsm11506795ad.19.2025.11.19.20.55.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Nov 2025 20:55:18 -0800 (PST) Message-ID: <99c22e73-797c-4a30-92ba-bc3bd8cf70f0@oss.qualcomm.com> Date: Thu, 20 Nov 2025 10:25:13 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: sdm630/660: Add CDSP-related nodes To: Srinivas Kandagatla , Konrad Dybcio , Nickolay Goppen , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org, Chenna Kesava Raju , Bharath Kumar References: <20251023-qcom-sdm660-cdsp-adsp-dts-v2-0-895ffe50ab5f@mainlining.org> <20251023-qcom-sdm660-cdsp-adsp-dts-v2-1-895ffe50ab5f@mainlining.org> <07066c46-4121-48da-846a-3a180d245589@oss.qualcomm.com> <47b40a91-8365-4431-9fd9-1e48fad2a4e1@mainlining.org> <83c3aea5-764e-4e60-8b16-67b474f19357@oss.qualcomm.com> <80836b8f-16a8-4520-ad11-5ca0abb3403e@oss.qualcomm.com> Content-Language: en-US From: Ekansh Gupta In-Reply-To: <80836b8f-16a8-4520-ad11-5ca0abb3403e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: nZzxzR8wY2Uf9bneDD2I4jxdi4A5t1QZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIwMDAyNCBTYWx0ZWRfXwf050Fn2q1zg c0vkHDqgu+eO2q0VVDgqvzAPN5Wg7U3wK/3qWjvJcBZF6xaTUm4/qPcabpAq517l2IeelgReWvQ wrd8EJygWbb0RvmJpXzbJnkGWqqonPb3Lc6DM5npFkAASxDfB62u++WPzApb03AlUNnt2yHgoqs nlpKC55AdGQQqmQAEqeinsO5+fQojDBC+ZDbbz7aoaajt3ZOQcoPGIckBOsvhoGjTLAeRjuN1aC VFKjtp2YuUJ+PWsRnpceEt0dYaJ6xtJhZW4morfANCAH6Wm4LCSmpMiLsnJz4m81XicE70CpjeZ lqjZPFuemug9k/HKO0bkk1dcRzwCmCxfPwMzmuAuqH0kce8MGnJh1AtHwnHXJCDjq+obAEQ5llq NrrkJPQonqBAkbhZGsEksGwcmCofxA== X-Proofpoint-ORIG-GUID: nZzxzR8wY2Uf9bneDD2I4jxdi4A5t1QZ X-Authority-Analysis: v=2.4 cv=PJICOPqC c=1 sm=1 tr=0 ts=691e9f38 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=OuZLqq7tAAAA:8 a=eRdh0U0_q75e97kZN5sA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=AKGiAy9iJ-JzxKVHQNES:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-20_01,2025-11-18_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 phishscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511200024 On 11/20/2025 1:58 AM, Srinivas Kandagatla wrote: > On 11/12/25 1:52 PM, Konrad Dybcio wrote: >> On 11/10/25 6:41 PM, Srinivas Kandagatla wrote: >>> On 11/3/25 12:52 PM, Konrad Dybcio wrote: >>>> On 10/31/25 12:30 PM, Nickolay Goppen wrote: >>>>> 24.10.2025 16:58, Nickolay Goppen пишет: >>>>>> 24.10.2025 11:28, Konrad Dybcio пишет: >>>>>>> On 10/23/25 9:51 PM, Nickolay Goppen wrote: >>>>>>>> In order to enable CDSP support for SDM660 SoC: >>>>>>>>   * add shared memory p2p nodes for CDSP >>>>>>>>   * add CDSP-specific smmu node >>>>>>>>   * add CDSP peripheral image loader node >>>>>>>> >>>>>>>> Memory region for CDSP in SDM660 occupies the same spot as >>>>>>>> TZ buffer mem defined in sdm630.dtsi (which does not have CDSP). >>>>>>>> In sdm660.dtsi replace buffer_mem inherited from SDM630 with >>>>>>>> cdsp_region, which is also larger in size. >>>>>>>> >>>>>>>> SDM636 also doesn't have CDSP, so remove inherited from sdm660.dtsi >>>>>>>> related nodes and add buffer_mem back. >>>>>>>> >>>>>>>> Signed-off-by: Nickolay Goppen >>>>>>>> --- >>>>>>> [...] >>>>>>> >>>>>>>> +            label = "turing"; >>>>>>> "cdsp" >>>>>> Ok, I'll change this in the next revision. >>>>>>>> +            mboxes = <&apcs_glb 29>; >>>>>>>> +            qcom,remote-pid = <5>; >>>>>>>> + >>>>>>>> +            fastrpc { >>>>>>>> +                compatible = "qcom,fastrpc"; >>>>>>>> +                qcom,glink-channels = "fastrpcglink-apps-dsp"; >>>>>>>> +                label = "cdsp"; >>>>>>>> +                qcom,non-secure-domain; >>>>>>> This shouldn't matter, both a secure and a non-secure device is >>>>>>> created for CDSP >>>>>> I've added this property, because it is used in other SoC's, such as SDM845 and SM6115 for both ADSP and CDSP >>>>> Is this property not neccessary anymore? >>>> +Srini? >>> That is true, we do not require this for CDSP, as CDSP allows both >>> unsigned and signed loading, we create both secured and non-secure node >>> by default. May be we can provide that clarity in yaml bindings so that >>> it gets caught during dtb checks. >>> >>> >>> However in ADSP case, we only support singed modules, due to historical >>> reasons how this driver evolved over years, we have this flag to allow >>> compatiblity for such users. >> Does that mean that we can only load signed modules on the ADSP, but >> the driver behavior was previously such that unsigned modules were >> allowed (which was presumably fine on devboards, but not on fused >> devices)? > Yes, its true that we allowed full access to adsp device nodes when we > first started upstreaming fastrpc driver. > > irrespective of the board only signed modules are supported on the ADSP. > I think there was one version of SoC i think 8016 or some older one > which had adsp with hvx which can load unsigned modules for compute > usecase only. > > I have added @Ekansh for more clarity. > > --srini For all the available platforms, ADSP supports only signed modules. Unsigned modules(as well as signed) are supported by CDSP and GDSP subsystems. qcom,non-secure-domain property marks the corresponding DSP as non-secure DSP. The implications of adding this property would be the following: on ADSP, SDSP, MDSP: - Only non-secure device node(/dev/fastrpc-Xdsp) is created. - Non-secure device node can be used for signed DSP PD offload. on CDSP, GDSP: - Both secure(/dev/fastrpc-Xdsp-secure) and non-secure(/dev/fastrpc-Xdsp) devices are created, regardless of this property. - Both the nodes can be used for signed and unsigned DSP PD offload. Note: If the property is not added for CDSP/GDSP, only secure device node can be used for signed PD offload, if non-secure device is used, the request gets rejected[1]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/misc/fastrpc.c#n1245 //Ekansh > > >> Konrad