From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f99.google.com (mail-pj1-f99.google.com [209.85.216.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70E5836A35E for ; Sun, 12 Jul 2026 22:30:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783895449; cv=none; b=YdV+ETT2/4NH1+zX2lwCzPEYIOjvgcIYm69lJTmKi/Nh6MRhXhouhRbQq01YqqXbnnXO7wQj2ZntI9KnlvGkyxHB681JVSRhkM92FE+H0S4rZ4TuJFh8yU0Df6MK3hatdcf8X+DlNo8NSwuHEbvw2Y2P/u+V9g8cAC3L2RFLl6k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783895449; c=relaxed/simple; bh=ER8tP37lObIhQR9iMWULWXKSl19MKFjdA03HNDy5ju0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BmOb9n8WE6UkorXoTLDtFun1IxVdRm/dKf5xvg9J5GVbMqW8zJyNqNPvndcVZ69A//+Q6znMTZriD50+Kv0w0HOqNu7mbWpFbLdHTOsP1n2EsbCJOp9ZcvosUTltEgP2ogAXjNd3fRBN4U9tZodC1O+ujdrzW0qgUXmySptbFKg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=ezYdBx0y; arc=none smtp.client-ip=209.85.216.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="ezYdBx0y" Received: by mail-pj1-f99.google.com with SMTP id 98e67ed59e1d1-388b404ea89so2056829a91.0 for ; Sun, 12 Jul 2026 15:30:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783895448; x=1784500248; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=M5Hwfd1WgOYHOQEiKGvpV7zc4NRj0z5awcHqZeRtKQY=; b=jCIre49tcShaak3evdG3ecwMlEE6LKfPSbz/ufOObPRmJ97yBYVlnTcjuIdeMXksIF V0Fgozu8bM3mOC9xb+TSnp9qEEXBU5i1leN9F7+gcCeUVr71+Yrc/pav2v0xURtpOkeQ 8JGWapiHAN9e0pKBStrkGqwQNNgNlRhakeCsiOc/AWWQ2xesmfcMzlPM4X/wAlJlz0os b5vc+zundIDgwry8JCI4jox7fl8+/bGb/stvRbygC9CSYT8JEeOlWpArt3bQelyDho8h F7spMsQA95jWGyAw1wz7yPc9W/aoppe8KdsIYqogwNRitCiLnkw+pLbiu/OfhBFkoYs9 Y7vg== X-Forwarded-Encrypted: i=1; AHgh+RrFAQHuN1C5vqsD8Sx9gDcDobe8ZovNrjwrvRaRINoBd41mUnJt5n+Pe/aGRthNDKG0lJ2zZ2epGg9eALU=@vger.kernel.org X-Gm-Message-State: AOJu0YwvSaxVET4+XueVkDdkr+zo6Qy8nODHWkRLHxfEKjsxmbaIGYJO 6ox23oQfjfYqe2XDckZh7GPseq3ObUGZiqcbeK63GMGulFZo+FyuUbaJ2Xg1pNPFLsilTZFbPqm 27M7kuGNJgXdE43vwlVif+vYZ9gENl+3bAUNJjjsJdDlml93E2GVFiOcjm+KxZONXcG5U0J+Vl5 FNqQbv4yHjW9EoqQFQv4kcZuynV1rK9sBNUTYeH7bVeVcpBwqfys3ojp/7gp95d7BzvfF3cFmfv GXok6Xhz2QXLxrsaro5/5Q+gA== X-Gm-Gg: AfdE7cke59hAc7vVoKbITOD+FoZDKSAA7nl53CSSuDjGxc+LdEnNZOE+Ypc7gEEVcKg ITN+oAaVaOh6y8ReuJxHNEd0li6rXL3evNQaoEdRHpqvAjUk39DTD+3LYbdPhTpLmTSD+tvlq5T hC9U7f+K1GJdiC43tblCK/PRp6UAW5tGhOIx7GBTB/fZIM9liZyXpkUR7R1sx+miiRVlsYLDrJk zDB88+bO4dREYT8XYJi/G82uR5qRUn/RG4HjNfT9qNDrUAU5j7o3dlARojVNqR7j2UiGbxOx9He ASfeTcBRxMgaV3UvzgKEQxpd/2d8fVqigmxRr9s90z1+1Shi1igwppBorPXhetTDQGY3WPH6ICM cOw2ZKUxJZ5zPyh+UwVmjvEi3jwihcV998ReWSie+STVjWO5i6196JIvnrWSeYBeYMeVWZDEqKJ C7CNVkU4osN+RL1JgQBe/k4Nq3jACfMvCnNt0V1iOtRyhzla1Y06bT X-Received: by 2002:a17:90b:4f:b0:369:7491:7b24 with SMTP id 98e67ed59e1d1-38d13f5fb5dmr12869722a91.6.1783895447640; Sun, 12 Jul 2026 15:30:47 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-116.dlp.protect.broadcom.com. [144.49.247.116]) by smtp-relay.gmail.com with ESMTPS id 5a478bee46e88-31174a8431csm972414eec.25.2026.07.12.15.30.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 12 Jul 2026 15:30:47 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c9c26587e67so2567515a12.0 for ; Sun, 12 Jul 2026 15:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1783895445; x=1784500245; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=M5Hwfd1WgOYHOQEiKGvpV7zc4NRj0z5awcHqZeRtKQY=; b=ezYdBx0ylQD2SJbb68gSWTy/hTMv6ujoZIi/mkht3ETFMEyV3+s97ybmvQ5iYE5NZB A6YfiH4OmGGr0XTglYTYXz7VpGQBzGl+A3FN2kdPEIqr9BHRJ4icVFUaOvuJdgg86voV iqeHh+J3unDL45VbnJYX29iuEWvugNNH3ArVY= X-Forwarded-Encrypted: i=1; AHgh+RpD1r0sXLRxdpH/0Huy7eidK90MReMHAdXnVrDKOrA8zb5VIhJVfhN3PDvKtwkck7uGAB951Y/rWyqHJa8=@vger.kernel.org X-Received: by 2002:a05:6a21:164a:b0:3b3:3506:cf3f with SMTP id adf61e73a8af0-3c0f085cddamr12242630637.1.1783895445304; Sun, 12 Jul 2026 15:30:45 -0700 (PDT) X-Received: by 2002:a05:6a21:164a:b0:3b3:3506:cf3f with SMTP id adf61e73a8af0-3c0f085cddamr12242613637.1.1783895444870; Sun, 12 Jul 2026 15:30:44 -0700 (PDT) Received: from [192.168.178.26] (f215227.upc-f.chello.nl. [80.56.215.227]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b924258a2sm35908753c88.1.2026.07.12.15.30.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jul 2026 15:30:43 -0700 (PDT) Message-ID: <99c2c345-c594-46e1-b48a-de7f6e52e1c6@broadcom.com> Date: Mon, 13 Jul 2026 00:30:42 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: brcmfmac: cyw: clean up PMKID and cookie code To: Bogdan Nicolae Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, Bogdan Nicolae References: <20260709122315.11400-1-bogdan.nicolae@gmail.com> Content-Language: en-US From: Arend van Spriel In-Reply-To: <20260709122315.11400-1-bogdan.nicolae@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 09/07/2026 14:23, Bogdan Nicolae wrote: > Avoid setting packet_id to cookie, which is always 0. Instead, use an > increasing atomic counter. Avoids mismatches of completion events later > in brcmf_notify_mgmt_tx_status, where packet_id != vif->mgmt_tx_id is > checked. > > Also, zero out auth_status on initialization. Otherwise, garbage will > leak from the stack to the firmware (when bssid is less than 32 bytes > and/or when params->pmkid is set). Then, pass the params->pmkid to the > firmware (without it, the firmware caches a garbage PMKID on successful > authentication and denies a subsequent association request that includes > the PMKID). > > Signed-off-by: Bogdan Nicolae I always get a bit confused when people use different email addresses to send and sign-off patches. > --- > .../net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c > index ce09d44fa..cca53ff19 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c > @@ -23,6 +23,8 @@ > #define MGMT_AUTH_FRAME_DWELL_TIME 4000 > #define MGMT_AUTH_FRAME_WAIT_TIME (MGMT_AUTH_FRAME_DWELL_TIME + 100) > > +static atomic_t brcmf_cyw_mgmt_tx_id = ATOMIC_INIT(0); > + > static int brcmf_cyw_set_sae_pwd(struct brcmf_if *ifp, > struct cfg80211_crypto_settings *crypto) > { > @@ -155,7 +157,7 @@ int brcmf_cyw_mgmt_tx(struct wiphy *wiphy, struct wireless_dev *wdev, > > memcpy(&mf_params->da[0], &mgmt->da[0], ETH_ALEN); > memcpy(&mf_params->bssid[0], &mgmt->bssid[0], ETH_ALEN); > - mf_params->packet_id = cpu_to_le32(*cookie); > + mf_params->packet_id = cpu_to_le32(atomic_inc_return(&brcmf_cyw_mgmt_tx_id)); As I understand things the cookie value here is an output parameter. The driver should assign it: + *cookie = atomic_inc_return(&brcmf_cyw_mgmt_tx_id); mf_params->packet_id = cpu_to_le32(*cookie); > memcpy(mf_params->data, &buf[DOT11_MGMT_HDR_LEN], > le16_to_cpu(mf_params->len)); > Regards, Arend