Re: [PATCH v2 1/2] i2c: qcom-geni: add OPP table support

[Manikanta Mylavarapu <quic_mmanikan@quicinc.com>]

On 9/5/2025 3:57 AM, Andi Shyti wrote:
>> @@ -814,6 +817,24 @@ static int geni_i2c_probe(struct platform_device *pdev)
>>  		gi2c->clk_freq_out = I2C_MAX_STANDARD_MODE_FREQ;
>>  	}
>>  
>> +	ret = devm_pm_opp_set_clkname(&pdev->dev, "se");
> 
> /&pdev->dev/dev/
> 

Hi Andi,

Okay, sure. I will update in the next version.

>> +	if (ret)
>> +		return ret;
>> +
>> +	/* OPP table is optional */
>> +	ret = devm_pm_opp_of_add_table(dev);
>> +	if (!ret) {
>> +		opp = dev_pm_opp_find_freq_floor(dev, &freq);
>> +		if (IS_ERR(opp))
>> +			return dev_err_probe(dev, PTR_ERR(opp), "failed to find the frequency\n");
>> +		dev_pm_opp_put(opp);
>> +		ret = dev_pm_opp_set_rate(dev, freq);
>> +		if (ret)
>> +			return dev_err_probe(dev, ret, "failed to set the rate=%ld\n", freq);
> 
> %lu
> 

Okay, sure. I will update in the next version.

Thanks & Regards,
Manikanta.