mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
	Intel Graphics Development List 
	<intel-gfx@lists.freedesktop.org>,
	DRI Development List <dri-devel@lists.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Cc: "Jani Nikula" <jani.nikula@linux.intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Luben Tuikov" <luben.tuikov@amd.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Matt Roper" <matthew.d.roper@intel.com>,
	"Gustavo Sousa" <gustavo.sousa@intel.com>,
	"Balasubramani Vivekanandan"
	<balasubramani.vivekanandan@intel.com>,
	"Matt Atwood" <matthew.s.atwood@intel.com>,
	"José Roberto de Souza" <jose.souza@intel.com>,
	"Srinivasan Shanmugam" <srinivasan.s@intel.com>,
	"Lucas De Marchi" <lucas.demarchi@intel.com>,
	"Andrey Grodzovsky" <andrey.grodzovsky@amd.com>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Stephen Rothwell" <sfr@canb.auug.org.au>
Subject: Re: [PATCH 2/3] drm/scheduler: Fix elapsed_ns kernel-doc error
Date: Fri, 03 Feb 2023 12:27:55 +0100	[thread overview]
Message-ID: <99c4db33a1966bd1979817277facb4a42ba2333f.camel@pengutronix.de> (raw)
In-Reply-To: <20230203100215.31852-3-bagasdotme@gmail.com>

Am Freitag, dem 03.02.2023 um 17:02 +0700 schrieb Bagas Sanjaya:
> Stephen Rothwell reported htmldocs warnings:
> 
> include/drm/gpu_scheduler.h:232: warning: Incorrect use of kernel-doc format:          * @elapsed_ns
> include/drm/gpu_scheduler.h:238: warning: Function parameter or member 'elapsed_ns' not described in 'drm_sched_entity'
> 
> Fix the error by appending missing colon to @elapsed_ns name in its
> kernel-doc comment.
> 

Thanks, I've added this to the etnaviv tree.

Since the commit is only in -next and not a non-rebase tree yet, I
might be tempted to squash the fix into the offending commit. What
would be the right way to credit you for the fix in that case?

Regards,
Lucas

> Link: https://lore.kernel.org/linux-next/20230203135027.1a4679d3@canb.auug.org.au/
> Fixes: 248cd9b265fca6 ("drm/scheduler: track GPU active time per entity")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
>  include/drm/gpu_scheduler.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h
> index 9a50365621ed8d..9db9e5e504eeb3 100644
> --- a/include/drm/gpu_scheduler.h
> +++ b/include/drm/gpu_scheduler.h
> @@ -229,7 +229,7 @@ struct drm_sched_entity {
>  	struct rb_node			rb_tree_node;
>  
>  	/**
> -	 * @elapsed_ns
> +	 * @elapsed_ns:
>  	 *
>  	 * Records the amount of time where jobs from this entity were active
>  	 * on the GPU.


  reply	other threads:[~2023-02-03 11:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03 10:02 [PATCH 0/3] htmldocs fixes for next-20230203 Bagas Sanjaya
2023-02-03 10:02 ` [PATCH 1/3] drm/i915/doc: Escape wildcard in method names Bagas Sanjaya
2023-02-06 16:50   ` Rodrigo Vivi
2023-02-03 10:02 ` [PATCH 2/3] drm/scheduler: Fix elapsed_ns kernel-doc error Bagas Sanjaya
2023-02-03 11:27   ` Lucas Stach [this message]
2023-02-04  1:56     ` Bagas Sanjaya
2023-02-03 10:02 ` [PATCH 3/3] media: v4l2-core: Describe privacy_led field of v4l2_subdev Bagas Sanjaya
2023-05-17 18:08   ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99c4db33a1966bd1979817277facb4a42ba2333f.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=airlied@gmail.com \
    --cc=andrey.grodzovsky@amd.com \
    --cc=bagasdotme@gmail.com \
    --cc=balasubramani.vivekanandan@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo.sousa@intel.com \
    --cc=hdegoede@redhat.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=jose.souza@intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=luben.tuikov@amd.com \
    --cc=lucas.demarchi@intel.com \
    --cc=matthew.d.roper@intel.com \
    --cc=matthew.s.atwood@intel.com \
    --cc=mchehab@kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sfr@canb.auug.org.au \
    --cc=srinivasan.s@intel.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®